Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for build volumes #4423

Closed
yajo opened this issue Feb 3, 2017 · 3 comments
Closed

Add support for build volumes #4423

yajo opened this issue Feb 3, 2017 · 3 comments

Comments

@yajo
Copy link

yajo commented Feb 3, 2017

docker build supports the --volume option to add volumes at build time.

docker-compose does not have such support (or it is not docummented).

$ docker-compose version
docker-compose version 1.9.0, build 2585387
docker-py version: 1.10.6
CPython version: 2.7.13
OpenSSL version: OpenSSL 1.0.2j-fips  26 Sep 2016

$ docker info
Containers: 128
 Running: 0
 Paused: 0
 Stopped: 128
Images: 592
Server Version: 1.12.6
Storage Driver: overlay2
 Backing Filesystem: extfs
Logging Driver: journald
Cgroup Driver: systemd
Plugins:
 Volume: local
 Network: bridge host null overlay
Swarm: inactive
Runtimes: oci runc
Default Runtime: oci
Security Options: seccomp
Kernel Version: 4.9.5-200.fc25.x86_64
Operating System: Fedora 25 (Workstation Edition)
OSType: linux
Architecture: x86_64
Number of Docker Hooks: 2
CPUs: 4
Total Memory: 6.761 GiB
Name: yajolap.yajodomain
ID: KUBN:F7JL:URX6:HO55:R3L2:SCUU:IWVY:EZ2O:F53G:WHTO:3G4D:R4YU
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Insecure Registries:
 127.0.0.0/8
Registries: docker.io (secure)
@flx42
Copy link

flx42 commented Oct 4, 2017

AFAIK, only Red Hat's fork of Docker Engine support it:
https://github.com/projectatomic/docker/tree/docker-17.03.1-ce#add-volume-support-to-docker-buildpatch
moby/moby#14080

So I doubt @shin- will add it.

ymc-dabe added a commit to ymc-dabe/compose that referenced this issue Mar 1, 2018
Resolves docker#4423

Signed-off-by: Daniel Beyer <ymc-dabe@vcs.ymc.ch>
@ymc-dabe
Copy link

ymc-dabe commented Mar 1, 2018

Note that besides moby (see: moby/moby#14080), docker-py is lacking support for this as well (see: docker/docker-py#1498).

I suggest to no accept my above PR #5736 till docker-py (e.g. via PR docker/docker-py#1937) has support for build time volumes.

@ijc
Copy link

ijc commented May 22, 2019

Closing alongside #5736 docker/docker-py#1937 etc. Per docker/docker-py#1937 (comment) this is supported differently in buildkit and I don't believe that approach needs tools level changes to support. Building with buildkit from compose is already tracked elsewhere I believe.

@ijc ijc closed this as completed May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants