[WIP] Add support for build time volumes #5736
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves docker#4423 Signed-off-by: Daniel Beyer <ymc-dabe@vcs.ymc.ch>
|
Please note this this should not be merged so far, since docker-py is lacking support of build time volumes, see:
Also please do not forget to update |
|
Since this is still WIP >1yr later and both the prerequisites have both been closed (referencing docker/docker-py#1937 (comment)) I think we should close this, so that's what I'm going to do. Thanks for your contribution even if it didn't work out. WRT the link to moby/buildkit#442 (in the comment linked above) I think #6584 is relevant in that context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4423
Signed-off-by: Daniel Beyer ymc-dabe@vcs.ymc.ch