Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build method is missing a volumes argument #1498

Closed
steveb opened this issue Mar 8, 2017 · 2 comments
Closed

build method is missing a volumes argument #1498

steveb opened this issue Mar 8, 2017 · 2 comments
Labels
group/api-upgrade kind/feature-request status/wontfix

Comments

@steveb
Copy link

steveb commented Mar 8, 2017

Docker can mount read-only volumes at image build time (see docker build --volume) but this is not currently possible to do via the build method.
ymc-dabe added a commit to ymc-dabe/docker-py that referenced this issue Feb 21, 2018
@ymc-dabe
Add support for build time volumes
557c360 
Resolves docker#1498

Signed-off-by: Daniel Beyer <ymc-dabe@vcs.ymc.ch>
ymc-dabe added a commit to ymc-dabe/docker-py that referenced this issue Feb 21, 2018
@ymc-dabe
WIP: Add support for build time volumes
cd69d08 
Resolves docker#1498

Signed-off-by: Daniel Beyer <ymc-dabe@vcs.ymc.ch>
ymc-dabe added a commit to ymc-dabe/docker-py that referenced this issue Mar 1, 2018
@ymc-dabe
WIP: Add support for build time volumes
86481bb 
Resolves docker#1498

Signed-off-by: Daniel Beyer <ymc-dabe@vcs.ymc.ch>
ymc-dabe added a commit to ymc-dabe/docker-py that referenced this issue Mar 1, 2018
@ymc-dabe
Add support for build time volumes
3621b70 
Resolves docker#1498

Signed-off-by: Daniel Beyer <ymc-dabe@vcs.ymc.ch>
@ymc-dabe ymc-dabe mentioned this issue Mar 1, 2018
Closed
ymc-dabe added a commit to ymc-dabe/docker-py that referenced this issue Mar 1, 2018
@ymc-dabe
Add support for build time volumes
14aea52 
Resolves docker#1498

Signed-off-by: Daniel Beyer <ymc-dabe@vcs.ymc.ch>
@ymc-dabe
Copy link

ymc-dabe commented Mar 1, 2018

I doubt that this makes it into docker-py before moby/moby#14080 is resolved, but nevertheless I added support in PR #1937 for it. It especially is useful if one uses a patched docker, that has support for build time volumes (e.g. Project Atomic or balena - I think Fedora and RHEL have patched-in support as well).

This was referenced Mar 1, 2018
Closed
Closed
@socketpair socketpair mentioned this issue Apr 28, 2018
Open
@shin-
Copy link
Contributor

shin- commented Jun 18, 2018

Closing for the reasons explained in #1937 (comment)

@shin- shin- closed this as completed Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
group/api-upgrade kind/feature-request status/wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveb @ymc-dabe @shin-