Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert DOM creation/manipuation code to concise Solid JSX #1716

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Commits on Jan 7, 2022

  1. convert some DOM creation code to Solid JSX

    This updates Rollup and replaces Buble with Babel (we're already using Babel anyway) to add babel-preset-solid for compiling Solid JSX expressions.
    
    At the moment this breaks the current SSR feature.
    trusktr committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    388ceba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    badcf91 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2022

  1. get tests running

    We had to pin the `colors` library (used by live-server)because the
    author wilfully broke it to disrupt millions of users.
    Marak/colors.js#285
    trusktr committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    5de5e5e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b17826f View commit details
    Browse the repository at this point in the history
  3. update docker test script

    trusktr committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    fd494bd View commit details
    Browse the repository at this point in the history
  4. Turn the corner, cover, and main tpl functions into Solid components …

    …with props, then use them as JSX
    trusktr committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    9658ed4 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2022

  1. pin playwright to 1.8 to avoid regressions, and fix flaky tests

    Playwright had some in-range breaking changes (regressions): microsoft/playwright#10819 and microsoft/playwright#11570
    
    Playwright tests need to `await onceRendered()` after each route navigation to wait for render to finish before testing the state of the rendered DOM. Tests were flaky because they were looking for DOM before render finished (sometimes).
    
    Additionally, this fixes one test that was failing only locally, but not in CI, due to a RegExp check against page.url() (not sure why it would differ on CI vs local, but now the URL is explicit).
    trusktr committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    38f2d24 View commit details
    Browse the repository at this point in the history