-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert DOM creation/manipuation code to concise Solid JSX #1716
Draft
trusktr
wants to merge
7
commits into
develop
Choose a base branch
from
dom-with-solid
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jan 7, 2022
-
convert some DOM creation code to Solid JSX
This updates Rollup and replaces Buble with Babel (we're already using Babel anyway) to add babel-preset-solid for compiling Solid JSX expressions. At the moment this breaks the current SSR feature.
Configuration menu - View commit details
-
Copy full SHA for 388ceba - Browse repository at this point
Copy the full SHA 388cebaView commit details -
Configuration menu - View commit details
-
Copy full SHA for badcf91 - Browse repository at this point
Copy the full SHA badcf91View commit details
Commits on Jan 10, 2022
-
We had to pin the `colors` library (used by live-server)because the author wilfully broke it to disrupt millions of users. Marak/colors.js#285
Configuration menu - View commit details
-
Copy full SHA for 5de5e5e - Browse repository at this point
Copy the full SHA 5de5e5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b17826f - Browse repository at this point
Copy the full SHA b17826fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd494bd - Browse repository at this point
Copy the full SHA fd494bdView commit details -
Turn the corner, cover, and main tpl functions into Solid components …
…with props, then use them as JSX
Configuration menu - View commit details
-
Copy full SHA for 9658ed4 - Browse repository at this point
Copy the full SHA 9658ed4View commit details
Commits on Jan 23, 2022
-
pin playwright to 1.8 to avoid regressions, and fix flaky tests
Playwright had some in-range breaking changes (regressions): microsoft/playwright#10819 and microsoft/playwright#11570 Playwright tests need to `await onceRendered()` after each route navigation to wait for render to finish before testing the state of the rendered DOM. Tests were flaky because they were looking for DOM before render finished (sometimes). Additionally, this fixes one test that was failing only locally, but not in CI, due to a RegExp check against page.url() (not sure why it would differ on CI vs local, but now the URL is explicit).
Configuration menu - View commit details
-
Copy full SHA for 38f2d24 - Browse repository at this point
Copy the full SHA 38f2d24View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.