Manually merge 3.0.x into master #4432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proofread upgrade guide
Fix headline in the upgrade docs
When using PDO, an exception is supposed to be thrown since we are using the error mode that behaves that way. It only seems to be the case since PHP 8 though.
Fix php8 mysql mariadb
Update PHP_CodeSniffer to 3.5.8
Store query params in driver exceptions
Remove warning comment from PDOOracle driver
Add missing instanceof check
…olon-prefix Deprecate colon prefix for prepared statement parameters
…n-prefix Remove support for colon prefix in statement parameters
Deprecate inappropriate usage of prepared statement parameters
This effectively prevented phpstan from inferring type of `T` template. > Unable to resolve the template type T in call to method static method Doctrine\DBAL\DriverManager::getConnection()
ResultCacheStatement::fetchAllAssociative does not store results in cache
Testing Guidelines
Update .gitattributes
Add missing word
QueryBuilder must use 0-based positional parameter keys
Mark SQLParserUtils internal
This fixes the issue detailed in doctrine#4391, with SQL Server and SQL Anywhere setting WITH (NOLOCK) for LockMode::NONE, which effectively means using a READ UNCOMMITTED isolation level at table level, which is not the contract of LockMode::NONE.
LockMode::NONE should not set WITH (NOLOCK)
Throw exception on invalid LockMode
Port the SQL parser from PDO
Remove redundant phpstan param from DriverManager::getConnection()
greg0ire
approved these changes
Nov 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.