Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sign in using personal accounts #3892

Merged
merged 78 commits into from
Aug 18, 2022
Merged

Allow sign in using personal accounts #3892

merged 78 commits into from
Aug 18, 2022

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Aug 16, 2022 •
edited
Loading

jorg-vr added 30 commits June 29, 2022 15:14
@jorg-vr
Add registration only for institutional users setting
f3103ea
@jorg-vr
Add institutional users visibility setting
6510b25
@jorg-vr
Add vissibility and registration info translations
22e13d4
@jorg-vr
Limit visibillity of courses
d2d4abf
@jorg-vr
Limit registration for institutional users
f10dfe8
@jorg-vr
Fix tests
e55d787
@jorg-vr
Add tests
080cfc2
@jorg-vr
Merge branch 'develop' into feature/institutional-users-course-privacy
8f2dfa0
@jorg-vr
Allow personal users
b550457
@jorg-vr
Allow personal accounts for office 365
50dfa17
@jorg-vr
Don't ask for contact details
a7916e9
@jorg-vr
Put raw info in log
f9920a1
@jorg-vr
Readd contacts to scope to see difference
82d01a1
@jorg-vr
Fix office365 provider to use new api
6d27c92
@jorg-vr
Fix bug
562dfbb
@jorg-vr
Lift restrictions that blocked personal providers
4a7f0d3
@jorg-vr
Add and fix tests
148ad02
@jorg-vr
Add test for office 365 migration
f4925f1
@jorg-vr
Only allow identfier based on email log in to work for old identifiers
224a4a4
@jorg-vr
Fix linting
8d447af
@jorg-vr
Update sign in page
5177737
@jorg-vr
Move comment to the correct line
1ede9bf
@jorg-vr
Update config/locales/views/auth/nl.yml
8008231
@jorg-vr
Update privacy announcement to also cover personal accounts
0d1e1d4
@jorg-vr
Update english version of the privacy statement
daf0620
@jorg-vr
Update dutch privacy statement
146fa13
@jorg-vr
Change the name of google workspace to google
f3c5ee0
@jorg-vr
Merge branch 'develop' into feature/institutional-users-course-privacy
abf7b4f
@jorg-vr
Remove visible for institutional users setting
3ec2615
@jorg-vr
Make texts clearer
9b0ff8d
jorg-vr and others added 8 commits August 16, 2022 16:43
@jorg-vr
Update dutch privacy stateement to better differentiate between priva…
6dd4a51 
…te and institutional users
@jorg-vr
Update english privacy statement
7792121
@jorg-vr @chvp
Update app/views/pages/privacy.en.html.erb
e32c603 
Co-authored-by: Charlotte Van Petegem <charlotte.vanpetegem@ugent.be>
@jorg-vr @chvp
Update app/views/pages/privacy.nl.html.erb
514424c 
Co-authored-by: Charlotte Van Petegem <charlotte.vanpetegem@ugent.be>
@jorg-vr
Merge pull request #3855 from dodona-edu/feature/update-privacy-policy
3f122d0 
Update privacy declaration to also cover personal accounts
@jorg-vr
Make changes a migration
7d708a8
@jorg-vr
Merge pull request #3806 from dodona-edu/feature/allow-personal-users
8f8cdd0 
Allow personal accounts
@jorg-vr
Merge pull request #3859 from dodona-edu/feature/force-privacy-policy
b2faeb0 
Force new private users to accept the privacy policy before creating an account
@jorg-vr jorg-vr temporarily deployed to naos August 18, 2022 08:59 Inactive
@jorg-vr
Copy link
Contributor Author

jorg-vr commented Aug 18, 2022

Tested everything together on naos and it works

@jorg-vr jorg-vr marked this pull request as ready for review August 18, 2022 09:04
@jorg-vr jorg-vr requested a review from a team as a code owner August 18, 2022 09:04
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team August 18, 2022 09:04
bmesuere
bmesuere requested changes Aug 18, 2022
View reviewed changes
config/locales/views/auth/nl.yml Outdated Show resolved Hide resolved
config/locales/views/auth/en.yml Outdated Show resolved Hide resolved
config/locales/views/courses/en.yml Outdated Show resolved Hide resolved
config/locales/views/courses/en.yml Outdated Show resolved Hide resolved
config/locales/views/courses/nl.yml Outdated Show resolved Hide resolved
config/locales/views/courses/nl.yml Outdated Show resolved Hide resolved
jorg-vr and others added 2 commits August 18, 2022 14:05
@jorg-vr jorg-vr temporarily deployed to naos August 18, 2022 12:09 Inactive
@jorg-vr jorg-vr temporarily deployed to naos August 18, 2022 12:20 Inactive
@jorg-vr jorg-vr temporarily deployed to naos August 18, 2022 12:33 Inactive
@jorg-vr jorg-vr temporarily deployed to naos August 18, 2022 12:37 Inactive
@jorg-vr jorg-vr requested a review from bmesuere August 18, 2022 12:40
@jorg-vr jorg-vr merged commit 1d839f1 into develop Aug 18, 2022
@jorg-vr jorg-vr deleted the feature/personal-accounts branch August 18, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chvp chvp chvp approved these changes

@bmesuere bmesuere bmesuere approved these changes

Assignees

@jorg-vr jorg-vr

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Personal Dodona accounts
3 participants
@jorg-vr @bmesuere @chvp