*: PBR - netlink interaction and basic definitions #2

Handle the return value of argv_find_and_parse_afi() to avoid passing along bad values. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

…ian-file debianpkg: Add missing frr-dbg.lintian-overrides to Makefile

bgpd: fix some coverity scan issues

Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

Signed-off-by: Mitesh Kanjariya<mitesh@cumulusnetworks.com>

Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.comy>

Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

Upon a l3vni delete (no vni under a vrf) is executed, we should uninstall all the RMACs and NHs associated with the l3vni. This is because by the time we get a route delete in zebra l3vni is already deleted and we dont have refernce to RMACs and NHs Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

When a remote VTEP next hop entry (for symmetric routing) becomes stale, reinstall it. This makes the behavior the same as what is done for remote host next hops (for asymmetric routing and ARP suppression). Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

Currently, kernel doesn't support ipv6 routes with ipv4 nexthops. To avoid the crash, we will only attach l3-vni related RTs/ecommunities only to ipv4 host routes. Ticket: CM-18743 Review: ccr-6912 Testing: Manaul Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

BGP VRF can be created/deleted either via config or via l3vni add/del. We need to handle various sequences. 1. If user config is presented, an l3vni del should not delete the vrf instance 2. do not write bgp config in show running for auto created vrf 2. If l3vni present, disallow the cli for deleting bgp vrf instance 3. If l3vni is added and vrf config is present set the flags properly 4. if bgp vrf is configured unset the AUTO flag Ticket: CM-18630 Review: CCR-6906 Testing: Manual Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

Ticket: CM-18821 Review: Trivial Testing: Manual Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

currently, we have a rd_id bitfield to assign an unique index for auto RD. This bitfield currently resides under struct bgp which seems wrong. We need to shift this to a global space as this ID space is really global per box. One more reason to keep it at a global data structure is, the ID space could be used by both VNIs and VRFs. Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

1. VRF RD can be auto-derived (simillar to RD for a VNI) 2. VRF RD can be configured manually through a config Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

For EVPN type-5 route the NH in the NLRI is set to the local tunnel ip. This information has to be obtained from kernel notification. We need to pass this info from zebra to bgp in l3vni call flow. This patch doesn't handle the tunnel-ip change. Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

CLI config for enabling/disabling type-5 routes router bgp <as> vrf <vrf> address-family l2vpn evpn [no] advertise <ipv4|ipv6|both> loop through all the routes in VRF instance and advertise/withdraw all ip routes as type-5 routes in default instance. Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

when router-id/RD changes for a bgp vrf instance, we need to update all type-5 routes. Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

… type-5 routes for EVPN routes prefixlen filed in struct prefix represents the sizeof of the struct rather than the actual prefix len. This is later used in looking up route node in RIB. Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

When we receive an MP_UNREACH, we try to uninstall routes from the VRF and the VNI. The route-node in the VRF corresponds to the ip prefix formed from EVPN prefix. We should correctly form the prefix based on the EVPN route-type. Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

EVPN is only enabled when user configures advertise-all-vni. All VNIs (L2 and L3) should be cleared upon removal of this config. Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

Was using 0 as a sentinel value, so user couldn't configure 0 as the value of the coalesce timer. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

bgpd: fix config display of coalesce-time

configure: exclude some checks not needed on clippy host build

Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

Sa from clang

Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

This reverts commit d9e5b00. ETH_ALEN is not equivalent to ETHER_HDR_LEN. ETHER_HDR_LEN is the definition for the length of the full ethernet header, meanwhile ETH_ALEN is just the length of the ethernet address. Here is the OpenBSD/FreeBSD definition for ETHER_HDR_LEN: #define ETHER_ADDR_LEN 6 /* Ethernet address length */ #define ETHER_TYPE_LEN 2 /* Ethernet type field length */ #define ETHER_HDR_LEN ((ETHER_ADDR_LEN * 2) + ETHER_TYPE_LEN) (OpenBSD's definition is at net/if_ether.h, FreeBSD's is at net/ethernet.h) Linux definitions can be found at: net/ethernet.h #define ETHER_ADDR_LEN ETH_ALEN /* size of ethernet addr */ #define ETHER_TYPE_LEN 2 /* bytes in type field */ #define ETHER_HDR_LEN ETH_HLEN /* total octets in header */ net/if_ether.h: #define ETH_HLEN 14 /* Total octets in header. */ #define ETH_ALEN 6 /* Octets in one ethernet addr */ Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

@SharpD

- used @SharpD's slack patch as a starting point - fixes compile time issue, but code path not tested Signed-off-by: Raymond P. Burkholder <github@oneunified.net>

The json code was freeing json_paths and then turning around and free'ing it again. Newer versions of json-c have started to assert this bad behavior. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

pimd: Really, Actually send S,G rpt prune upstream

Add Linux Realms and some Pim Documentation

Store selected_fib as a pointer off of rib_dest_t

Json fixes

bgpd: Speedup vtysh handling of 'show bgp afi safi json' display

Unbreak ISIS Hellos (FreeBSD)

…minor-perf bgpd: minor performance enhancement

Simple ring buffer implementation useful for fixed size FIFO queues. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Problems reported with inconsistent use of parameters for bgp network statements. Converted 12 DEFUNs to 2 DEFPY statements, making the parameter use consistent with the exception of keeping the "backdoor" keywork ipv4 only. Also verified that if a route-map or label-index is specified in the "no" case it matches what had been previously defined. Manual testing looks good and bgp-smoke will be performed before pushing. Ticket: CM-16860 Signed-off-by: Don Slice <dslice@cumulusnetworks.com> Reviewed-by: CCR-7056

Peek functionality for ring buffers and associated tests. Also: * Slight optimization to avoid 0-byte memcpy() by changing > to >= * Add rv checks for some ringbuf_[put|get] calls that were missing them in the test Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Ticket:CM-19213 Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

When ospf6 configure with redistribute connected/protocol with route-map. Upon restart of frr.service, ospf6 receives redistribute update then route-map update. During redistribute route update, since route-map info is not filled, route is suppressed from injected as external route. Fix: reset redistribute when route-map update received matches with redistribution (type) and route-map name. Ticket:CM-13800 Testing Done: Configure ospf6 redistribute with route-map to inject Type-2 external routes into database. Trigger frr restart redistribute with route-map happens. Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

Signed-off-by: Raymond P. Burkholder <github@oneunified.net>

debianpkg: fix indentation and variable name

ospf6d: Fix ospf6 redist with route-map

ospfd: Set filter to unbound debug logs

…16860 bgpd: convert network statements from DEFUN to DEFPY

The rn can not have an rn->info pointer and as such the dest may be NULL. Don't assign the old_fib pointer if so. This is ok because we know RNODE_FOREACH... will not iterate if dest is NULL. Fixes: FRRouting#1575 Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib: add ring buffer

zebra: Fix dest dereference

Handle RFC 2328 16.4 Calculating AS external routes with ECMP For ASBR route, if it is learnt via new LSA and contains different nexthop list. First lookup route in ospf6 route table if it exists, merge nexthop list to existing and call the callback to install into FIB (zebra). Delete created new route as it is identical to existing entry in route table. Ticket:CM-16139 Testing Done: Run two ASBR with 2 ECMP paths from each DUT neighbor receievs 4 ECMP path to a external route. ospf6 installs all 4 ECMP path to FIB/RIB Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

When PIM handles some MSDP commands, a repeated command was causing a CMD_WARNING_CONFIG_FAILED. This should be a CMD_WARNING. Fix the code to allow vtysh to handle this appropriately. Ticket: CM-19053 Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Signed-off-by: lihongguang <lhg803@163.com>

ospfd: return non-zero for configuration failures

For some reason bgp is calculating the peer uptime in miliseconds incorrectly. Additionally we have the peer_uptime function call that should be doing this! But since we've choosen different names for the json output we cannot fix it at this point. uptime contains the number of seconds of uptime here. Just multiply by 1k and display that( as peer_uptime does ) Fixes: FRRouting#1585 Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

The bgpTimerUp value was incorrectly named, add a correct name bgpTimerUpMsec and add some code to allow for deprecation. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Quick 'n easy way to copy the contents of one ringbuf to another. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

* Fix rare failure caused when end pointer is at end of buffer memory and a call to ringbuf_get() is made that reads all of the data in the buffer; start pointer was advanced past end pointer, causing some special handling to be skipped * Fix ringbuf_peek() moving start pointer * Fix use after free * Remove extraneous assignment * Update relevant tests Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

The multithreading code has a comment that reads: "XXX: Heavy abuse of stream API. This needs a ring buffer." This patch makes the relevant code use a ring buffer. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

For no interface <ifname> vrf VRFNAME, vrf-name is not parsed properly. Ticket:CM-19274 Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

Signed-off-by: lihongguang lhg803@163.com

ospfd: fix [no] area authentication command

-Werror=sign-compare is failing with signed/unsigned usage in the conditional expression. Fixes: FRRouting#1593 Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Signed-off-by: Dario Wiesner <dario.wiesner@gmail.com>

bgpd: fix failing to compile on 32 bit systems

Signed-off-by: ßingen <bingen@voltanet.io>

bgpd: add PMSI_TUNNEL_ATTRIBUTE to EVPN IMET routes

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

The BGP IO thread must be running before other threads can start using it. So at startup check to see that it running once, instead of before every function call into. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

More thread yield

ldpd: Add privs to label manager

Ticket: CM-19365 Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

lib: Fix no interface cmd vrf parsing

pimd: Add finer grain return codes for configuration

ospfd: Fix no passive interface command parsing

The 'ip pim use-source ...' command returns a hard success/failure. Allow it to return a soft-failure for when we re-enter the same line. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com> Before ------ cel-redxp-10(config)# router ospf vrf RED cel-redxp-10(config-router)# network 1.1.1.1/32 area 0.0.0.0 cel-redxp-10(config-router)# network 1.1.1.1/32 area 0.0.0.0 There is already same network statement. cel-redxp-10(config-router)# When we see the "There is already same network statement." message vtysh exits non-zero. This scenario breaks frr-reload because the command took and it in the config, it should exit zero here. After ----- cel-redxp-10(config)# router ospf vrf RED cel-redxp-10(config-router)# network 1.1.1.1/32 area 0.0.0.0 cel-redxp-10(config-router)# network 1.1.1.1/32 area 0.0.0.0 cel-redxp-10(config-router)# network 1.1.1.1/32 area 0.0.0.0 cel-redxp-10(config-router)# network 1.1.1.1/32 area 0 cel-redxp-10(config-router)# cel-redxp-10(config-router)# network 1.1.1.1/32 area 0.0.0.1 There is already same network statement. cel-redxp-10(config-router)#

When printing responses from a client, vtysh searches through every response it receives twice. Once is to look for the terminating sequence and the other is to translate \n to \0, which is used with the line processing callback capability. However: * There's no need to search all of the output for the terminator, we can just check the last 4 bytes. * In most scenarios we won't have a callback. Therefore we don't need to process the output and can just dump it. Together these optimizations have a significant impact on the total runtime of talkative CLI commands, such as `sh ip bgp json` which runs roughly 1000% faster when dumping 1,000,000 routes. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Replace atomic spinlock with condition variable. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

bgpd: use atomic_* ops on _Atomic variables

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Condition needs to be set inside critical section, otherwise i/o thread can deadlock. Also unlock mutex once finished with it, no need to hold the lock for the life of the program. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

If we have configured neighbor 1.1.1.1 for an afi/safi but they have not activated that afi/safi with us then display "NoNeg" in the state column of the summary output. This is to make troubleshooting afi/safi easier. Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

pimd: Allow use-source to return more subtle error codes

Problem reported that when "systemctl restart networking" was performed, prefixes previously redistributed into bgp from connected were deleted from the bgp table. Determined that we were not correctly changing the redistribution bitmask when the vrf_id of the vrf was changed. This patch corrects that behavior. Manual tests look good. bgp-min and vrf-min completed with no new failures. Ticket: CM-19369 Signed-off-by: Don Slice <dslice@cumulusnetworks.com> Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: Fix peer uptime display in milliseconds

bgpd: use ring buffer for network input

bgpd: fix updating redist bitmask when vrf_id changes

bgpd: 'summary' to show NoNeg if peer did not negotiate afi/safi

sharpd: add .gitignore

ospfd: do not complain if same area is reconfigured

There are certain interfaces that when brought up and we receive the netlink notification about it, the speed of the interface is not set correctly. This creates a one-shot thread that will wait 15 seconds and then requery the speed and if it is different it will renotify the running daemons. The kernel should notify us on speed changes, unfortunately this is not done currently via a netlink message as you would think. As I understand it there is some in-fighting about the proper way to approach this issue and due to the way the kernel release cycle works we are a ways off from getting this fixed. This is a `hack` to make us work correctly while we wait for the true answer. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

The constant to limit # of allowed cli tokens on any one line was defined in multiple places, all inconsistent with each other. Fix. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

When a peer configured with administrative shutdown is added to a peer group, the administrative shutdown status is discarded and the peer will enter the BGP FSM. This is not what we want. Preserve the flag instead. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

… value Signed-off-by: Lou Berger <lberger@labn.net>

lib, bgpd: fixup use of of CMD_ARGC_MAX

Support for Evpn symmetric routing + EVPN Prefix route

Signed-off-by: Lou Berger <lberger@labn.net>

…vnc-config bgp: don't show vnc response-lifetime config line when set to default…

The zapi_ipv4_route, zapi_ipv6_route and zapi_ipv4_route_ipv6_nexthop functions are deprecated. Add notice of when we can remove the deprecated code from the system. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Modify if_lookup_by_index to accept a VRF_UNKNOWN as a vrf_id. This will cause it to look in all vrf's for the interface pointer. Subsequently all if_XXXX functions that call this function will also get this behavior. VRF_UNKNOWN *should* not be used for interface creation as that this will break some core assumptions. This work is part of allowing vrf route leaking. Currently it is possible to create a route in the linux kernel that has a nexthop across vrf boundaries. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

With VRF route-leaking we need to know what vrf the nexthops are in compared to this vrf. This code adds the nh_vrf_id to the route entry and sets it up correctly for the non-route-leaking case. The assumption here is that future commits will make the nh_vrf_id *different* than the vrf_id. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Use the nexthop vrf_id to properly lookup the ifp pointer for display purposes. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Add to the rib_add function the ability to pass in the nexthops vrf. Additionally when we decode the netlink message from the linux kernel, properly figure out the nexthops vrf_id. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

When we are handling nexthops in zebra, use the appropriate vrf to figure out if the nexthops are active or not. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

If the vrf for the nexthop is different than the vrf the route is in, display the nexthops vrf. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Modify the code to send and receive to/from zebra the nexthops vrf_id. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Move the NS/VRF initialization code for zebra to an earlier point in startup. In the future we will have code that will want to install_element into a VRF_NODE from zebra_vty.c Signed-off-by: Donald Sharp <sahrpd@cumulusnetworks.com>

Add a function to handle the route leaking of a static route. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Optimize vrf_config_write a tiny bit to be a bit more efficient. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Add the ability to accept 'ip route ...' commands from within a vrf context. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Move the code that generates the 'show run' output for 'ip route' to be controlled by the vrf config generation code. Since it really belongs there. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

In order for routes to be leaked the ifindex must be sent down into the kernel over the netlink protocol. So send it( we always figure it out ) when we add the route. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Allow this to work: vrf DONNA ip route 4.3.2.1/32 192.168.1.5 nexthop-vrf EVA The static route code was not properly telling the nexthop resolution code what vrf to use. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Allow the end user to specify static routes that leak across vrf's in the default vrf. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com> For issue FRRouting#1548

Add ability to set file destination for all vtysh output, with the exception of tab-complete and similar meta output. This is useful for inline recording of some information without exiting the shell. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Remove the ability to attempt to configure a couple of options on directly connected neighbors that don't make sense for them, as well as the soft error handling code. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Adds ability to specify that peers should be administratively shutdown when first configured. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Signed-off-by: Lou Berger <lberger@labn.net>

…e_shot zebra: Add one-shot thread to recheck speed

Add OSPFv3 Protocol incoming/outgoing packets stats. r3# show ipv6 ospf6 interface traffic Interface HELLO DB-Desc LS-Req LS-Update LS-Ack Rx/Tx Rx/Tx Rx/Tx Rx/Tx Rx/Tx -------------------------------------------------------------------------------------------- swp1 3/4 2/2 0/2 8/6 3/2 swp2 3/4 2/2 0/1 7/3 2/0 swp3 0/4 0/0 0/0 0/0 0/0 Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

ospf6d: Add protocol stats and show command

…rectly-connected bgpd: disallow invalid config at cli layer

…vnc2zebra bgpd: fix handling of nhp_ary when exporting vrf routes to zebra

ospfd: Speed up show ip ospf [vrf all] route json

…up-sync improve bgpd thread startup characteristics

BGP "allowas-in" should accept AS paths with "local-as"

vtysh: optimize printout routine

…hutdown-override bgpd: preserve admin shutdown on peer-group add

There are some observed instances where we end up trying to cancel a rw job based on a file descriptor that we don't have a reference on. The specific cancel function for rw jobs assumes it's called with a file descriptor that is valid within pollfds and will cause a segmentation fault by buffer overrun if this is not the case. Instead log it and move on. Since the fd does not exist this should patch over the buggy behavior and provide additional information to help in finding the root cause. Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com> Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

BGP auto-shutdown

vtysh: add ability to output to file

Current json output does not differentiate start of interface objects. Adding "interfaces" keyword at the beginning of the interface list. This is useful when displaying vrf level output along with interface list. Ticket:CM-19115 Testing Done: show ip ospf vrf all interface json show ip ospf vrf all interface <specific intf> json show ip ospf interface json show ip ospf interface <specific intf> json Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

* Clarify that FRR implements as well as manages protocols * Move IS-IS out of "early support" * Add Babel - friends don't leave friends out of READMEs! * Add mention of further information Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

Inform the .clang-format file about LSDB_LOOP and put the proper indentation for this loop into the code. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

The peer->hash pointer is allocating a bunch of memory but is never used. Remove. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

ospfd: LSDB_LOOP treat it as a loop.

bgpd: Remove peer->hash as that it is unused

Build redhat rpm's with FPM. It's a module so not a bad idea. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

When we receive a read failure in handling a FPM read let's add a bit more information to what we think has gone wrong, in a hope that debugging will be a bit easier. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

frr: update README

tools: frr-reload 'vni' keyword does not always create a sub-context

lib: avoid crash when cancelling invalid rw job

ospf6d: Fix External routes ECMP

…pr1629-no-json bgpd: fix reporting of no vpn routes (no json)

- In ospfd and isisd documentation, Traffic Engineering examples are referring to old interface syntax. Update both examples to 'link-param' syntax. Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>

ospfd: show ip ospf interface json output format

…s up During VRF change handling, the connected route for the interface should be installed only if the interface is up. Otherwise, we end up with duplicate connected routes which can lead to other problems. Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com> Reviewed-by: Don Slice <dslice@cumulusnetworks.com> Ticket: CM-19364 Reviewed By: CCR-7099 Testing Done: Manual verification

zebra: Install connected routes during VRF change only if interface i…

This is a preparatory work for configuring vrf/frr over netns vrf structure is being changed to 32 bit, and the VRF will have the possibility to have a backend made up of NETNS. Let's put some history. Initially the 32 bit was because one wanted to map on vrf_id both the VRFLITE and the NSID. Initially, one would have liked to make zebra configure at the same time both vrf lite and vrf from netns in a flat way. From the show running perspective, one would have had both kind of vrfs, thatone would configure on the same way. however, it leads to inconsistencies in concepts, because it mixes vrf vrf with vrf, and vrf is not always mapped with netns. For instance, logical-router could also be used with netns. In that case, it would not be possible to map vrf with netns. There was an other reason why 32 bit is proposed. this is because some systems handle NSID to 32 bits. As vrf lite exists only on Linux, there are other systems that would like to use an other vrf backend than vrf lite. The netns backend for vrf will be used for that too. for instance, for windows or freebsd, some similar netns concept exists; so it will be easier to reuse netns backend for vrf, than reusing vrflite backend for vrf. This commit is here to extend vrf_id to 32 bits. Following commits in a second step will help in enable a VRF backend. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

The number of vrf bitmap groups is increased so as to avoid consuming too much memory. This fix is related to a fork memory that occured when running pimd as daemon. A check on memory consumed shows that the memory consumed goes from 33480ko to 46888ko with that change. This is less compared to if the value of the bitmap groups is increased to 16 ( 852776ko). Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

Because the VRF_ID is mapped into 32 bit, and because when NETNS will be the backend of VRF, then the NS identifier must also be encoded as 32 bit. Also, the NS_UNKNOWN value is changed accordingly to UINT32_MAX. Also, the NS_UNKNOWN and NS_DEFAULT values are removed from zebra_ns.h and kept on ns.h header file. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

the change of vrf_id field from 16 bit to 32 bit leads to some changes in other daemon. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

Changes due to the change of vrf_id_t moved from 16 bits to 32 bits. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

The change of vrf_id_t from 16 bit to 32 bit needs some changes in pim daemon. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

The VRF_DEFAULT parameter is incorrectly used. The 0 value for the bgp instance is passed instead. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com> fixup bgpd: fix compilation issue with bgpd

On some places of code, the VRF_DEFAULT define was not used. This commit is ensuring that the macros is well used. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

On some places, macro NS_DEFAULT was not used. This commit is replacind on some identified places where 0 can be replaced with NS_DEFAULT macro. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

Netns Support / passing vrf_id_t to 32 bit work

Doc: Update OSPF-TE and ISIS-TE example

redhat: Build with FPM

Fix and rename the label stack to be better named. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

The function zserv_create_header was exactly the same as zclient_create_header. Let's just have one in the system. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

When a nexthop is resolved via a label based nexthop, copy the labels into the newly created recursive nexthop. Please note that this does not fix the case where we have a label based nexthop that is recursively resolved through *another* nexthop that is also label based. In this case we need to create a new label stack for those routes. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

bgp: small fix for write to 'address-family l2vpn evpn' configuration

Mpls

(to be consistent with last_write updates) Signed-off-by: Lou Berger <lberger@labn.net>

…consistent_count bgpd: update last_update whenever obuf sent

…ring zebra route-leaking for static routes

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Add the PBRD as a command that vtysh can interact with. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Add the infrastructure for the pbr_vty.[ch] code Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

The nh_resolve_via_default function is an accessor function for NHT in zebra. Let's move this function to it's proper place. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Add an initial cli to allow people to mock this up some. "pbr-policy (1-100000) {src <A.B.C.D/M|X:X::X:X/M>|dest <A.B.C.D/M|X:X::X:X/M>} nexthop-group NAME" Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

pbr_map.[ch] will contain the code that handles the policy-mapping. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Add some code to tell git what to ignore. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Add code that tracks creation and deletion of the nexthop-group. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Implement netlink interactions for Policy Based Routing. This includes APIs to install and uninstall rules and handle notifications from the kernel related to rule addition or deletion. Various definitions are added to facilitate this. Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com> Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: PBR - netlink interaction and basic definitions #2

*: PBR - netlink interaction and basic definitions #2

Commits on Dec 14, 2017

Commits on Dec 15, 2017

Commits on Dec 18, 2017

Commits on Dec 19, 2017

Commits on Dec 21, 2017

Commits on Dec 26, 2017

Commits on Dec 27, 2017

Commits on Dec 30, 2017

Commits on Jan 2, 2018

Commits on Jan 3, 2018

Commits on Jan 4, 2018

Commits on Jan 5, 2018

Commits on Jan 6, 2018

Commits on Jan 8, 2018

Commits on Jan 9, 2018

Commits on Jan 10, 2018

Commits on Jan 11, 2018

Commits on Jan 12, 2018

Commits on Jan 14, 2018

Commits on Jan 15, 2018

Commits on Jan 16, 2018

Commits on Jan 17, 2018

Commits on Jan 18, 2018

Commits on Jan 19, 2018

Commits on Jan 21, 2018

Commits on Jan 22, 2018

Commits on Jan 23, 2018

Commits on Jan 24, 2018

Commits on Jan 26, 2018

Commits on Jan 31, 2018

Commits on Feb 4, 2018