[build] remove Xamarin.Android.CSharp.targets
#9609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `Xamarin.Android.CSharp.targets` as this file is only used in Xamarin.Android projects! SDK-style project rely on "magical" imports when you have `$(TargetPlatformIdentifier)=android`, and so projects do not ever import this file directly. Removing this file led me to find other files we can delete: * `build-tools\scripts\MonoAndroidFramework.props` imported by some Xamarin.Android projects in the repo. * `samples\VSAndroidApp` unused Xamarin.Android sample * `tests\Mono.Android-Tests\Runtime-AppBundle` unused Xamarin.Android test project * `tests\Mono.Android-Tests\Runtime-MultiDex` unused Xamarin.Android test project I also removed any Xamarin.Android `.csproj` file, where I found a ".NET" equivalent. We could likely remove even more in the future, but we'd want to check if the code or tests could be useful.
jonathanpeppers
requested review from
grendello,
dellis1972 and
jonpryor
as code owners
There was a problem hiding this comment.
Copilot reviewed 34 out of 54 changed files in this pull request and generated no suggestions.
Files not reviewed (20)
- build-tools/scripts/MonoAndroidFramework.props: Language not supported
- build-tools/scripts/MonoAndroidFramework.targets: Language not supported
- samples/HelloWorld/HelloLibrary/HelloLibrary.csproj: Language not supported
- samples/HelloWorld/HelloWorld/HelloWorld.csproj: Language not supported
- samples/VSAndroidApp/Assets/AboutAssets.txt: Language not supported
- samples/VSAndroidApp/Properties/AndroidManifest.xml: Language not supported
- samples/VSAndroidApp/Resources/AboutResources.txt: Language not supported
- samples/VSAndroidApp/Resources/layout/activity_main.xml: Language not supported
- samples/VSAndroidApp/Resources/layout/content_main.xml: Language not supported
- samples/VSAndroidApp/Resources/menu/menu_main.xml: Language not supported
- samples/VSAndroidApp/Resources/mipmap-anydpi-v26/ic_launcher.xml: Language not supported
- samples/VSAndroidApp/Resources/mipmap-anydpi-v26/ic_launcher_round.xml: Language not supported
- samples/VSAndroidApp/Resources/values/colors.xml: Language not supported
- samples/VSAndroidApp/Resources/values/dimens.xml: Language not supported
- samples/VSAndroidApp/Resources/values/ic_launcher_background.xml: Language not supported
- samples/VSAndroidApp/Resources/values/strings.xml: Language not supported
- samples/VSAndroidApp/Resources/values/styles.xml: Language not supported
- samples/VSAndroidApp/VSAndroidApp.csproj: Language not supported
- samples/VSAndroidApp/MainActivity.cs: Evaluated as low risk
- samples/VSAndroidApp/Properties/AssemblyInfo.cs: Evaluated as low risk
|
We can ignore the one APK test failure: |
dellis1972
approved these changes
Dec 10, 2024
grendello
added a commit
that referenced
this pull request
Jan 7, 2025
* main: (25 commits) [CI] Break "Linux Tests" into 2 parallel jobs. (#9642) Fix `WorkloadDependencies.proj` build. (#9648) [CI] Set "WearOS Tests" parallelization to 2 agents. (#9639) [CI] Break "Package Tests" into 2 parallel jobs. (#9638) Bump to DevDiv/android-platform-support@3b4e16f1 (#9632) [NativeAOT] improve build logic, part 2 (#9631) Bump to dotnet/java-interop@2c06b3c2 (#9633) [NativeAOT] improve build logic, part 1 (#9614) [build] Generate `WorkloadDependencies.json` (#9613) [monodroid] remove `monodroid_get_log_categories()` (#9625) [monodroid] remove `_monodroid_get_identity_hash_code` (#9622) Bump to dotnet/java-interop@f800ea52 (#9607) [XABT] Break BuildApk into individual tasks for each content type. (#9612) [Mono.Android] Bind Android API-Baklava DP1 (#9594) [Xamarin.Android.Build.Tasks] Extract `BuildArchive` from `BuildApk` (#9556) [NativeAOT] MSBuild-related logic to get projects to build (#9583) [build] remove remnants of `OpenTK-1.0.dll` (#9610) [build] remove `Xamarin.Android.CSharp.targets` (#9609) [build] runtime "flavors" part 2 (#9598) Bump com.android.tools.build:manifest-merger to 31.7.3 (#9600) ...
grendello
added a commit
that referenced
this pull request
Jan 7, 2025
* dev/grendel/use-libc++: (25 commits) [CI] Break "Linux Tests" into 2 parallel jobs. (#9642) Fix `WorkloadDependencies.proj` build. (#9648) [CI] Set "WearOS Tests" parallelization to 2 agents. (#9639) [CI] Break "Package Tests" into 2 parallel jobs. (#9638) Bump to DevDiv/android-platform-support@3b4e16f1 (#9632) [NativeAOT] improve build logic, part 2 (#9631) Bump to dotnet/java-interop@2c06b3c2 (#9633) [NativeAOT] improve build logic, part 1 (#9614) [build] Generate `WorkloadDependencies.json` (#9613) [monodroid] remove `monodroid_get_log_categories()` (#9625) [monodroid] remove `_monodroid_get_identity_hash_code` (#9622) Bump to dotnet/java-interop@f800ea52 (#9607) [XABT] Break BuildApk into individual tasks for each content type. (#9612) [Mono.Android] Bind Android API-Baklava DP1 (#9594) [Xamarin.Android.Build.Tasks] Extract `BuildArchive` from `BuildApk` (#9556) [NativeAOT] MSBuild-related logic to get projects to build (#9583) [build] remove remnants of `OpenTK-1.0.dll` (#9610) [build] remove `Xamarin.Android.CSharp.targets` (#9609) [build] runtime "flavors" part 2 (#9598) Bump com.android.tools.build:manifest-merger to 31.7.3 (#9600) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
Xamarin.Android.CSharp.targetsas this file is only used in Xamarin.Android projects! SDK-style projects rely on "magical" imports when you have$(TargetPlatformIdentifier)=android, and so projects do not ever import this file directly.Removing this file led me to find other files we can delete:
build-tools\scripts\MonoAndroidFramework.propsimported by some Xamarin.Android projects in the repo.samples\VSAndroidAppunused Xamarin.Android sampletests\Mono.Android-Tests\Runtime-AppBundleunused Xamarin.Android test projecttests\Mono.Android-Tests\Runtime-MultiDexunused Xamarin.Android test projectI also removed any Xamarin.Android
.csprojfile, where I found a ".NET" equivalent. We could likely remove even more in the future, but we'd want to check if the code or tests could be useful.