[build] Generate `workload-dependencies.json` #9613

jonpryor · 2024-12-12T16:46:25Z

Context: Releases.json loop
Context: xamarin/xamarin-macios#21779 (comment)

There is a desire to have the .NET Workloads have a machine readable description of what dependencies they require in order to run, in order to facilitate tooling that would check for these dependencies.

Add tools/workload-dependencies, a new tool which parses a "Xamarin Manifest" to generate workload-dependencies.json. The "canonical" location for the "Xamarin Manifest" is within external/android-platform-support/Feeds/AndroidManifestFeed_d17.12.xml; failing that, https://aka.ms/AndroidManifestFeed/d17-12 can be used.

Output of the tool is a JSON document specifying ther required JDK and Android SDK packages which the .NET for Android workload requires:

{
  "microsoft.net.sdk.android": {
    "workload": {
      "alias": [
        "android"
      ],
      "version": "35.0.100"
    },
    "jdk": {
      "version": "[17.0,18.0)",
      "recommendedVersion": "17.0.12"
    },
    "androidsdk": {
      "packages": [
        {
          "desc": "Android SDK Build-Tools 35",
          "sdkPackage": {
            "id": "build-tools;*",
            "version": "[30.0.2,30.0.3,31.0.0,32.0.0,33.0.0,33.0.1,33.0.2,33.0.3,34.0.0,35.0.0]",
            "recommendedId": "build-tools;35.0.0",
            "recommendedVersion": "35.0.0"
          },
          "optional": "false"
        },
        {
          "desc": "Android SDK Command-line Tools",
          "sdkPackage": {
            "id": "cmdline-tools;*",
            "version": "[5.0,6.0,7.0,8.0,9.0,10.0,11.0,12.0,13.0]",
            "recommendedId": "cmdline-tools;13.0",
            "recommendedVersion": "13.0"
          },
          "optional": "false"
        },
        {
          "desc": "Android SDK Platform 28",
          "sdkPackage": {
            "id": "platforms;android-*",
            "version": "[1,1,1,2,2,2,2,3,3,3,3,3,3,5,6]",
            "recommendedId": "platforms;android-28",
            "recommendedVersion": "6"
          },
          "optional": "false"
        },
        {
          "desc": "Android SDK Platform-Tools",
          "sdkPackage": {
            "id": "platform-tools",
            "version": "[33.0.2,33.0.3,34.0.1,34.0.3,34.0.4,34.0.5,35.0.1,35.0.2]",
            "recommendedId": "platform-tools",
            "recommendedVersion": "35.0.2"
          },
          "optional": "false"
        },
        …
      ]
    }
  }
}

Copilot reviewed 1 out of 3 changed files in this pull request and generated no suggestions.

Files not reviewed (2)

build-tools/create-packs/Microsoft.NET.Sdk.Android.proj: Language not supported
tools/workload-dependencies/workload-dependencies.csproj: Language not supported

Comments skipped due to low confidence (2)

tools/workload-dependencies/Program.cs:277

The error message should specify the element that is missing the required attribute for better debugging.

throw new InvalidOperationException ($"Missing required attribute `{attribute}` in: `{e}");

tools/workload-dependencies/Program.cs:219

The CreatePackagesArray method should have test coverage to ensure its correctness.

JArray CreatePackagesArray (XDocument doc)

Context: [`Releases.json` loop][0] Context: xamarin/xamarin-macios#21779 (comment) There is a desire to have the .NET Workloads have a machine readable description of what dependencies they require in order to run, in order to facilitate tooling that would check for these dependencies. Add `tools/workload-dependencies`, a new tool which parses a "Xamarin Manifest" to generate `workload-dependencies.json`. The "canonical" location for the "Xamarin Manifest" is within `external/android-platform-support/Feeds/AndroidManifestFeed_d17.12.xml`; failing that, <https://aka.ms/AndroidManifestFeed/d17-12> can be used. Output of the tool is a JSON document specifying ther required JDK and Android SDK packages which the .NET for Android workload requires: { "microsoft.net.sdk.android": { "workload": { "alias": [ "android" ], "version": "35.0.100" }, "jdk": { "version": "[17.0,18.0)", "recommendedVersion": "17.0.12" }, "androidsdk": { "packages": [ { "desc": "Android SDK Build-Tools 35", "sdkPackage": { "id": "build-tools;*", "version": "[30.0.2,30.0.3,31.0.0,32.0.0,33.0.0,33.0.1,33.0.2,33.0.3,34.0.0,35.0.0]", "recommendedId": "build-tools;35.0.0", "recommendedVersion": "35.0.0" }, "optional": "false" }, { "desc": "Android SDK Command-line Tools", "sdkPackage": { "id": "cmdline-tools;*", "version": "[5.0,6.0,7.0,8.0,9.0,10.0,11.0,12.0,13.0]", "recommendedId": "cmdline-tools;13.0", "recommendedVersion": "13.0" }, "optional": "false" }, { "desc": "Android SDK Platform 35", "sdkPackage": { "id": "platforms;android-*", "version": "[2,2,3,2,3,2,3,6,5,3,1,1,3,3,1]", "recommendedId": "platforms;android-35", "recommendedVersion": "1" }, "optional": "false" }, { "desc": "Android SDK Platform-Tools", "sdkPackage": { "id": "platform-tools", "version": "[33.0.2,33.0.3,34.0.1,34.0.3,34.0.4,34.0.5,35.0.1,35.0.2]", "recommendedId": "platform-tools", "recommendedVersion": "35.0.2" }, "optional": "false" }, … ] } } } [0]: https://loop.cloud.microsoft/p/eyJ1IjoiaHR0cHM6Ly9taWNyb3NvZnQuc2hhcmVwb2ludC1kZi5jb20vc2l0ZXMvYzIyZmVjMDMtN2I4OS00OTJhLTgzNzQtZmZjMTI4YjMwMWRhP25hdj1jejBsTWtaemFYUmxjeVV5Um1NeU1tWmxZekF6TFRkaU9Ea3RORGt5WVMwNE16YzBMV1ptWXpFeU9HSXpNREZrWVNaa1BXSWxNakZXTUhSeU9XY3dRbk5WYlhVdFJWUjNRVEZNY0dOSmQwdG1VVEZUZFVFeFRuRk5XbVZ3TUhVd1dUaEhkVVpKVlRSUGIxWnlVMWxoZFRaT2RFODRTamhISm1ZOU1ERlhSelkwU0RNMU56TlZRbEpITWs1TU1rSkdTemRZV1ZCWFJqSlNTRVJQVENaalBTVXlSaVpoUFV4dmIzQkJjSEFtY0QwbE5EQm1iSFZwWkhnbE1rWnNiMjl3TFhCaFoyVXRZMjl1ZEdGcGJtVnlKbmc5SlRkQ0pUSXlkeVV5TWlVelFTVXlNbFF3VWxSVlNIaDBZVmRPZVdJelRuWmFibEYxWXpKb2FHTnRWbmRpTW14MVpFTXhhMXBwTldwaU1qRTRXV2xHVjAxSVVubFBWMk4zVVc1T1ZtSllWWFJTVmxJelVWUkdUV05IVGtwa01IUnRWVlJHVkdSVlJYaFVia1pPVjIxV2QwMUlWWGRYVkdoSVpGVmFTbFpVVWxCaU1WcDVWVEZzYUdSVVdrOWtSVGcwVTJwb1NHWkVRWGhXTUdNeVRrVm5lazU2VGtwVU1WRXdWMnQwUmxGNldrdFRSbXhaVlRCYVVWUlZhRlJXUlVaRFYyeEZKVE5FSlRJeUpUSkRKVEl5YVNVeU1pVXpRU1V5TWprNE5HUXhZMlpoTFRnMVpXUXROR1kyWXkxaU9EWmlMVFJtTXpZMU1EQXlaak5tTnlVeU1pVTNSQT09In0%3D?ct=1728330820992&

jonathanpeppers · 2024-12-12T18:22:40Z

build-tools/create-packs/Microsoft.NET.Sdk.Android.proj

+      <_Feed Condition=" Exists($(_AndroidPlatformSupportFeed)) ">$(_AndroidPlatformSupportFeed)</_Feed>
+      <_Feed Condition=" '$(_Feed)' == '' ">https://aka.ms/AndroidManifestFeed/d17-12</_Feed>
+      <_Project>$(MSBuildThisFileDirectory)/../../tools/workload-dependencies/workload-dependencies.csproj</_Project>
+      <WorkloadDependenciesPath Condition="'$(WorkloadDependenciesPath)' == ''">$(OutputPath)workload-manifest\workload-dependencies.json</WorkloadDependenciesPath>


Is this the right file name? Because this puts the file alongside:

data/workload-dependencies.json data/WorkloadManifest.json data/WorkloadManifest.targets

It's named WorkloadDependencies.json on the xamarin-macios PR:

https://github.com/xamarin/xamarin-macios/pull/21779/files#diff-872f5970dd49423b8504426e1aeeb497247956de18fdcd473cd912af2ba82e2aR5

Good question! The spec called for workload-dependencies.json, but has since changed. I'll need to update.

jonathanpeppers

Regarding the block:

        {
          "desc": "Android SDK Platform 28",
          "sdkPackage": {
            "id": "platforms;android-*",
            "version": "[1,1,1,2,2,2,2,3,3,3,3,3,3,5,6]",
            "recommendedId": "platforms;android-28",
            "recommendedVersion": "6"
          },
          "optional": "false"
        },

In .NET 9 Preview 6:

https://github.com/dotnet/android/blob/release/9.0.1xx-preview6/src/Xamarin.Android.Build.Tasks/Microsoft.NET.Sdk.Android/WorkloadManifest.in.json

We required API-34 for the android workload and API-35 for the preview android-35 workload.

Do we need the ability to have different requirements per workload? This file gives one version for every workload in the manifest.

jonpryor · 2024-12-12T19:04:33Z

@jonathanpeppers wrote:

Regarding the block…

I had a chat with @Redth, and I'm gonna need to simplify and constrain the output. For starters:

No more version keys; I don't see how they're helpful.
No more wildcards; platforms/android-* isn't helpful either!
No more "bizarro optional" packages; extras such as extras;google;instantapps are not helpful.
More integration with dotnet/android: we should list one platforms/android-* value, and it should be the default API level as per $(AndroidLatestStableApiLevel)
Ditto for the JDK, and should be based on some form of $(JavaSdkVersion), so that if/when we bump that to 21, it's correctly updated.

Context: #9613 (comment) A lot of the previous output was nonsensical, especially around `version`s, in large part because I was trying to associate the `//*/@revision` attribute in the Feed to a version. This sometimes works, e.g. for build-tools and platform-tools, but would fail horribly for things like `<platform/>`, resulting in JSON fragments such as: { "desc": "Android SDK Platform 28", "sdkPackage": { "id": "platforms;android-*", "version": "[1,1,1,2,2,2,2,3,3,3,3,3,3,5,6]", "recommendedId": "platforms;android-28", "recommendedVersion": "6" }, "optional": "false" }, Make to fundamental architectural changes: 1. Instead of trying to emit JSON for *everything* in the feed, only emit JSON for a minimal subset of known required+optional pieces, such as platform-tools (required) and the emulator and system images (optional). 2. Drop the idea of "version", "recommendedId", and "recommendedVersion". This results in a much smaller and more sensible: { "microsoft.net.sdk.android": { "workload": { "alias": [ "android" ], "version": "35.0.100" }, "jdk": { "version": "[17.0,18.0)", "recommendedVersion": "17.0.12" }, "androidsdk": { "packages": [ { "desc": "Android SDK Build-Tools 35", "sdkPackage": { "id": "build-tools;35.0.0" }, "optional": "false" }, { "desc": "Android SDK Command-line Tools", "sdkPackage": { "id": "cmdline-tools;13.0" }, "optional": "false" }, { "desc": "Android Emulator", "sdkPackage": { "id": "emulator" }, "optional": "true" }, { "desc": "NDK (Side by side) 27.1.12297006", "sdkPackage": { "id": "ndk;27.1.12297006" }, "optional": "true" }, { "desc": "Android SDK Platform 35", "sdkPackage": { "id": "platforms;android-35" }, "optional": "false" }, { "desc": "Android SDK Platform Baklava (Preview)", "sdkPackage": { "id": "platforms;android-Baklava" }, "optional": "true" }, { "desc": "Android SDK Platform-Tools", "sdkPackage": { "id": "platform-tools" }, "optional": "false" }, { "desc": "Google APIs ARM 64 v8a System Image", "sdkPackage": { "id": { "win-x64": "system-images;android-35;google_apis;x86_64", "mac-x64": "system-images;android-35;google_apis;x86_64", "linux-x64": "system-images;android-35;google_apis;x86_64", "mac-arm64": "system-images;android-35;google_apis;arm64-v8a", "linux-arm64": "system-images;android-35;google_apis;arm64-v8a" } }, "optional": "true" } ] } } }

jonpryor · 2024-12-13T16:53:13Z

@Redth : how does the JSON mentioned here look? 52182a0

Provide NDK version.

jonpryor · 2024-12-14T00:53:53Z

@jonathanpeppers: the "Android SDK Platform" block is now:

        {
          "desc": "Android SDK Platform 35",
          "sdkPackage": {
            "id": "platforms;android-35"
          },
          "optional": "false"
        },

This also has a "solution" around preview packages: list is as optional:

        {
          "desc": "Android SDK Platform Baklava (Preview)",
          "sdkPackage": {
            "id": "platforms;android-Baklava"
          },
          "optional": "true"
        },

jonpryor · 2024-12-16T16:10:30Z

Draft commit message:

Context: [`Releases.json` loop][0]
Context: https://github.com/xamarin/xamarin-macios/pull/21779#discussion_r1876519440
Context: 51151d727a0438dd049ad2678f9039d8f255d7b2
Context: 60bb447b869de9bce3d9f0bf754ea2a493d0709f
Context: f9b2c972263f279aba52919d2b442a319d7c7ad0

The `GetAndroidDependencies` target (f9b2c972) and the
`InstallAndroidDependencies` target (60bb447b) are used to determine
and install the Android SDK dependencies required to build a project.

Unfortunately, in order to run these targets, a project must exist!

There is a desire to have the .NET Workloads contain machine readable
descriptions of what dependencies they require in order to run, in
order to facilitate tooling that would check for these dependencies
*without* requiring that a project exist.

Add `tools/workload-dependencies`, a new tool which parses a
"Xamarin Manifest" to generate `WorkloadDependencies.json`,
with versions controlled by `Xamarin.Installer.Common.props`
(51151d72).  The "canonical" location for the "Xamarin Manifest" is
`external/android-platform-support/Feeds/AndroidManifestFeed_d17.12.xml`;
failing that, <https://aka.ms/AndroidManifestFeed/d17-12> can be used.

Output of the tool is a JSON document specifying ther required JDK
and Android SDK packages which the .NET for Android workload requires:

	{
	  "microsoft.net.sdk.android": {
	    "workload": {
	      "alias": [
	        "android"
	      ],
	      "version": "35.99.0-ci.pr.gh9613.79"
	    },
	    "jdk": {
	      "version": "[17.0,18.0)",
	      "recommendedVersion": "17.0.12"
	    },
	    "androidsdk": {
	      "packages": [
	        {
	          "desc": "Android SDK Build-Tools 35",
	          "sdkPackage": {
	            "id": "build-tools;35.0.0"
	          },
	          "optional": "false"
	        },
	        {
	          "desc": "Android SDK Command-line Tools",
	          "sdkPackage": {
	            "id": "cmdline-tools;12.0"
	          },
	          "optional": "false"
	        },
	        {
	          "desc": "Android Emulator",
	          "sdkPackage": {
	            "id": "emulator",
	            "recommendedVersion": "35.1.20"
	          },
	          "optional": "true"
	        },
	        {
	          "desc": "NDK (Side by side) 26.1.10909125",
	          "sdkPackage": {
	            "id": "ndk;26.1.10909125"
	          },
	          "optional": "true"
	        },
	        {
	          "desc": "Android SDK Platform 35",
	          "sdkPackage": {
	            "id": "platforms;android-35"
	          },
	          "optional": "false"
	        },
	        {
	          "desc": "Android SDK Platform Baklava (Preview)",
	          "sdkPackage": {
	            "id": "platforms;android-Baklava"
	          },
	          "optional": "true"
	        },
	        {
	          "desc": "Android SDK Platform-Tools",
	          "sdkPackage": {
	            "id": "platform-tools",
	            "recommendedVersion": "34.0.5"
	          },
	          "optional": "false"
	        },
	        {
	          "desc": "Google APIs ARM 64 v8a System Image",
	          "sdkPackage": {
	            "id": {
	              "win-x64": "system-images;android-35;google_apis;x86_64",
	              "mac-x64": "system-images;android-35;google_apis;x86_64",
	              "linux-x64": "system-images;android-35;google_apis;x86_64",
	              "mac-arm64": "system-images;android-35;google_apis;arm64-v8a",
	              "linux-arm64": "system-images;android-35;google_apis;arm64-v8a"
	            }
	          },
	          "optional": "true"
	        }
	      ]
	    }
	  }
	}

[0]: https://loop.cloud.microsoft/p/eyJ1IjoiaHR0cHM6Ly9taWNyb3NvZnQuc2hhcmVwb2ludC1kZi5jb20vc2l0ZXMvYzIyZmVjMDMtN2I4OS00OTJhLTgzNzQtZmZjMTI4YjMwMWRhP25hdj1jejBsTWtaemFYUmxjeVV5Um1NeU1tWmxZekF6TFRkaU9Ea3RORGt5WVMwNE16YzBMV1ptWXpFeU9HSXpNREZrWVNaa1BXSWxNakZXTUhSeU9XY3dRbk5WYlhVdFJWUjNRVEZNY0dOSmQwdG1VVEZUZFVFeFRuRk5XbVZ3TUhVd1dUaEhkVVpKVlRSUGIxWnlVMWxoZFRaT2RFODRTamhISm1ZOU1ERlhSelkwU0RNMU56TlZRbEpITWs1TU1rSkdTemRZV1ZCWFJqSlNTRVJQVENaalBTVXlSaVpoUFV4dmIzQkJjSEFtY0QwbE5EQm1iSFZwWkhnbE1rWnNiMjl3TFhCaFoyVXRZMjl1ZEdGcGJtVnlKbmc5SlRkQ0pUSXlkeVV5TWlVelFTVXlNbFF3VWxSVlNIaDBZVmRPZVdJelRuWmFibEYxWXpKb2FHTnRWbmRpTW14MVpFTXhhMXBwTldwaU1qRTRXV2xHVjAxSVVubFBWMk4zVVc1T1ZtSllWWFJTVmxJelVWUkdUV05IVGtwa01IUnRWVlJHVkdSVlJYaFVia1pPVjIxV2QwMUlWWGRYVkdoSVpGVmFTbFpVVWxCaU1WcDVWVEZzYUdSVVdrOWtSVGcwVTJwb1NHWkVRWGhXTUdNeVRrVm5lazU2VGtwVU1WRXdWMnQwUmxGNldrdFRSbXhaVlRCYVVWUlZhRlJXUlVaRFYyeEZKVE5FSlRJeUpUSkRKVEl5YVNVeU1pVXpRU1V5TWprNE5HUXhZMlpoTFRnMVpXUXROR1kyWXkxaU9EWmlMVFJtTXpZMU1EQXlaak5tTnlVeU1pVTNSQT09In0%3D?ct=1728330820992&

…-json

jonpryor · 2024-12-17T20:13:34Z

/azp run

azure-pipelines · 2024-12-17T20:14:03Z

Azure Pipelines successfully started running 1 pipeline(s).

Context: 51151d7 Commit 51151d7 laid out a conundrum: dotnet/android builds against one set of versioned dependencies, but we want the "Xamarin Manifest" to *actually* dictate the preferred package versions, as this makes it easier to keep versions in sync with the VS installer/etc. The problem is that commits prior to this point ignored the `Xamarin.Installer.Common.props` described in 51151d7. Additionally, many of the MSBuild properties are (1) "conditional" -- only setting a value if not overridden -- and (2) have the same names as the properties within `Xamarin.Installer.Common.props`. Square this circle by doing two things: 1. Add `tools/workload-dependencies/WorkloadDependencies.proj` alongside `tools/workload-dependencies/Directory.Build.props`, which allows for an "isolated" environment, one in which *only* `Xamarin.Installer.Common.props` and `Xamarin.Android.Common.props` are imported. This allows us to cleanly ensure that `Xamarin.Installer.Common.props` controls things. 2. Update `Microsoft.NET.Sdk.Android.proj` to use the `<MSBuild/>` task to invoke `WorkloadDependencies.proj`, providing all MSBuild properties required for things to work. This should ensure that package versions are consistent. Additionally, update `Program.cs` so that the `platform-tools` package contains a `requestedRevision` property. The `platform-tools` package is *unversioned*, so this is the only way to get some semblance of versioning involved.

jonpryor · 2024-12-17T20:31:08Z

/azp run

azure-pipelines · 2024-12-17T20:31:41Z

Azure Pipelines successfully started running 1 pipeline(s).

jonpryor · 2024-12-17T20:48:35Z

Current JSON output:

{
  "microsoft.net.sdk.android": {
    "workload": {
      "alias": [
        "android"
      ],
      "version": "35.99.0-ci.pr.gh9613.79"
    },
    "jdk": {
      "version": "[17.0,18.0)",
      "recommendedVersion": "17.0.12"
    },
    "androidsdk": {
      "packages": [
        {
          "desc": "Android SDK Build-Tools 35",
          "sdkPackage": {
            "id": "build-tools;35.0.0"
          },
          "optional": "false"
        },
        {
          "desc": "Android SDK Command-line Tools",
          "sdkPackage": {
            "id": "cmdline-tools;12.0"
          },
          "optional": "false"
        },
        {
          "desc": "Android Emulator",
          "sdkPackage": {
            "id": "emulator",
            "requestedRevision": "35.1.20"
          },
          "optional": "true"
        },
        {
          "desc": "NDK (Side by side) 26.1.10909125",
          "sdkPackage": {
            "id": "ndk;26.1.10909125"
          },
          "optional": "true"
        },
        {
          "desc": "Android SDK Platform 35",
          "sdkPackage": {
            "id": "platforms;android-35"
          },
          "optional": "false"
        },
        {
          "desc": "Android SDK Platform Baklava (Preview)",
          "sdkPackage": {
            "id": "platforms;android-Baklava"
          },
          "optional": "true"
        },
        {
          "desc": "Android SDK Platform-Tools",
          "sdkPackage": {
            "id": "platform-tools",
            "requestedRevision": "34.0.5"
          },
          "optional": "false"
        },
        {
          "desc": "Google APIs ARM 64 v8a System Image",
          "sdkPackage": {
            "id": {
              "win-x64": "system-images;android-35;google_apis;x86_64",
              "mac-x64": "system-images;android-35;google_apis;x86_64",
              "linux-x64": "system-images;android-35;google_apis;x86_64",
              "mac-arm64": "system-images;android-35;google_apis;arm64-v8a",
              "linux-arm64": "system-images;android-35;google_apis;arm64-v8a"
            }
          },
          "optional": "true"
        }
      ]
    }
  }
}

Redth · 2024-12-17T21:33:03Z

For the android emulator... s/requestedVersion/recommendedVersion ?

and then also i think the logic will be if there's no version value, any version installed is considered acceptable, however if you have nothing installed, we'll install the recommendedVersion

jonpryor · 2024-12-17T21:34:04Z

/azp run

azure-pipelines · 2024-12-17T21:34:33Z

Azure Pipelines successfully started running 1 pipeline(s).

jonathanpeppers · 2024-12-17T21:48:52Z

tools/workload-dependencies/workload-dependencies.csproj

+
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <TargetFramework>net9.0</TargetFramework>


Can this be either $(DotNetStableTargetFramework) or $(DotNetTargetFramework)? So would be net9.0 vs net10.0 when we get on .NET 10.

jonpryor · 2024-12-18T03:02:40Z

/azp run

azure-pipelines · 2024-12-18T03:03:09Z

Azure Pipelines successfully started running 1 pipeline(s).

Context: [`Releases.json` loop][0] Context: xamarin/xamarin-macios#21779 (comment) Context: 51151d7 Context: 60bb447 Context: f9b2c97 The `GetAndroidDependencies` target (f9b2c97) and the `InstallAndroidDependencies` target (60bb447) are used to determine and install the Android SDK dependencies required to build a project. Unfortunately, in order to run these targets, a project must exist! There is a desire to have the .NET Workloads contain machine readable descriptions of what dependencies they require in order to run, in order to facilitate tooling that would check for these dependencies *without* requiring that a project exist. Add `tools/workload-dependencies`, a new tool which parses a "Xamarin Manifest" to generate `WorkloadDependencies.json`, with versions controlled by `Xamarin.Installer.Common.props` (51151d7). The "canonical" location for the "Xamarin Manifest" is `external/android-platform-support/Feeds/AndroidManifestFeed_d17.12.xml`; failing that, <https://aka.ms/AndroidManifestFeed/d17-12> can be used. Output of the tool is a JSON document specifying ther required JDK and Android SDK packages which the .NET for Android workload requires. This document is `data/WorkloadDependencies.json` within the `Microsoft.NET.Sdk.Android.Manifest*.nupkg` NuGet package. { "microsoft.net.sdk.android": { "workload": { "alias": [ "android" ], "version": "35.99.0-ci.pr.gh9613.79" }, "jdk": { "version": "[17.0,18.0)", "recommendedVersion": "17.0.12" }, "androidsdk": { "packages": [ { "desc": "Android SDK Build-Tools 35", "sdkPackage": { "id": "build-tools;35.0.0" }, "optional": "false" }, { "desc": "Android SDK Command-line Tools", "sdkPackage": { "id": "cmdline-tools;12.0" }, "optional": "false" }, { "desc": "Android Emulator", "sdkPackage": { "id": "emulator", "recommendedVersion": "35.1.20" }, "optional": "true" }, { "desc": "NDK (Side by side) 26.1.10909125", "sdkPackage": { "id": "ndk;26.1.10909125" }, "optional": "true" }, { "desc": "Android SDK Platform 35", "sdkPackage": { "id": "platforms;android-35" }, "optional": "false" }, { "desc": "Android SDK Platform Baklava (Preview)", "sdkPackage": { "id": "platforms;android-Baklava" }, "optional": "true" }, { "desc": "Android SDK Platform-Tools", "sdkPackage": { "id": "platform-tools", "recommendedVersion": "34.0.5" }, "optional": "false" }, { "desc": "Google APIs ARM 64 v8a System Image", "sdkPackage": { "id": { "win-x64": "system-images;android-35;google_apis;x86_64", "mac-x64": "system-images;android-35;google_apis;x86_64", "linux-x64": "system-images;android-35;google_apis;x86_64", "mac-arm64": "system-images;android-35;google_apis;arm64-v8a", "linux-arm64": "system-images;android-35;google_apis;arm64-v8a" } }, "optional": "true" } ] } } } [0]: https://loop.cloud.microsoft/p/eyJ1IjoiaHR0cHM6Ly9taWNyb3NvZnQuc2hhcmVwb2ludC1kZi5jb20vc2l0ZXMvYzIyZmVjMDMtN2I4OS00OTJhLTgzNzQtZmZjMTI4YjMwMWRhP25hdj1jejBsTWtaemFYUmxjeVV5Um1NeU1tWmxZekF6TFRkaU9Ea3RORGt5WVMwNE16YzBMV1ptWXpFeU9HSXpNREZrWVNaa1BXSWxNakZXTUhSeU9XY3dRbk5WYlhVdFJWUjNRVEZNY0dOSmQwdG1VVEZUZFVFeFRuRk5XbVZ3TUhVd1dUaEhkVVpKVlRSUGIxWnlVMWxoZFRaT2RFODRTamhISm1ZOU1ERlhSelkwU0RNMU56TlZRbEpITWs1TU1rSkdTemRZV1ZCWFJqSlNTRVJQVENaalBTVXlSaVpoUFV4dmIzQkJjSEFtY0QwbE5EQm1iSFZwWkhnbE1rWnNiMjl3TFhCaFoyVXRZMjl1ZEdGcGJtVnlKbmc5SlRkQ0pUSXlkeVV5TWlVelFTVXlNbFF3VWxSVlNIaDBZVmRPZVdJelRuWmFibEYxWXpKb2FHTnRWbmRpTW14MVpFTXhhMXBwTldwaU1qRTRXV2xHVjAxSVVubFBWMk4zVVc1T1ZtSllWWFJTVmxJelVWUkdUV05IVGtwa01IUnRWVlJHVkdSVlJYaFVia1pPVjIxV2QwMUlWWGRYVkdoSVpGVmFTbFpVVWxCaU1WcDVWVEZzYUdSVVdrOWtSVGcwVTJwb1NHWkVRWGhXTUdNeVRrVm5lazU2VGtwVU1WRXdWMnQwUmxGNldrdFRSbXhaVlRCYVVWUlZhRlJXUlVaRFYyeEZKVE5FSlRJeUpUSkRKVEl5YVNVeU1pVXpRU1V5TWprNE5HUXhZMlpoTFRnMVpXUXROR1kyWXkxaU9EWmlMVFJtTXpZMU1EQXlaak5tTnlVeU1pVTNSQT09In0%3D?ct=1728330820992&

* main: (25 commits) [CI] Break "Linux Tests" into 2 parallel jobs. (#9642) Fix `WorkloadDependencies.proj` build. (#9648) [CI] Set "WearOS Tests" parallelization to 2 agents. (#9639) [CI] Break "Package Tests" into 2 parallel jobs. (#9638) Bump to DevDiv/android-platform-support@3b4e16f1 (#9632) [NativeAOT] improve build logic, part 2 (#9631) Bump to dotnet/java-interop@2c06b3c2 (#9633) [NativeAOT] improve build logic, part 1 (#9614) [build] Generate `WorkloadDependencies.json` (#9613) [monodroid] remove `monodroid_get_log_categories()` (#9625) [monodroid] remove `_monodroid_get_identity_hash_code` (#9622) Bump to dotnet/java-interop@f800ea52 (#9607) [XABT] Break BuildApk into individual tasks for each content type. (#9612) [Mono.Android] Bind Android API-Baklava DP1 (#9594) [Xamarin.Android.Build.Tasks] Extract `BuildArchive` from `BuildApk` (#9556) [NativeAOT] MSBuild-related logic to get projects to build (#9583) [build] remove remnants of `OpenTK-1.0.dll` (#9610) [build] remove `Xamarin.Android.CSharp.targets` (#9609) [build] runtime "flavors" part 2 (#9598) Bump com.android.tools.build:manifest-merger to 31.7.3 (#9600) ...

* dev/grendel/use-libc++: (25 commits) [CI] Break "Linux Tests" into 2 parallel jobs. (#9642) Fix `WorkloadDependencies.proj` build. (#9648) [CI] Set "WearOS Tests" parallelization to 2 agents. (#9639) [CI] Break "Package Tests" into 2 parallel jobs. (#9638) Bump to DevDiv/android-platform-support@3b4e16f1 (#9632) [NativeAOT] improve build logic, part 2 (#9631) Bump to dotnet/java-interop@2c06b3c2 (#9633) [NativeAOT] improve build logic, part 1 (#9614) [build] Generate `WorkloadDependencies.json` (#9613) [monodroid] remove `monodroid_get_log_categories()` (#9625) [monodroid] remove `_monodroid_get_identity_hash_code` (#9622) Bump to dotnet/java-interop@f800ea52 (#9607) [XABT] Break BuildApk into individual tasks for each content type. (#9612) [Mono.Android] Bind Android API-Baklava DP1 (#9594) [Xamarin.Android.Build.Tasks] Extract `BuildArchive` from `BuildApk` (#9556) [NativeAOT] MSBuild-related logic to get projects to build (#9583) [build] remove remnants of `OpenTK-1.0.dll` (#9610) [build] remove `Xamarin.Android.CSharp.targets` (#9609) [build] runtime "flavors" part 2 (#9598) Bump com.android.tools.build:manifest-merger to 31.7.3 (#9600) ...

jonpryor force-pushed the dev/jonp/jonp-release-json branch from e813874 to 6c1525c Compare December 12, 2024 17:07

jonpryor requested a review from Copilot December 12, 2024 17:18

Copilot AI reviewed Dec 12, 2024

View reviewed changes

jonpryor requested review from Redth and jonathanpeppers December 12, 2024 17:19

jonpryor force-pushed the dev/jonp/jonp-release-json branch from 6c1525c to 26e4019 Compare December 12, 2024 17:53

jonathanpeppers reviewed Dec 12, 2024

View reviewed changes

jonpryor mentioned this pull request Dec 13, 2024

[Mono.Android] Bind Android API-36 DP1. #9594

Merged

Emit preview platform only when we have a preview.

9504691

Provide NDK version.

Merge remote-tracking branch 'origin/main' into dev/jonp/jonp-release…

781d8c4

…-json

jonpryor force-pushed the dev/jonp/jonp-release-json branch from 32bd57e to 1510e87 Compare December 17, 2024 20:30

"recommendedVersion", not "requestedVersion".

58099a6

Redth approved these changes Dec 17, 2024

View reviewed changes

jonathanpeppers reviewed Dec 17, 2024

View reviewed changes

Address feedback

cdad1e9

jonpryor merged commit 0d4c1cb into main Dec 18, 2024
58 checks passed

jonpryor deleted the dev/jonp/jonp-release-json branch December 18, 2024 14:39

github-actions bot locked and limited conversation to collaborators Jan 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[build] Generate `workload-dependencies.json` #9613

[build] Generate `workload-dependencies.json` #9613

jonpryor commented Dec 12, 2024

jonathanpeppers Dec 12, 2024

jonpryor Dec 12, 2024

jonathanpeppers left a comment

jonpryor commented Dec 12, 2024

jonpryor commented Dec 13, 2024

jonpryor commented Dec 14, 2024

jonpryor commented Dec 16, 2024 •

edited

Loading

jonpryor commented Dec 17, 2024

azure-pipelines bot commented Dec 17, 2024

jonpryor commented Dec 17, 2024

azure-pipelines bot commented Dec 17, 2024

jonpryor commented Dec 17, 2024

Redth commented Dec 17, 2024

jonpryor commented Dec 17, 2024

azure-pipelines bot commented Dec 17, 2024

jonathanpeppers Dec 17, 2024 •

edited

Loading

jonpryor commented Dec 18, 2024

azure-pipelines bot commented Dec 18, 2024

[build] Generate workload-dependencies.json #9613

[build] Generate workload-dependencies.json #9613

Conversation

jonpryor commented Dec 12, 2024

Choose a reason for hiding this comment

jonathanpeppers Dec 12, 2024

Choose a reason for hiding this comment

jonpryor Dec 12, 2024

Choose a reason for hiding this comment

jonathanpeppers left a comment

Choose a reason for hiding this comment

jonpryor commented Dec 12, 2024

jonpryor commented Dec 13, 2024

jonpryor commented Dec 14, 2024

jonpryor commented Dec 16, 2024 • edited Loading

jonpryor commented Dec 17, 2024

azure-pipelines bot commented Dec 17, 2024

jonpryor commented Dec 17, 2024

azure-pipelines bot commented Dec 17, 2024

jonpryor commented Dec 17, 2024

Redth commented Dec 17, 2024

jonpryor commented Dec 17, 2024

azure-pipelines bot commented Dec 17, 2024

jonathanpeppers Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

jonpryor commented Dec 18, 2024

azure-pipelines bot commented Dec 18, 2024

[build] Generate `workload-dependencies.json` #9613

[build] Generate `workload-dependencies.json` #9613

jonpryor commented Dec 16, 2024 •

edited

Loading

jonathanpeppers Dec 17, 2024 •

edited

Loading