-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace .Sources package references with local code #4801
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….Sources with local code This code was copied here from aspnet/Extensions
…al copy of code This moves shared source from aspnet/Extensions into this repo
…ces with a local copy of code
FYI @ajaybhargavb @JunTaoLuo - this will conflict with the .csproj file changes you're making as a part of #4246 |
/AzurePipelines run AspNetCore-ci |
Success! 2 created and queued. |
dougbu
pushed a commit
to dougbu/razor-compiler
that referenced
this pull request
Nov 17, 2021
…e#4801) Replaces package references the following packages with local code: Microsoft.AspNetCore.Certificates.Generation.Sources Microsoft.Extensions.CopyOnWriteDictionary.Sources Microsoft.Extensions.ClosedGenericMatcher.Sources Microsoft.Extensions.ObjectMethodExecutor.Sources Microsoft.Extensions.PropertyActivator.Sources Microsoft.Extensions.PropertyHelper.Sources Microsoft.Extensions.RazorViews.Sources Microsoft.Extensions.SecurityHelper.Sources Microsoft.Extensions.StackTrace.Sources Microsoft.Extensions.WebEncoders.Sources Commit migrated from dotnet/aspnetcore@13ae0057fbb1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies code from aspnet/Extensions into this repo. This code is not actually used in aspnet/Extensions, so it seems more appropriate to put the shared sources here.
Having the code locally makes it easier to