-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Update Live with current Master #4899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* .NET standard TOC: combined parallel programming topics * Feedback
* Remove legacy Type Provider content from ToC and update index * Delete and redirect * Feedback
.openpublishing.redirection.json
Outdated
| }, | ||
| { | ||
| "source_path": "docs/fsharp/tutorials/type-providers/generating-fsharp-types-from-edmx.md", | ||
| "redirect_url": "docs/fsharp/tutorials/type-providers/index" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cartermp redirect_url are not correct: docs substring should be replaced with /dotnet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @pkulikov. I'll make a new PR to fix that.
* Removed duplicate C# classes topic * Added link to Inheritance topic * Bring back Classes to the C# Concepts TOC * Moved snippet to the dedicated folder * Updated path to the snippet * One more snippet link update * Addressed feedback
|
@mairaw my commit breaks the build here, but not when it was still a PR. Is it because samples master should be merged to live as well? I'm sorry for such a 'breaking' PR. I'll be more careful in future with changes that touch both samples and and conceptual docs. Also, please share recommended workflow/guidelines for such PRs when those are established. |
|
Yes, I just did that @pkulikov. We're still learning the new workflow. 😄 |
Update Live with current Master