Skip to content

Conversation

@rpetrusha
Copy link
Contributor

Update Live with current Master

mairaw and others added 4 commits April 6, 2018 09:44
* .NET standard TOC: combined parallel programming topics

* Feedback
* Remove legacy Type Provider content from ToC and update index

* Delete and redirect

* Feedback
@cartermp cartermp self-requested a review as a code owner April 8, 2018 19:52
},
{
"source_path": "docs/fsharp/tutorials/type-providers/generating-fsharp-types-from-edmx.md",
"redirect_url": "docs/fsharp/tutorials/type-providers/index"
Copy link
Contributor

@pkulikov pkulikov Apr 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cartermp redirect_url are not correct: docs substring should be replaced with /dotnet

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @pkulikov. I'll make a new PR to fix that.

* Removed duplicate C# classes topic

* Added link to Inheritance topic

* Bring back Classes to the C# Concepts TOC

* Moved snippet to the dedicated folder

* Updated path to the snippet

* One more snippet link update

* Addressed feedback
@mairaw mairaw requested a review from BillWagner as a code owner April 9, 2018 16:31
@mairaw mairaw closed this Apr 9, 2018
@mairaw mairaw reopened this Apr 9, 2018
@pkulikov
Copy link
Contributor

pkulikov commented Apr 9, 2018

@mairaw my commit breaks the build here, but not when it was still a PR. Is it because samples master should be merged to live as well?

I'm sorry for such a 'breaking' PR. I'll be more careful in future with changes that touch both samples and and conceptual docs. Also, please share recommended workflow/guidelines for such PRs when those are established.

@mairaw
Copy link
Contributor

mairaw commented Apr 9, 2018

Yes, I just did that @pkulikov. We're still learning the new workflow. 😄

@mairaw mairaw merged commit dc3c8a2 into live Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants