Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: add translation for string.IndexOf(string, int) #25396 #25655

Closed
wants to merge 440 commits into from
Closed

Query: add translation for string.IndexOf(string, int) #25396 #25655

wants to merge 440 commits into from

Conversation

yosoyhabacuc
Copy link
Contributor 

    Summary of the changes:
    - Added support to _indexOfMethodInfoWithStartingPosition in SqlServerStringMethodTranslator
    - Created a TranslateIndexOf method inside the same class to be used by both _indexOfMethodInfo and _indexOfMethodInfoWithStartingPosition
    - Created test for Indexof_with_one_arg, to check the existing implementation still works
    - Modified test method Indexof_with_starting_position to check the change

Fixes issue #25396

@dnfadmin
Copy link

dnfadmin commented Aug 23, 2021 •
edited
Loading

CLA assistant check
All CLA requirements met.

@ajcvickers
Copy link
Member

Note: EF Core 6.0 is closed for new features; this will need retargeting to main.

Assigning @smitpatel

smitpatel
smitpatel requested changes Sep 2, 2021
View reviewed changes
Copy link
Member

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase on main branch

@smitpatel smitpatel changed the base branch from release/6.0 to main September 2, 2021 22:33
smitpatel and others added 16 commits September 17, 2021 23:34
@smitpatel
ModelBuilding: Add regression test for dotnet#18149 (dotnet#26096)
2be234d 
Resolves dotnet#18149
@ajcvickers
Adding grouping tests from EF6 (dotnet#26069)
ef68226 
* Adding grouping tests from EF6

As a crude measure of the gap between EF Core and EF6.

Currently:
- 12 tests pass
- 2 tests fail with "Translation of 'Select' which contains grouping parameter without composition is not supported."
- 17 tests fail with general "Could not be translated."
- 8 tests fail with different results

* Updated

* Updates based on feedback.
@ajcvickers
Merge branch 'release/6.0-rc2' into release/6.0
901bfb4
@ajcvickers
Merge branch 'release/6.0'
c87f09c
@roji
[6.0-rc2] Fully support int identity seed (dotnet#26066)
2453c3b 
Fixes dotnet#26062
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
a134dc6 
…0918.3 (dotnet#26101)

[release/6.0-rc2] Update dependencies from dotnet/runtime
@ErikEJ
Reflect reality (dotnet#26099)
7d56b56 
Co-authored-by: Erik Ejlskov Jensen <eej@venzo.com>
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
173f229 
…916.4 (dotnet#26108)

[main] Update dependencies from dotnet/arcade
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
29230f2 
…0920.1 (dotnet#26107)

[main] Update dependencies from dotnet/runtime
@AndriySvyryd
When sorting update commands add Deleted + Inserted number of edges i…
c6a9f1c 
…nstead of Deleted * Inserted

Don't allocate a collection for edges if there's only one edge between given two vertices
Reuse the Multigraph instance
Change the benchmark to reuse the context instance to simulate pooling behavior
@AndriySvyryd
Always store join table schema in the snapshot.
ccde2d5 
Fixes dotnet#23937
@AndriySvyryd
Add a check to ShouldUseSameServiceProvider even when the extension h…
501c60a 
…as no options

Fixes dotnet#26109
@bricelam
Tools: Check for unsupported OS-specific TFMs
7ffacdb 
Fixes dotnet#25938
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
b3dd333 
…0920.10 (dotnet#26113)

[release/6.0-rc2] Update dependencies from dotnet/runtime
@dotnet-bot
[internal/release/3.1] Update dependencies from dnceng/internal/dotne…
0e26b07 
…t-extensions

- Coherency Updates:
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.19 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.19 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.19 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Internal: from 3.1.19-servicing.21416.14 to 3.1.20-servicing.21470.10 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.19 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.19 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.19 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.19 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.19 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.19 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.19 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.19 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.19 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.19 to 3.1.20 (parent: Microsoft.Extensions.Logging)
@dotnet-bot
[internal/release/3.1] Update dependencies from dnceng/internal/dotne…
254dee8 
…t-extensions

- Coherency Updates:
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.20 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.20 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.20 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Internal: from 3.1.20-servicing.21470.10 to 3.1.20-servicing.21470.22 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.20 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.20 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.20 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.20 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.20 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.20 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.20 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.20 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.20 to 3.1.20 (parent: Microsoft.Extensions.Logging)
  - Microsoft.NETCore.App.Runtime.win-x64: from 3.1.20 to 3.1.20 (parent: Microsoft.Extensions.Logging)
dougbu and others added 27 commits November 8, 2021 18:39
@dougbu
Update to latest SDK and runtimes (dotnet#26583)
8328e0f
@ajcvickers
Evolve null-checking approach in EFCore (dotnet#26557)
53fbd04
@vseanreesermsft
Merge commit '8d3ca1a23a881f6ff435c797a43b1d893328eee9' into internal…
b4f4d83 
…-merge-5.0-2021-11-09-0928
@vseanreesermsft
Merge commit 'c3baaac7ee60c016333566a5097789fe183afe69' into internal…
2a5705c 
…-merge-3.1-2021-11-09-0932
@dougbu
Merge pull request dotnet#26595 from vseanreesermsft/internal-merge-5…
cb3fb89 
….0-2021-11-09-0928

Merging internal commits for release/5.0
@dougbu
Merge pull request dotnet#26596 from vseanreesermsft/internal-merge-3…
cd01454 
….1-2021-11-09-0932

Merging internal commits for release/3.1
@smitpatel
RevEng: Consider skip navigation names when generating identifier for…
62dc53f 
… members of class (dotnet#26531)

Resolves dotnet#26496

We had mechanism to generate unique identifiers to assign to skip navigations but the code to find existing identifiers lacked skip navigations. So skip navigation names were not unique-fied throwing error when trying to add skip navigation with same name
Merge pull request dotnet#26600 from dotnet-maestro-bot/merge/release…
c426423 
…/6.0-to-main

[automated] Merge branch 'release/6.0' => 'main'
@AndriySvyryd
Avoid NRE in ForeignKeyAttributeConvention
32ca7e7 
Fixes dotnet#26436
@AndriySvyryd
Allow non-nullable value comparer to be applied on nullable properties
539aee7 
Fixes dotnet#26429
@AndriySvyryd
Register design-time LoggerFactory as Scoped
e0348cf 
Fixes dotnet#26384
@smitpatel
Query: Copy client projections when updating SelectExpression (dotnet…
0c74522 
…#26431)

Resolves dotnet#26428
@BrennanConroy
Update SDK (dotnet#26577)
f703b6b
@dougbu
[release/6.0] Update to latest SDK and runtimes (dotnet#26584)
bf3c95b
@ajcvickers
Merge branch 'release/3.1' into release/5.0
7c32c75
@ajcvickers
Merge branch 'release/5.0' into release/6.0
fdd0012
@ajcvickers
Merge branch 'release/6.0'
846070d
@bricelam
[6.0.1] Microsoft.Data.Sqlite: Clean up on application exit (dotnet#2…
6ae128a 
…6529)

* Microsoft.Data.Sqlite: Clean up on application exit

Fixes dotnet#26422

* fixup! Microsoft.Data.Sqlite: Clean up on application exit

Quirk it
Merge pull request dotnet#26609 from dotnet-maestro-bot/merge/release…
6286284 
…/6.0-to-main

[automated] Merge branch 'release/6.0' => 'main'
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20211…
0f848a3 
…108.5 (dotnet#26608)

[release/6.0] Update dependencies from dotnet/arcade
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20211…
ca6c54b 
…110.2 (dotnet#26613)

[release/6.0] Update dependencies from dotnet/arcade
@smitpatel
Move to OSX 11.0 for helix queues (dotnet#26614)
6cf7980
@smitpatel
Move to OSX 11.0 for helix queues (dotnet#26615)
cb6d523 
The build was earlier removed due another issue, re-adding and moving
@smitpatel
Merge branch 'release/5.0'
463700c
@smitpatel
Merge branch 'release/6.0'
3f9a137
@smitpatel
Merge branch '25396_string_IndexOf(string_int)' of https://github.com…
a6efd11 
…/yosoyhabacuc/efcore into smit/indexof
@smitpatel
PR cleanup
75ec146
@smitpatel
Copy link
Member

Since original PR wasn't rebase on latest main, closing in favor of #26623

@smitpatel smitpatel closed this Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

@dougbu dougbu Awaiting requested review from dougbu

Assignees

@smitpatel smitpatel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.