Merge remote-tracking branch 'dotnet/master' into DefaultInterfaceImplementation #18687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactoring tests to not use extension methods
…source. It may change semantics.
…onversion Don't offer 'use throw expression' when there is an explicit cast in source. It may change semantics.
…ameter Overarching PR for features related to generating code starting from a parameter.
Add metadata-tools feed
Simple script to automate the process of shipping our API files
Break types into their own files.
….2.x-nayewah Merge 15.1.x to 15.2.x
Port extract method tests
Port reference highlighting tests
Move IOperation API entries back to PublicAPI.Unshipped.txt
Enable use of Sqlite in the OOP process and move our features over to using them.
…rtable This change retargets the CSharpSymbolTest project from .NET 4.6 (which runs only on the desktop CLR) to netstandard 1.3 (which runs on both the Desktop 4.6 framework and CoreCLR). These changes are necessary to enable more test coverage on CoreCLR, which will be especially impactful when we want to test language features which are only targeted to run on CoreCLR. There are a lot of file changes in this PR but the most significant new code is in the TestExecutionContext, which is a new CoreCLR AppContext-based mechanism for running in-memory assemblies. This class is meant to have similar functionality to the existing desktop RuntimeEnvironment, but because AppDomains and AppContexts are incompatible, there are some substantial differences. Most notably, the TestExecutionContext views all assemblies next to the CoreCLR test runner (the "app base") as being shared among all test execution runs, including static variables. In contrast, the AppDomain runner only shares assemblies which are already loaded. The second notable change is a rename from CreateCompilationWithMscorlib to CreateStandardCompilation. Despite the name, the most common usage of CreateCompilationWithMscorlib was just meant to create a simple compilation. The .NET Framework mscorlib was provided as a reference because it provided most of the common types our tests need to compile against, but it wasn't particularly important which types it supplied, beyond a minimum set. Unfortunately, compiling against the .NET Framework mscorlib can introduce severe incompatibilities when trying to run the application on CoreCLR (which uses System.Runtime as its basis). This PR instead provides a new set of references (NETStandard.Library 2.0, the "standard" references) to try to provide as much compatibility as possible while also providing portability. Thus, the CreateCompilationWithMscorlib methods were renamed to CreateStandardCompilation to make it clear that no specific set of references is guaranteed when compiling against it. If that is desired, it's recommended to use the existing CreateCompilation methods to construct an explicit set of references to compile against (with all the implications that come from that).
…-to-master-20170412-070006
…Completion Provide completion that offers the explicit-interface-type when typing new members.
…r-20170412-070006 Merge dev15.2.x to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.