Merge master to features/readonly-members #33445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two classes were deriving and using only the [UseExportProvider] attribute; the third (CommandLineProjectWorkspaceTests) was only using it to assert that DocumentInfos created by parsing command lines will read file contents if asked. The last can be fixed up in a more direct way.
Nothing other than one suspicious test in SolutionTests.cs used any of this, so it's easier to move it all and keep things isolated.
Broken test reported at #33356
We had some code in the VS layer that was trying to work around the fact that we might be MEF created on a background thread, when were didn't know what the UI thread was. It tried to assert that the first actual workspace mutation would happen on the UI thread, and so it was safe to create the queue at that point. This is silly now for two reasons: 1. We're using the IThreadingContext which knows what the main thread is directly and without any ceremony 2. We now do indeed do workspace mutations on other threads. It's still the case that the first mutation is on the UI thread today but that's a limitation we are actively wanting to excise.
… a case expression or a constant pattern. Fixes #33054 Fixes #33208 - Incidentally also correct and test the precedence of the switch expression See https://github.com/dotnet/csharplang/blob/master/proposals/patterns.md#switch-expression for the spec. - Fix terminology to match the spec - "conditional expression" rather than "ternary expression".
Fix compiler crash and remove spurious hidden sequence points for switch expression
…e-around-workspace-eventing Delete unnecessary code around Workspace eventing
Update formatter
Merge dev16.0 to master
…duplicate-project-references Ensure that MSBuildWorkspace deals with duplicate ProjectReferences
Add long paths support
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into features/readonly-members.
git fetch --all git checkout merges/master-to-features/readonly-members git reset --hard upstream/features/readonly-members git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-features/readonly-members --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.