Merge master into features/function-pointers #40832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the shared-pool helpers
Unify the pattern used to run a feature in OOP
…217.1 (dotnet#40474) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19617.1
…tion Add feature to simplify interpolation expressions when possible
…helper-methods Remove some nullable helper methods
… in the IDE Diagnostic service Disabled by default analyzers, which are enabled via .editorconfig are not executing in the IDE diagnostic service. This is due to us skipping live analysis for analyzers disabled by default OR disabled via compilation options as a performance optimization. However, this check is no longer correct as analyzers can be enabled/disabled for individual documents through .editorconfig files. So we no longer perform this check and pessimistically assume analyzer is not suppressed and let the core analyzer driver in the compiler layer handle skipping redundant analysis callbacks.
Remove unnecessary allocations in 'keyword highlighting'
This changes the implementation of `DiagnosticInfo` to use an empty array in all cases for arguments vs. a mix of empty arrays and `null` for the empty case. This allows us to ensure the `Diagnostic.Arguments` is always a non-null value. This makes adopting nullability higher in the stack significantly simpler as there are assumptions this is non-null in places.
Annotated SyntaxList
remove preview 1 publishing
* Adds nullability, removes dead code. * Clean up RemoteHostClient exception and lifetime handling * Nullables * JsonRpcEx disposal cleanup * Nullables * Refactor abstract JsonRpcEx to sealed RemoteEndPoint * Use RemoteEndPoint for ServiceHub services * Move ctor * Use RemoteEndPoint in ServiceHubRemoteHostClient * Minor cleanup of log messages * JsonRpcTargetOptions * Use RemoteEndPoint in CodeLens, tests * Inline Extensions.InvokeAsync methods into RemoteEndPoint * Remove unnecessary invoke methods * Unify exception handling * Allow null arguments in remote invocation * Simplify ClientDirectStream * Fold ClientDirectStream and ServerDirectStream into RemoteEntryPoint * Feedback * Fix test
Revert "Merge pull request dotnet#40410 from sharwell/use-index"
Move run code actions back to liveshare layer so that we can switch t…
Update configs for preview 2 snap
Unskip and fix integration test
Annotate implementations of IAliasSymbol
…t_use_index Revert "Merge pull request dotnet#40765 from dibarbet/revert_use_index"
Ensure that we process diagnostics ordered by their span and then diagnostic ID. This fixes a race condition seen in intermittent failures for ConfigureCodeStyleOptionValueAndSeverity where the order of configuration/suppression fixes is non-deterministic
* Improve nullable analysis of local functions This design tries to meld better analysis of nullable reference types in local functions with performance. To keep the common case one pass, local functions are analyzed using the starting state that is an intersection of all the states before its usages (calls, delegate conversions, etc), but the results of variables made nullable or non-nullable inside the local function do not propagate to the callers. * Respond to PR comments
Fix race condition in CodeFixService
* dotnet/master: (592 commits) Improve nullable analysis of local functions (dotnet#40422) Fix race condition in CodeFixService Annotate CSharpCompilation (dotnet#40752) Revert "Merge pull request dotnet#40765 from dibarbet/revert_use_index" More feedback address feedback More refactoring and hardening of remote calls (dotnet#40395) Update PublishData.json Unskip and fix integration test Update configs for preview 2 snap Improve error message for CS0191 (dotnet#40748) Revert "Merge pull request dotnet#40410 from sharwell/use-index" PR feedback Report erroneous implicit conversions in a switch expression (dotnet#40678) Ignore dynamic vs object, etc in pattern-matching machinery. (dotnet#40677) Handle dependent slots in pattern-matching null tests. (dotnet#39625) Pass non-null arguments to avoid nullability warning Update dependencies from https://github.com/dotnet/arcade build 20200104.1 (dotnet#40749) [master] Update dependencies from dotnet/arcade (dotnet#40718) Expose display option to add ! on non-nullable types (dotnet#40519) ...
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.