Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge main to features/list-patterns #51864

Merged
81 commits merged into from
Mar 14, 2021
Merged

Merge main to features/list-patterns #51864

81 commits merged into from
Mar 14, 2021

Commits on Mar 1, 2021

  1. Use Environment.CurrentManagedThreadId instead of Thread.CurrentThrea… 

    …d.ManagedThreadId

See dotnet/runtime#43257
    @sharwell
    sharwell committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    0229e41 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. Make var patterns bindable

    @Youssef1313
    Youssef1313 committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    bcd6eee View commit details
    Browse the repository at this point in the history

  2. Update UseExpressionBodyForPropertiesAnalyzerTests to the new test li… 

    …brary
    @Youssef1313
    Youssef1313 committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    d9a7fd4 View commit details
    Browse the repository at this point in the history

  3. Update UseExpressionBodyForOperatorsAnalyzerTests to the new test lib… 

    …rary
    @Youssef1313
    Youssef1313 committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    0fe0438 View commit details
    Browse the repository at this point in the history

  4. Update UseExpressionBodyForMethodsAnalyzerTests to the new test library

    @Youssef1313
    Youssef1313 committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    e4c615f View commit details
    Browse the repository at this point in the history

  5. Fix merge conflicts

    @allisonchou
    allisonchou committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    f365e3f View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. Add TestVarPatternOnVariableItself

    @Youssef1313
    Youssef1313 committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    b0168a8 View commit details
    Browse the repository at this point in the history

  2. Update UseExpressionBodyForLocalFunctionsAnalyzerTests to the new tes… 

    …t library
    @Youssef1313
    Youssef1313 committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    cb37d12 View commit details
    Browse the repository at this point in the history

  3. Update UseExpressionBodyForIndexersAnalyzerTests to the new test library

    @Youssef1313
    Youssef1313 committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    119b075 View commit details
    Browse the repository at this point in the history

  4. Update UseExpressionBodyForConversionOperatorsAnalyzerTests to the ne… 

    …w test library
    @Youssef1313
    Youssef1313 committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    7fafaf7 View commit details
    Browse the repository at this point in the history

  5. Update UseExpressionBodyForConstructorsAnalyzerTests to the new test … 

    …library
    @Youssef1313
    Youssef1313 committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    72f8aab View commit details
    Browse the repository at this point in the history

  6. Update UseExpressionBodyForAccessorsTests to the new test library

    @Youssef1313
    Youssef1313 committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    da746e0 View commit details
    Browse the repository at this point in the history

  7. Address feedback: Use ExpressionBodyPreference

    @Youssef1313
    Youssef1313 committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    5137c5d View commit details
    Browse the repository at this point in the history

  8. Remove suppression: RS0033:Importing constructor should be obsolete

    @Youssef1313
    Youssef1313 committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    bbe74b5 View commit details
    Browse the repository at this point in the history

  9. Fix failure on Spanish CI

    @Youssef1313
    Youssef1313 authored Mar 4, 2021
    Configuration menu
    Copy the full SHA
    68212fa View commit details
    Browse the repository at this point in the history

  10. Fix UseExpressionBodyForPropertiesAnalyzerTests

    @Youssef1313
    Youssef1313 committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    d9af8d4 View commit details
    Browse the repository at this point in the history

  11. Fix UseExpressionBodyForOperatorsAnalyzerTests

    @Youssef1313
    Youssef1313 committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    a394069 View commit details
    Browse the repository at this point in the history

  12. Fix UseExpressionBodyForMethodsAnalyzerTests

    @Youssef1313
    Youssef1313 committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    5a6391b View commit details
    Browse the repository at this point in the history

  13. Fix UseExpressionBodyForLocalFunctionsAnalyzerTests

    @Youssef1313
    Youssef1313 committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    0a24e10 View commit details
    Browse the repository at this point in the history

  14. Fix UseExpressionBodyForIndexersAnalyzerTests

    @Youssef1313
    Youssef1313 committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    9dd8fba View commit details
    Browse the repository at this point in the history

  15. Fix UseExpressionBodyForConversionOperatorsAnalyzerTests

    @Youssef1313
    Youssef1313 committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    c722ff8 View commit details
    Browse the repository at this point in the history

  16. Fix UseExpressionBodyForConstructorsAnalyzerTests

    @Youssef1313
    Youssef1313 committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    4695116 View commit details
    Browse the repository at this point in the history

  17. Revert statement that is breaking sqlite on OSX.

    @CyrusNajmabadi
    CyrusNajmabadi committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    5e01514 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. Use frozen-partial semantics when producing semantic classifications

    @CyrusNajmabadi
    CyrusNajmabadi committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    7f2387f View commit details
    Browse the repository at this point in the history

  2. OS specific check

    @CyrusNajmabadi
    CyrusNajmabadi committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    ab43087 View commit details
    Browse the repository at this point in the history

  3. Revert

    @CyrusNajmabadi
    CyrusNajmabadi committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    e33e009 View commit details
    Browse the repository at this point in the history

  4. Fix UseExpressionBodyForAccessorsTests

    @Youssef1313
    Youssef1313 committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    9894b96 View commit details
    Browse the repository at this point in the history

  5. Work

    @CyrusNajmabadi
    CyrusNajmabadi committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    45d26c5 View commit details
    Browse the repository at this point in the history

  6. Reclassify once semantics are fully available

    @CyrusNajmabadi
    CyrusNajmabadi committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    3b8866c View commit details
    Browse the repository at this point in the history

  7. Simplify

    @CyrusNajmabadi
    CyrusNajmabadi committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    3938c89 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2021

  1. Disable text sync for C# LSP server due to LSP client text sync issues.

    @dibarbet
    dibarbet committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    f846b17 View commit details
    Browse the repository at this point in the history

  2. Add extra logging for text sync requests in case razor encounters tex… 

    …t sync issues.
    @dibarbet
    dibarbet committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    6bc956f View commit details
    Browse the repository at this point in the history

  3. Fix merge

    David Wengier committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    f534f75 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2021

  1. Refactor tests that cause warnings in CI (#51730) 

    * Refactor tests that cause warnings in CI

* Address feedback from @cston
    @Youssef1313
    Youssef1313 authored Mar 7, 2021
    Configuration menu
    Copy the full SHA
    b3e8749 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. Merge pull request #51559 from sharwell/current-thread 

    Use Environment.CurrentManagedThreadId
    @sharwell
    sharwell authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    eddde7c View commit details
    Browse the repository at this point in the history

  2. Merge pull request #51620 from Youssef1313/var-bindable 

    Make var patterns bindable
    @CyrusNajmabadi
    CyrusNajmabadi authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    4d32cbb View commit details
    Browse the repository at this point in the history

  3. Merge pull request #51682 from CyrusNajmabadi/revertSql 

    Revert statement that is breaking sqlite on OSX.
    @CyrusNajmabadi
    CyrusNajmabadi authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    807aded View commit details
    Browse the repository at this point in the history

  4. Merge pull request #51704 from CyrusNajmabadi/frozenClassification 

    Use frozen-partial semantics when producing semantic classifications
    msftbot[bot] authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    dc800a1 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #51612 from dotnet/merges/release/dev16.9-to-relea… 

    …se/dev16.10

Merge release/dev16.9 to release/dev16.10
    msftbot[bot] authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    97a1748 View commit details
    Browse the repository at this point in the history

  6. Extract Rebuild library (#51709)

    @RikkiGibson
    RikkiGibson authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    f7f683a View commit details
    Browse the repository at this point in the history

  7. [main] Update dependencies from dotnet/arcade (#51659) 

    [main] Update dependencies from dotnet/arcade


 - Initialize RuntimeSourceFeed variables in tools.sh since Roslyn and others don't use /eng/common/build.sh
    @dotnet-maestro
    dotnet-maestro[bot] authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    a3afbdb View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. Document breaking change for #46044 (#51070)

    @cston
    cston authored Mar 9, 2021
    Configuration menu
    Copy the full SHA
    9e43067 View commit details
    Browse the repository at this point in the history

  2. Move todo comments analyzer to Editor Features (#51643)

    @davidwengier
    davidwengier authored Mar 9, 2021
    Configuration menu
    Copy the full SHA
    7cee01b View commit details
    Browse the repository at this point in the history

  3. Merge pull request #51623 from Youssef1313/update-tests 

    Update 'UseExpressionBody' tests to the new test library
    @CyrusNajmabadi
    CyrusNajmabadi authored Mar 9, 2021
    Configuration menu
    Copy the full SHA
    b0f9a5a View commit details
    Browse the repository at this point in the history

  4. Update dependencies from https://github.com/dotnet/roslyn build 20210… 

    …306.4 (#51736)

[main] Update dependencies from dotnet/roslyn
    @dotnet-maestro
    dotnet-maestro[bot] authored Mar 9, 2021
    Configuration menu
    Copy the full SHA
    6bbcb6d View commit details
    Browse the repository at this point in the history

  5. Port simplification of SizeToFitAsync to EditorFeatures.Cocoa 

    See #41655
    @sharwell
    sharwell committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    8af7125 View commit details
    Browse the repository at this point in the history

  6. Update dependencies from https://github.com/dotnet/arcade build 20210… 

    …308.9 (#51758)

[main] Update dependencies from dotnet/arcade
    @dotnet-maestro
    dotnet-maestro[bot] authored Mar 9, 2021
    Configuration menu
    Copy the full SHA
    beffac2 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/main' into merges/release/dev16.… 

    …10-to-main
    @JoeRobich
    JoeRobich committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    054a985 View commit details
    Browse the repository at this point in the history

  8. Merge pull request #51748 from dotnet/merges/release/dev16.10-to-main 

    Merge release/dev16.10 to main
    @JoeRobich
    JoeRobich authored Mar 9, 2021
    Configuration menu
    Copy the full SHA
    7dbb61b View commit details
    Browse the repository at this point in the history

  9. Correctly handle lambda expressions in the nullable walker when they … 

    …are passed as arguments to a bad expression (#51644)
    @333fred
    333fred authored Mar 9, 2021
    Configuration menu
    Copy the full SHA
    3c450a1 View commit details
    Browse the repository at this point in the history

  10. Merge pull request #51759 from sharwell/port-tasks-change 

    Share IWpfDifferenceViewerExtensions with EditorFeatures.Cocoa
    @sharwell
    sharwell authored Mar 9, 2021
    Configuration menu
    Copy the full SHA
    1f56b5f View commit details
    Browse the repository at this point in the history

  11. Document breaking change for #50755 (#51754)

    @cston
    cston authored Mar 9, 2021
    Configuration menu
    Copy the full SHA
    7e8b9ee View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. Suppress nullable conversion warnings in default arguments (#51631)

    @RikkiGibson
    RikkiGibson authored Mar 10, 2021
    Configuration menu
    Copy the full SHA
    0902d19 View commit details
    Browse the repository at this point in the history

  2. add feature flag to remotely control textsync in 16.9

    @dibarbet
    dibarbet committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    91ce75d View commit details
    Browse the repository at this point in the history

  3. Merge pull request #51708 from dibarbet/169_disable_text_sync 

    [LSP] Disable text sync for C# in 16.9
    @dibarbet
    dibarbet authored Mar 10, 2021
    Configuration menu
    Copy the full SHA
    59eedc3 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Merge branch 'release/dev16.10' into merges/release/dev16.9-vs-deps-t… 

    …o-release/dev16.10
    @JoeRobich
    JoeRobich authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    7052692 View commit details
    Browse the repository at this point in the history

  2. Move Rebuild to have a deny list approach (#51694) 

    * Move Rebuild to have a deny list approach

Rather than listing all of the assemblies that we support rebuilding
this moves us to listing the ones that don't support it. That makes it
much more explicit what our "work remaining" is as well as automatically
adding in new assemblies added to the project.
    @jaredpar
    jaredpar authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    158b7e5 View commit details
    Browse the repository at this point in the history

  3. Update dependencies from https://github.com/dotnet/arcade build 20210… 

    …311.1 (#51798)

[main] Update dependencies from dotnet/arcade
    @dotnet-maestro
    dotnet-maestro[bot] authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    a843e80 View commit details
    Browse the repository at this point in the history

  4. Use ImmutableSegmentedDictionary in the analyzer driver

    @sharwell
    sharwell committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    1d21812 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #51795 from dotnet/merges/release/dev16.9-vs-deps-… 

    …to-release/dev16.10

Merge release/dev16.9-vs-deps to release/dev16.10
    msftbot[bot] authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    f5236e7 View commit details
    Browse the repository at this point in the history

  6. Simplify code.

    @CyrusNajmabadi
    CyrusNajmabadi committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    3c7c673 View commit details
    Browse the repository at this point in the history

  7. NRT and switch expression

    @CyrusNajmabadi
    CyrusNajmabadi committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    08b3c34 View commit details
    Browse the repository at this point in the history

  8. Intermediate

    @CyrusNajmabadi
    CyrusNajmabadi committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    1ba6c4c View commit details
    Browse the repository at this point in the history

  9. Simplify

    @CyrusNajmabadi
    CyrusNajmabadi committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    72a65e0 View commit details
    Browse the repository at this point in the history

  10. Fix

    @CyrusNajmabadi
    CyrusNajmabadi committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    93cba16 View commit details
    Browse the repository at this point in the history

  11. Fix

    @CyrusNajmabadi
    CyrusNajmabadi committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    6fb1338 View commit details
    Browse the repository at this point in the history

  12. Fix

    @CyrusNajmabadi
    CyrusNajmabadi committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    6e98175 View commit details
    Browse the repository at this point in the history

  13. Pass cancellation token to Dequeue method, and rewrite comment (#51794)

    @davidwengier
    davidwengier authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    27913e0 View commit details
    Browse the repository at this point in the history

  14. Simplify more

    @CyrusNajmabadi
    CyrusNajmabadi committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    2d3fd7d View commit details
    Browse the repository at this point in the history

  15. Fix test

    @CyrusNajmabadi
    CyrusNajmabadi committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    1e722bd View commit details
    Browse the repository at this point in the history

  16. Merge remote-tracking branch 'upstream/release/dev16.10' into merges/… 

    …release/dev16.10-to-main
    @dibarbet
    dibarbet committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    2f14568 View commit details
    Browse the repository at this point in the history

  17. Cancel outstanding work on tagger disconnect

    @sharwell
    sharwell committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    625a02c View commit details
    Browse the repository at this point in the history

  18. Use RTM version of framework ref assemblies 

    This changes our code to use the RTM version of the framework reference
assemblies rather than preview.

The RTM version though forces a reference to Microsoft.VisualBasic.dll
when building VB projects. That caused a compilation error in part of
our code because of the following pattern

```vb
For Each str in strings
```

In VB the identifier in the `For Each` is not necessarily a new
declaration but can also refer to existing identifiers. Hence this name
must go through standard name lookup.

Once the reference to Microsoft.VisualBasic.dll is added the
`Microsoft.VisualBasic.Conversions` module becomes available and the
method `Str` in that module is now a valid top level name. This causes
the above code to stop compiling. Fix is to use a non-conflicting
identifier.

closes #517711
    @jaredpar
    jaredpar committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    7550ac6 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. Don't use docker for sourcebuild leg (#51815)

    @333fred
    333fred authored Mar 12, 2021
    Configuration menu
    Copy the full SHA
    38be2dc View commit details
    Browse the repository at this point in the history

  2. Add Rebuild.UnitTests (#51778)

    @RikkiGibson
    RikkiGibson authored Mar 12, 2021
    Configuration menu
    Copy the full SHA
    062355a View commit details
    Browse the repository at this point in the history

  3. Merge pull request #51816 from sharwell/cancel-work 

    Cancel outstanding work on tagger disconnect
    @sharwell
    sharwell authored Mar 12, 2021
    Configuration menu
    Copy the full SHA
    edccfb4 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #51806 from dotnet/merges/release/dev16.10-to-main 

    Merge release/dev16.10 to main
    @allisonchou
    allisonchou authored Mar 12, 2021
    Configuration menu
    Copy the full SHA
    24de972 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #51805 from sharwell/faster-driver 

    Use ImmutableSegmentedDictionary in the analyzer driver
    @sharwell
    sharwell authored Mar 12, 2021
    Configuration menu
    Copy the full SHA
    7e99a9a View commit details
    Browse the repository at this point in the history

  6. Add component debugger support to target files (#51449) 

    * Add component debugger support to target files
    @chsienki
    chsienki authored Mar 12, 2021
    Configuration menu
    Copy the full SHA
    d23cc29 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #51811 from CyrusNajmabadi/simplifyCompletion 

    Simplify portions of symbol completion
    msftbot[bot] authored Mar 12, 2021
    Configuration menu
    Copy the full SHA
    8da536d View commit details
    Browse the repository at this point in the history

  8. Merge pull request #51819 from jaredpar/name 

    Use RTM version of framework ref assemblies
    msftbot[bot] authored Mar 12, 2021
    Configuration menu
    Copy the full SHA
    ecdb876 View commit details
    Browse the repository at this point in the history