Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merges/main to features/file scoped namespaces #54687

Conversation

RikkiGibson
Copy link
Contributor

No description provided.

akhera99 and others added 30 commits June 11, 2021 10:26
We fixed the drop path a while ago in other branches but forgot about 16.10, and it's causing OptProf test to break after we inserted a new build from dnceng pipeline recently. Fixed it in this branch too just in case

PR in VS that's fixing the drop issue:
https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/335189
…ase/dev16.11

Merge release/dev16.10 to release/dev16.11
Set prerelease version label for PR val builds
Prevent race in LSP pull diagnostics handling that causes stale diagnostics that do not update.
…ase/dev17.0

Merge release/dev16.11 to release/dev17.0
…ase/dev17.0

Merge release/dev16.11 to release/dev17.0
…_reporting

Add ErrorReporting for CodeAction Apply
dibarbet and others added 17 commits July 6, 2021 17:28
Reduce telemetry output from find document in workspace
Handle FAR for global suppressions in a consistent fashion
Ensure we don't try and build an empty table when modifying entries
… into merges/main-to-features/FileScopedNamespaces
@@ -230,6 +230,7 @@ internal enum MessageID
IDS_AsyncMethodBuilderOverride = MessageBase + 12805,
IDS_FeatureImplicitImplementationOfNonPublicMemebers = MessageBase + 12806,
IDS_FeatureLineSpanDirective = MessageBase + 12807,
IDS_FeatureFileScopedNamespace = MessageBase + 12808,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May as well make this 12809. You're going to conflict with me no matter what, but at least the merge will be slightly easier.

@RikkiGibson RikkiGibson force-pushed the merges/main-to-features/FileScopedNamespaces branch from 46a9d86 to 73ce00b Compare July 8, 2021 22:34
@RikkiGibson
Copy link
Contributor Author

CI is performing somewhat poorly right now so I just verified that .\Build.cmd -restore -test passes locally and will merge.

@RikkiGibson RikkiGibson merged commit 5d28e29 into features/FileScopedNamespaces Jul 8, 2021
@RikkiGibson RikkiGibson deleted the merges/main-to-features/FileScopedNamespaces branch July 8, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.