List patterns: IOperation #56008
Merged
List patterns: IOperation #56008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrz
force-pushed
the
list-patterns-iop
branch
from
362aac2
to
08fc517
Compare
This was referenced Oct 22, 2021
jcouv
reviewed
Oct 26, 2021
|
|
||
| var comp = CreateCompilation(source); | ||
| VerifyOperationTreeAndDiagnosticsForTest<IsPatternExpressionSyntax>(comp, expectedOperationTree, expectedDiagnostics); | ||
| } |
There was a problem hiding this comment.
Consider also testing error scenario this is .. or this is .. 42
alrz
commented
Oct 26, 2021
333fred
reviewed
Oct 26, 2021
src/Compilers/CSharp/Test/IOperation/IOperation/IOperationTests_IIsPatternExpression.cs
Show resolved
Hide resolved
333fred
reviewed
Oct 26, 2021
src/Compilers/CSharp/Test/IOperation/IOperation/IOperationTests_IIsPatternExpression.cs
Outdated
Show resolved
Hide resolved
|
Done review pass (commit 8) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to API review #57194
Test plan: #51289