Add basic implementation of new rename UI #57686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eferences to the new test framework
Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
…nc return the result of the TCS
…ementalAnalyzer.StateManager.cs Co-authored-by: Andrew Hall <ryzngard@live.com>
…109.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.21555.2 -> To Version 7.0.0-beta.21559.3
…cbe-aeb3-abaf7597957f [main] Update dependencies from dotnet/arcade
…ts project references being missing
…-deps-to-release/dev17.1 Merge release/dev17.0-vs-deps to release/dev17.1
* Fix C# language name in spec * Update docs/features/pdb-compilation-options.md Co-authored-by: Youssef Victor <youssefvictor00@gmail.com> Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
This just ensures some sanity.
Move the task completion source for a queue item into the queue item itself.
Ensure that getting the checksum for a project cone is resilient to its project references being missing
Fix null ref in navbars
…-main Merge release/dev17.1 to main
Load SVsShellDebugger before calling IVsSolution.CreateSolution
…ility diagnostics for an inaccessible internal symbol. (dotnet#57783) This avoids an infinite cycle during attribute binding. Fixes dotnet#57742.
…-main Merge release/dev17.1 to main
…xceptions-during-unload Don't throw exceptions for file changes after a project is unloaded
Index values weren't properly handled previously, and it was assumed all parameters existed in a method. In reality some exist in properties. Who knew!??! No need to worry about the cast, symbol finder will do the right thing. Code does need to be updated to handle the fact that we want to track potentially two things with index: the argument passed in as the index in callsites, and potentially the item being indexed to. Update the FindReferencesProgress to handle references for index specifically. Fixes dotnet#57100
VS is taking over insertion of - System.Collections.Immutable - System.Reflection.Metadata - System.Runtime.CompilerServices.Unsafe - System.Threading.Tasks.Extensions See https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/364153 for part of this change
Bypass IBCMerge for EditorFeatures.Wpf
Remove handling of certain BCL binaries from our build
[LSP] Use test accessor task instead of async operation to wait for LSP server shutdown in tests
JoeRobich
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the most basic implementation of the new rename UI. This PR is mostly to move code around and start a very ugly but workable demo. None of the behavior in the new UI is final, but it should make subsequent code reviews easier to parse in chunks as we modify the behavior.