Skip to content

Conversation

@github-actions
Copy link
Contributor

I detected changes in the main branch which have not been merged yet to release/dev17.15. I'm a robot and am configured to help you automatically keep release/dev17.15 up to date, so I've opened this PR.

This PR merges commits made on main by the following committers:

  • CyrusNajmabadi
  • AlekseyTs
  • maryamariyan
  • jcouv
  • ilyfairy

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

merge button instructions

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout main
git pull --ff-only
git checkout release/dev17.15
git pull --ff-only
git merge --no-ff main

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet/roslyn HEAD:merge/main-to-release/dev17.15
or if you are using SSH
git push git@github.com:dotnet/roslyn HEAD:merge/main-to-release/dev17.15

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/main-to-release/dev17.15'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote.

git fetch
git checkout -b merge/main-to-release/dev17.15 origin/release/dev17.15
git pull https://github.com/dotnet/roslyn merge/main-to-release/dev17.15
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet/roslyn HEAD:merge/main-to-release/dev17.15
or if you are using SSH
git fetch
git checkout -b merge/main-to-release/dev17.15 origin/release/dev17.15
git pull git@github.com:dotnet/roslyn merge/main-to-release/dev17.15
(make changes)
git commit -m "Updated PR with my changes"
git push git@github.com:dotnet/roslyn HEAD:merge/main-to-release/dev17.15

Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.

jcouv and others added 30 commits January 27, 2025 10:27
Also fleshed out implementation of ```SourceExtensionImplementationMethodSymbol.AddSynthesizedAttributes```.
maryamariyan and others added 12 commits March 25, 2025 23:04
- BoundCollectionElementInitializer.InvokedAsExtensionMethod
- BoundCall.InvokedAsExtensionMethod
- BoundDelegateCreationExpression.IsExtensionMethod
- MethodGroup.IsExtensionMethodGroup
- MethodGroupResolution.IsExtensionMethodGroup
…ntedExceptionDiagnosticAnalyzer.cs

Co-authored-by: Cyrus Najmabadi <cyrus.najmabadi@gmail.com>
Every time a developer uses the 💡 `Generate Method` feature in VS,
then with a ctrl+dot the cursor gets placed on the name of the newly
generated method which by default contains `throw new
NotImplementedException()`:


https://github.com/user-attachments/assets/5aa69115-6660-43c4-b711-eaa0f4772d8d

To help the discoverability and usability of `Implement with Copilot`,
especially for the developers frequently using the `Generate Method`
feature, I am making the analyzer diagnostic for `Implement with
Copilot` also light up on the method or property name containing the
`NotImplementedException` throw nodes.
@github-actions github-actions bot requested review from a team as code owners March 27, 2025 03:14
@ghost ghost added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 27, 2025
@dotnet-policy-service dotnet-policy-service bot added the Needs API Review Needs to be reviewed by the API review council label Mar 27, 2025
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approve

dotnet-maestro bot and others added 3 commits March 27, 2025 05:02
…ence-packages build 20250326.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.617501 -> To Version 10.0.617601
#77859)

This pull request updates the following dependencies

[marker]: <> (Begin:4e88e544-5668-4a45-0f48-08dc0c57b4c0)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 4e88e544-5668-4a45-0f48-08dc0c57b4c0
- **Build**:
[20250326.1](https://dev.azure.com/dnceng/internal/_build/results?buildId=2672479)
- **Date Produced**: March 26, 2025 4:46:01 PM UTC
- **Commit**:
[1556b6c639edcaee959013681afcf2e66b118537](dotnet/source-build-reference-packages@1556b6c)
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 10.0.617501 to 10.0.617601][1]

[1]:
dotnet/source-build-reference-packages@d2fc981...1556b6c

[DependencyUpdate]: <> (End)


[marker]: <> (End:4e88e544-5668-4a45-0f48-08dc0c57b4c0)
@github-actions github-actions bot requested a review from a team as a code owner March 27, 2025 11:10
@jjonescz

This comment was marked as outdated.

@jjonescz
Copy link
Member

Looks like the conflicts are straight forward, I will try to resolve them.

@jjonescz jjonescz force-pushed the merge/main-to-release/dev17.15 branch from 7a5efb0 to d34e6ed Compare March 27, 2025 14:38
@dotnet-policy-service dotnet-policy-service bot merged commit 36b57da into release/dev17.15 Mar 27, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure Needs API Review Needs to be reviewed by the API review council untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants