Skip to content

Remove dependency on EditorFeatures from codelens layer #78045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

Remove dependency on EditorFeatures from codelens layer #78045

merged 1 commit into from
Apr 8, 2025

Conversation

@CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Apr 8, 2025

No description provided.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner April 8, 2025 02:27
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 8, 2025
@CyrusNajmabadi
Copy link
Member Author

CyrusNajmabadi commented Apr 8, 2025

@JoeRobich @dibarbet ptal

CyrusNajmabadi
CyrusNajmabadi commented Apr 8, 2025
View reviewed changes
src/LanguageServer/Protocol/Microsoft.CodeAnalysis.LanguageServer.Protocol.csproj
<InternalsVisibleTo Include="Microsoft.CodeAnalysis.VisualBasic.LanguageServer.Protocol" />
<InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices" />
<InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices.Implementation" />
<InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices.CodeLens" />
Copy link
Member Author

@CyrusNajmabadi CyrusNajmabadi Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this, so we get access to an extensio nmethod we need in this lib.

@CyrusNajmabadi CyrusNajmabadi merged commit 4bd2f81 into dotnet:main Apr 8, 2025
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the codeLensEditorFeatures branch April 8, 2025 05:04
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 8, 2025
dibarbet added a commit to dibarbet/roslyn that referenced this pull request Apr 15, 2025
@dibarbet
Revert "Remove dependency on EditorFeatures from codelens layer (dotn…
337ff3c 
…et#78045)"

This reverts commit 4bd2f81, reversing
changes made to 7708789.
jaredpar pushed a commit that referenced this pull request Apr 16, 2025
@dibarbet
Revert "Remove dependency on EditorFeatures from codelens layer (#78045…
89219d1 
…)" (#78162)

This reverts commit 4bd2f81, reversing
changes made to 7708789.
This was referenced Apr 19, 2025
Closed
Closed
CyrusNajmabadi added a commit to CyrusNajmabadi/roslyn that referenced this pull request Apr 22, 2025
@CyrusNajmabadi
Reapply "Remove dependency on EditorFeatures from codelens layer (dot…
04bac5b 
…net#78045)" (dotnet#78162)

This reverts commit 89219d1.
CyrusNajmabadi added a commit that referenced this pull request Apr 24, 2025
@CyrusNajmabadi
Reapply "Remove dependency on EditorFeatures from codelens layer (#78045
788461b 
)" (#78162) (#78263)
@dotnet-bot dotnet-bot mentioned this pull request May 31, 2025
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

@dibarbet dibarbet Awaiting requested review from dibarbet

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Milestone

18.0 P1

Development

Successfully merging this pull request may close these issues.

3 participants

@CyrusNajmabadi @JoeRobich @RikkiGibson