Revert "Remove dependency on EditorFeatures from codelens layer (#78045)" #78162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Infrastructure
untriaged
Member
Author
Testing whether this change is the cause of some FileNotFound exceptions for EditorFeatures in the servicehub process. |
Member
|
Yes. It would be. Editor features cannot be in service hub. |
Member
|
I don't know why/how this could matter. How could the servicehub process try to load this dll if it doesn't even reference any symbols from it? What's the stack where this is getting loaded? |
Member
Author
|
@sharwell for review |
CyrusNajmabadi
approved these changes
Apr 16, 2025
This was referenced Apr 19, 2025
CyrusNajmabadi
added a commit
to CyrusNajmabadi/roslyn
that referenced
this pull request
Apr 22, 2025
…net#78045)" (dotnet#78162) This reverts commit 89219d1.
CyrusNajmabadi
added a commit
that referenced
this pull request
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation - https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/628816
Looks like VS unit testing has a dependency on editor features in OOP - https://devdiv.visualstudio.com/DevDiv/_git/VSUnitTesting?path=/src/TestWindow/CodeLens/Microsoft.VisualStudio.TestWindow.CodeLens.csproj&version=GBmain&_a=contents
This reverts commit 4bd2f81, reversing changes made to 7708789.