Reapply "Remove dependency on EditorFeatures from codelens layer (#78045)" (#78162) #78263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…net#78045)" (dotnet#78162) This reverts commit 89219d1.
ghost
added
Area-IDE
untriaged
JoeRobich
approved these changes
Apr 22, 2025
dibarbet
approved these changes
Apr 22, 2025
Member
dibarbet
left a comment
dibarbet
left a comment
There was a problem hiding this comment.
Can go in now that https://devdiv.visualstudio.com/DevDiv/_git/VSUnitTesting/pullrequest/629012 has merged.
Has this been inserted on the unit testing side? Does it require a dual insertion?
Member
Author
it has gone into VSUnitTesting. I have to see if it's gnoe into main.
Nope. The UnitTesting PR strictly removed their dependency on EditorFeatures entirely. |
Member
Author
|
Kicked off a val build. If it passes, will merge. |
Member
Author
|
Everything passed. merging this in. |
This was referenced Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 89219d1.
Reverts #78162
Can go in now that https://devdiv.visualstudio.com/DevDiv/_git/VSUnitTesting/pullrequest/629012 has merged.
Build: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=11459902&view=results
PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/630894