Merge master into future #7853
Merged
Merge master into future #7853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds tests for this case. Right now /delaysign silently wins. Fixes bug #7734.
…use proper test methods
Make /delaysign and /publicsign used together an error
Skip flaky tests
If non-roslyn runs enable node reuse and leave instances floating around, roslyn will reuse them (even with node reuse disabled) and have problems (e.g. because the build task is not the expected version).
Kill msbuild before each CI run
Because #7812 is not yet fixed, the IDE doesn't know if we set the PublicSign flag. As a result, all design-time builds will thing we're real-signing, which causes semantics to get all screwed up. The workaround for now is, for design-time builds only, to pass the DelaySign flag since that's "good enough". Fixes GitHub issue #7790.
…n-attribute Fix design time builds in the Roslyn solution for PublicSign projects
Skip a flaky test
Verify improved errors for name lookup
Fixes #7470 NRE in build task
The previous NuGet package got upgraded, but the ref was not
Bump the compiler MSBuild task version on every build
|
@agocke Any idea why this failed? It appears to include both of your build task fixes. |
|
@agocke - I understand future doesn't have the toolset compiler that includes your fix. |
Fix Scripting ref to System.Runtime.Loader
…uture20160108-160001
|
xunit error in 64 bit tests here, will investigate test prtest/win/dbg/unit64 please |
|
test vsi please |
|
👍, pending tests |
|
Mac build won't start, merging to get other builds green. |
brettfo
added a commit
that referenced
this pull request
Jan 9, 2016
…0108-160001 Merge master into future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into future.
@dotnet/roslyn-infrastructure:
Once the merge can be made and all the tests pass, you are free to merge the pull request.