Use dotnet run file for generating compiler code #80248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjonescz
reviewed
Sep 12, 2025
RikkiGibson
reviewed
Sep 12, 2025
Dogfood the new `dotnet run file.cs` support to replace our `generate-compiler-code.ps1` script with an equivalent script written in pure csharp with project dependencies.
333fred
force-pushed
the
move-to-run-file
branch
from
f7bff30 to
54af466
Compare
333fred
commented
Sep 15, 2025
Member
Author
There was a problem hiding this comment.
Note: this needed to be renamed because, now that there are scripts in folder, the scripts would treat this dir.packages.props as the real one, which would cause failures.
Member
Author
|
@dotnet/roslyn-compiler for review. |
Contributor
|
I think we should keep |
jcouv
reviewed
Sep 15, 2025
jcouv
reviewed
Sep 15, 2025
jcouv
reviewed
Sep 15, 2025
jcouv
reviewed
Sep 15, 2025
Member
jcouv
left a comment
jcouv
left a comment
There was a problem hiding this comment.
Done with review pass (commit 8). Only minor questions/suggestions
Member
Author
|
@RikkiGibson @jjonescz for review please |
RikkiGibson
reviewed
Sep 17, 2025
RikkiGibson
reviewed
Sep 17, 2025
RikkiGibson
approved these changes
Sep 17, 2025
jjonescz
reviewed
Sep 18, 2025
jjonescz
approved these changes
Sep 18, 2025
RikkiGibson
approved these changes
Sep 18, 2025
333fred
added a commit
that referenced
this pull request
Sep 18, 2025
* upstream/main: (206 commits) Remove bogus xlf tag (#80357) Fix missing type argument checks Add tests Use dotnet run file for generating compiler code (#80248) Only restore based on assets file changes if the actual content changed (#80341) make expressionbody analyzer use semanticspananalysis (#80339) [EnC] Use ignoreAssemblyKey: false to resolve symbol keys (#80342) Properly populate ExportedType metadata table in presence of extension block. (#80311) Propagate `params` to lambdas and local functions (#79880) Change 17.15 to VS 2026 preview. (#80325) Improve virtualproject support for older .NET SDKs (#80324) Update dependencies from https://github.com/dotnet/dotnet build 283666 (#80344) Update dependencies from https://github.com/dotnet/arcade build 20250917.6 (#80343) Simplifying Fix tests Fix tests Fix introduce variable placement in top level statements move to immutable types in signature help move to immutable types in signature help Fix check ...
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Sep 18, 2025
* upstream/main: (31 commits) Remove bogus xlf tag (dotnet#80357) Fix missing type argument checks Add tests Use dotnet run file for generating compiler code (dotnet#80248) Only restore based on assets file changes if the actual content changed (dotnet#80341) make expressionbody analyzer use semanticspananalysis (dotnet#80339) [EnC] Use ignoreAssemblyKey: false to resolve symbol keys (dotnet#80342) Properly populate ExportedType metadata table in presence of extension block. (dotnet#80311) Propagate `params` to lambdas and local functions (dotnet#79880) Change 17.15 to VS 2026 preview. (dotnet#80325) Improve virtualproject support for older .NET SDKs (dotnet#80324) Update dependencies from https://github.com/dotnet/dotnet build 283666 (dotnet#80344) Update dependencies from https://github.com/dotnet/arcade build 20250917.6 (dotnet#80343) Simplifying Fix tests Fix tests Fix introduce variable placement in top level statements move to immutable types in signature help move to immutable types in signature help Fix check ...
This was referenced Sep 25, 2025
This was referenced Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dogfood the new
dotnet run file.cssupport to replace ourgenerate-compiler-code.ps1script with an equivalent script written in pure csharp with project dependencies.