Skip to content

Add test demonstrating behavior of ToMinimalDisplayString. #80757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

Add test demonstrating behavior of ToMinimalDisplayString. #80757

merged 1 commit into from
Oct 22, 2025

Conversation

@CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Oct 16, 2025 •
edited
Loading

Closes #36654

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner October 16, 2025 13:27
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Oct 16, 2025
Closed
@CyrusNajmabadi
Copy link
Member Author

CyrusNajmabadi commented Oct 16, 2025

@dotnet/roslyn-compiler ptal.

jcouv
jcouv reviewed Oct 16, 2025
View reviewed changes
src/Compilers/CSharp/Test/Symbol/SymbolDisplay/SymbolDisplayTests.cs
var tree = compilation.SyntaxTrees[0];
var model = compilation.GetSemanticModel(tree);

var invocation = tree.GetRoot().DescendantNodes().OfType<InvocationExpressionSyntax>().Single();
Copy link
Member

@jcouv jcouv Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: FYI, we have a helper I like to use that lets you do var invocation = GetSyntax<InvocationExpressionSyntax>(tree, "vvv.getlist()");
The advantage is that it is immediately apparent to reviewers what invocation syntax we're grabbing

Copy link
Member Author

@CyrusNajmabadi CyrusNajmabadi Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot please apply the above suggestion.

Copy link
Member

@jcouv jcouv Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I don't think it did it

jcouv
jcouv approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (commit 1)

@jcouv jcouv added the Test Test failures in roslyn-CI label Oct 16, 2025
@jcouv jcouv self-assigned this Oct 16, 2025
@CyrusNajmabadi
Copy link
Member Author

CyrusNajmabadi commented Oct 20, 2025

@dotnet/roslyn-compiler for another pair of eye.s

jjonescz
jjonescz approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@jjonescz jjonescz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although only one compiler review should be enough for test-only changes

@CyrusNajmabadi CyrusNajmabadi merged commit 1b26500 into dotnet:main Oct 22, 2025
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the demonstrateBehaviour branch October 22, 2025 12:27
@CyrusNajmabadi
Copy link
Member Author

CyrusNajmabadi commented Oct 22, 2025

Thanks!

@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 22, 2025
333fred added a commit to 333fred/roslyn that referenced this pull request Oct 22, 2025
@333fred
Merge remote-tracking branch 'upstream/main' into inline-array
5f9a882 
* upstream/main: (123 commits)
  Fix SafeContext of Span-valued collection expressions to match specification (dotnet#80684)
  Improve detection of invalid references for implicitly typed expression variables declared within implicit object creation expressions. (dotnet#80546)
  Add test demonstrating behavior of ToMinimalDisplayString. (dotnet#80757)
  Only set DOTNET_HOST_PATH if something was installed (dotnet#80842)
  Clean up a Razor external access service (dotnet#80830)
  Remove unused statement (dotnet#80823)
  Allow foreach on typed null enumerables (dotnet#80783)
  Update documentation for DeclaringSyntaxReferences and Locations to clarify partial members behavior (dotnet#80704)
  Fix issue converting an auto prop to a full prop when 'field' and 'initializers' are involved
  Rename childIsSimple to innerExpressionHasPrimaryPrecedence and add more test cases
  Remove placeholder WorkItem attributes from new tests
  Fix RemoveUnnecessaryParentheses to detect simple expressions in bitwise operations
  [main] Update dependencies from dotnet/arcade (dotnet#80828)
  Fix ITypeSymbol.BaseType documentation for type parameters (dotnet#80770)
  soft-select select camelcase matched item if user might be typing an undefined type parameter (dotnet#80809)
  Allow semantic tokens in Razor to be better behaved (dotnet#80815)
  Rebase
  Remove using
  Update test
  Add fix all test
  ...
@dotnet-maestro dotnet-maestro bot mentioned this pull request Oct 23, 2025
Closed
This was referenced Oct 25, 2025
Closed
Closed
Closed
@dotnet-maestro dotnet-maestro bot mentioned this pull request Oct 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcouv jcouv jcouv approved these changes

@jjonescz jjonescz jjonescz approved these changes

Assignees

@jcouv jcouv

Labels

Area-Compilers Test Test failures in roslyn-CI

Projects

None yet

Milestone

Next

Development

Successfully merging this pull request may close these issues.

Incorrect output of ToMinimalDisplayString() with namespace hiding

3 participants

@CyrusNajmabadi @jjonescz @jcouv