Skip to content

Only set DOTNET_HOST_PATH if something was installed #80842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

Only set DOTNET_HOST_PATH if something was installed #80842

merged 1 commit into from
Oct 22, 2025

Conversation

@dibarbet
Copy link
Member

@dibarbet dibarbet commented Oct 21, 2025

Fixes signed build failures

We were unconditionally setting DOTNET_HOST_PATH to the local .dotnet folder, but if a globally installed SDK is found the local SDK may not exist.

C:\ToolCache\dotnet\sdk\10.0.100-rc.2.25502.107\Roslyn\Microsoft.CSharp.Core.targets(84,5): error : It was not possible to find any compatible framework version [D:\a\_work\1\s\src\Compilers\Core\Portable\Microsoft.CodeAnalysis.csproj::TargetFramework=net9.0]
##[error]C:\ToolCache\dotnet\sdk\10.0.100-rc.2.25502.107\Roslyn\Microsoft.CSharp.Core.targets(84,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) It was not possible to find any compatible framework version
C:\ToolCache\dotnet\sdk\10.0.100-rc.2.25502.107\Roslyn\Microsoft.CSharp.Core.targets(84,5): error : The framework 'Microsoft.NETCore.App', version '10.0.0-rc.2.25502.107' was not found. [D:\a\_work\1\s\src\Compilers\Core\Portable\Microsoft.CodeAnalysis.csproj::TargetFramework=net9.0]
##[error]C:\ToolCache\dotnet\sdk\10.0.100-rc.2.25502.107\Roslyn\Microsoft.CSharp.Core.targets(84,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) The framework 'Microsoft.NETCore.App', version '10.0.0-rc.2.25502.107' was not found.
C:\ToolCache\dotnet\sdk\10.0.100-rc.2.25502.107\Roslyn\Microsoft.CSharp.Core.targets(84,5): error :   - The following frameworks were found: [D:\a\_work\1\s\src\Compilers\Core\Portable\Microsoft.CodeAnalysis.csproj::TargetFramework=net9.0]
##[error]C:\ToolCache\dotnet\sdk\10.0.100-rc.2.25502.107\Roslyn\Microsoft.CSharp.Core.targets(84,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build)   - The following frameworks were found:
C:\ToolCache\dotnet\sdk\10.0.100-rc.2.25502.107\Roslyn\Microsoft.CSharp.Core.targets(84,5): error :       3.1.28 at [D:\a\_work\1\s\.dotnet\shared\Microsoft.NETCore.App] [D:\a\_work\1\s\src\Compilers\Core\Portable\Microsoft.CodeAnalysis.csproj::TargetFramework=net9.0]
##[error]C:\ToolCache\dotnet\sdk\10.0.100-rc.2.25502.107\Roslyn\Microsoft.CSharp.Core.targets(84,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build)       3.1.28 at [D:\a\_work\1\s\.dotnet\shared\Microsoft.NETCore.App]

@dibarbet dibarbet requested a review from a team as a code owner October 21, 2025 22:32
@dibarbet dibarbet force-pushed the dev/dibarbet/fix_official branch from 1680893 to 28de057 Compare October 21, 2025 23:18
@dibarbet dibarbet force-pushed the dev/dibarbet/fix_official branch from 28de057 to cf644c2 Compare October 21, 2025 23:20
@dibarbet
Copy link
Member Author

dibarbet commented Oct 22, 2025

passed the build step here - https://dev.azure.com/dnceng/internal/_build/results?buildId=2821637&view=results

@dibarbet dibarbet merged commit e9cfa84 into dotnet:main Oct 22, 2025
28 checks passed
@dibarbet dibarbet deleted the dev/dibarbet/fix_official branch October 22, 2025 00:46
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 22, 2025
@jjonescz jjonescz mentioned this pull request Oct 22, 2025
Closed
333fred added a commit to 333fred/roslyn that referenced this pull request Oct 22, 2025
@333fred
Merge remote-tracking branch 'upstream/main' into inline-array
5f9a882 
* upstream/main: (123 commits)
  Fix SafeContext of Span-valued collection expressions to match specification (dotnet#80684)
  Improve detection of invalid references for implicitly typed expression variables declared within implicit object creation expressions. (dotnet#80546)
  Add test demonstrating behavior of ToMinimalDisplayString. (dotnet#80757)
  Only set DOTNET_HOST_PATH if something was installed (dotnet#80842)
  Clean up a Razor external access service (dotnet#80830)
  Remove unused statement (dotnet#80823)
  Allow foreach on typed null enumerables (dotnet#80783)
  Update documentation for DeclaringSyntaxReferences and Locations to clarify partial members behavior (dotnet#80704)
  Fix issue converting an auto prop to a full prop when 'field' and 'initializers' are involved
  Rename childIsSimple to innerExpressionHasPrimaryPrecedence and add more test cases
  Remove placeholder WorkItem attributes from new tests
  Fix RemoveUnnecessaryParentheses to detect simple expressions in bitwise operations
  [main] Update dependencies from dotnet/arcade (dotnet#80828)
  Fix ITypeSymbol.BaseType documentation for type parameters (dotnet#80770)
  soft-select select camelcase matched item if user might be typing an undefined type parameter (dotnet#80809)
  Allow semantic tokens in Razor to be better behaved (dotnet#80815)
  Rebase
  Remove using
  Update test
  Add fix all test
  ...
@dotnet-maestro dotnet-maestro bot mentioned this pull request Oct 23, 2025
Closed
This was referenced Oct 25, 2025
Closed
Closed
Closed
@dotnet-maestro dotnet-maestro bot mentioned this pull request Oct 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterwald peterwald peterwald approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

Assignees

No one assigned

Labels

Area-Infrastructure

Projects

None yet

Milestone

Next

Development

Successfully merging this pull request may close these issues.

3 participants

@dibarbet @peterwald @RikkiGibson