Clean up a Razor external access service #80830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
approved these changes
Oct 21, 2025
akhera99
approved these changes
Oct 21, 2025
dibarbet
approved these changes
Oct 21, 2025
Member
|
this may also fix https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2550800 |
jasonmalinowski
approved these changes
Oct 21, 2025
Member
Author
Based on your comment there, yes it should. You should have just assigned it to me once you saw the word "Razor" 😛 |
Member
Author
|
Thanks for the reviews all, taking this opportunity to mostly revert #80815 since I completely missed that this service already existed, and we can just use it (and indeed, already do elsewhere) 🤦♂️ |
dibarbet
approved these changes
Oct 21, 2025
davidwengier
added a commit
to dotnet/razor
that referenced
this pull request
Oct 21, 2025
Fixes #11848 ~Consumes dotnet/roslyn#80815 to won't build until we bump Roslyn~ Update: This now needs to consume dotnet/roslyn#80830 because we already had an EA service for semantic tokens, so we should use it Just a bit of finishing touches to semantic tokens in cohosting.
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Oct 22, 2025
* upstream/main: (123 commits) Fix SafeContext of Span-valued collection expressions to match specification (dotnet#80684) Improve detection of invalid references for implicitly typed expression variables declared within implicit object creation expressions. (dotnet#80546) Add test demonstrating behavior of ToMinimalDisplayString. (dotnet#80757) Only set DOTNET_HOST_PATH if something was installed (dotnet#80842) Clean up a Razor external access service (dotnet#80830) Remove unused statement (dotnet#80823) Allow foreach on typed null enumerables (dotnet#80783) Update documentation for DeclaringSyntaxReferences and Locations to clarify partial members behavior (dotnet#80704) Fix issue converting an auto prop to a full prop when 'field' and 'initializers' are involved Rename childIsSimple to innerExpressionHasPrimaryPrecedence and add more test cases Remove placeholder WorkItem attributes from new tests Fix RemoveUnnecessaryParentheses to detect simple expressions in bitwise operations [main] Update dependencies from dotnet/arcade (dotnet#80828) Fix ITypeSymbol.BaseType documentation for type parameters (dotnet#80770) soft-select select camelcase matched item if user might be typing an undefined type parameter (dotnet#80809) Allow semantic tokens in Razor to be better behaved (dotnet#80815) Rebase Remove using Update test Add fix all test ...
This was referenced Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a bunch of double-dispose exceptions in some Razor integration test logs. We get the service from the DI container, so we shouldn't dispose it because the DI container will.