VectorSingle and VectorDoubleEqualsNonCanonicalNaNTest fails on Mono #74781

steveisok · 2022-08-29T20:32:30Z

From the logs, the Assert.False is failing

runtime/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs

Line 893 in 51f7639

Assert.False(new Vector<float>(i) == new Vector<float>(j));

It is tough to tell which nan value is the cause:

runtime/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs

Lines 881 to 884 in 51f7639

    
           float.CopySign(float.NaN, -0.0f), // -qnan same as float.NaN 
        
           float.CopySign(float.NaN, +0.0f), // +qnan 
        
           float.CopySign(snan, -0.0f),      // -snan 
        
           float.CopySign(snan, +0.0f),      // +snan

Stack trace:

Assert.False() Failure\nExpected: False\nActual:   True
at System.Numerics.Tests.GenericVectorTests.VectorSingleEqualsNonCanonicalNaNTest() in /_/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs:line 893
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)]]

Assert.False() Failure\nExpected: False\nActual:   True
at System.Numerics.Tests.GenericVectorTests.VectorDoubleEqualsNonCanonicalNaNTest() in /_/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs:line 869
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)]]

Report

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
0	0	0

The text was updated successfully, but these errors were encountered:

ghost · 2022-08-29T20:32:41Z

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

From the logs, the Assert.False is failing

runtime/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs

Line 893 in 51f7639

Assert.False(new Vector<float>(i) == new Vector<float>(j));

It is tough to tell which nan value is the cause:

runtime/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs

Lines 881 to 884 in 51f7639

    
           float.CopySign(float.NaN, -0.0f), // -qnan same as float.NaN 
        
           float.CopySign(float.NaN, +0.0f), // +qnan 
        
           float.CopySign(snan, -0.0f),      // -snan 
        
           float.CopySign(snan, +0.0f),      // +snan

Stack trace:

Assert.False() Failure\nExpected: False\nActual:   True
at System.Numerics.Tests.GenericVectorTests.VectorSingleEqualsNonCanonicalNaNTest() in /_/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs:line 893
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)]]

Assert.False() Failure\nExpected: False\nActual:   True
at System.Numerics.Tests.GenericVectorTests.VectorDoubleEqualsNonCanonicalNaNTest() in /_/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs:line 869
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)]]

Author:	steveisok
Assignees:	-
Labels:	`area-System.Numerics`, `untriaged`
Milestone:	-

ghost · 2022-08-29T20:33:04Z

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

From the logs, the Assert.False is failing

runtime/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs

Line 893 in 51f7639

Assert.False(new Vector<float>(i) == new Vector<float>(j));

It is tough to tell which nan value is the cause:

runtime/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs

Lines 881 to 884 in 51f7639

    
           float.CopySign(float.NaN, -0.0f), // -qnan same as float.NaN 
        
           float.CopySign(float.NaN, +0.0f), // +qnan 
        
           float.CopySign(snan, -0.0f),      // -snan 
        
           float.CopySign(snan, +0.0f),      // +snan

Stack trace:

Assert.False() Failure\nExpected: False\nActual:   True
at System.Numerics.Tests.GenericVectorTests.VectorSingleEqualsNonCanonicalNaNTest() in /_/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs:line 893
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)]]

Assert.False() Failure\nExpected: False\nActual:   True
at System.Numerics.Tests.GenericVectorTests.VectorDoubleEqualsNonCanonicalNaNTest() in /_/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs:line 869
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)]]

Author:	steveisok
Assignees:	-
Labels:	`area-System.Numerics`, `blocking-clean-ci`
Milestone:	-

steveisok · 2022-08-29T20:39:53Z

/cc @karelz

akoeplinger · 2022-08-30T08:26:10Z

I think this fails on all Mono platforms/configs, we just didn't see it due to the issue that will be fixed by #74788.

I'll disable the tests for Mono for now.

tannergooding · 2022-08-30T12:20:01Z

Do we know why or how Mono is failing here?

steveisok · 2022-08-30T12:31:51Z

Do we know why or how Mono is failing here?

Not yet. I was primarily trying to keep CI clean.

/cc @SamMonoRT

MichalPetryka · 2022-08-30T12:44:46Z

Should we maybe add custom messages to the asserts that will say which nans are failing?

* CI: Fix helix test results reporting PR #73060 broke uploading of helix test results. This was caused by the change: ```xml <HelixPostCommands>@(HelixPostCommand)</HelixPostCommands> ``` This is overwriting the existing value of `$(HelixPostCommands)`, which gets set to have the upload script invocation in https://github.com/dotnet/arcade/blob/34dff939b4a91e4693f78a856e0e055c1a3f3fba/src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/AzurePipelines.MonoQueue.targets#L8-L15 at evaluation time. Fix by *appending* to the property. Thanks to ChadNedzlek for finding the cause! Fixes #74699 . * Disable failing tests, see #74781 Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>

SamMonoRT · 2022-08-30T18:01:55Z

removing blocking-clean-ci tag as tests have been disabled till we identify the cause/fix.

fanyang-mono · 2022-09-26T14:40:46Z

@steveisok Do you happen to remember which platform the test failed?

steveisok · 2022-09-26T14:54:45Z

@steveisok Do you happen to remember which platform the test failed?

Looks like they fail for all platforms.

dakersnar · 2022-09-29T22:19:37Z

Is this the right area label for this issue?

matouskozak · 2022-11-01T15:43:57Z

The failing cases are when comparing the same elements with each other from the nans array using the == operator (return True instead of False). This issue is caused by MiniJIT OP_XEQUAL:

runtime/src/mono/mono/mini/mini-amd64.c

Lines 3882 to 3897 in 5333727

    
           case OP_XEQUAL: { 
        
           	int temp_reg1 = mono_alloc_ireg (cfg); 
        
           	int temp_reg2 = mono_alloc_ireg (cfg); 
        
           	NEW_SIMD_INS (cfg, ins, temp, OP_PCMPEQD, temp_reg1, ins->sreg1, ins->sreg2); 
        
           	NEW_SIMD_INS (cfg, ins, temp, OP_EXTRACT_MASK, temp_reg2, temp_reg1, -1); 
        
           	temp->type = STACK_I4; 
        
           	NEW_INS (cfg, ins, temp, OP_COMPARE_IMM); 
        
           	temp->sreg1 = temp_reg2; 
        
           	temp->inst_imm = 0xFFFF; 
        
           	temp->klass = ins->klass; 
        
           	ins->opcode = OP_CEQ; 
        
           	ins->sreg1 = -1; 
        
           	ins->sreg2 = -1; 
        
           	break; 
        
           }

I can confirm that the tests work correctly when using LLVM JIT or software fallback.

In current implementation OP_XEQUAL doesn't emit different instructions for different input types which is causing that floats and doubles are handled incorrectly.

matouskozak · 2022-11-11T17:10:10Z

This issue is fixed by #77770.

ghost added the untriaged New issue has not been triaged by the area owner label Aug 29, 2022

dotnet-issue-labeler bot added the area-System.Numerics label Aug 29, 2022

steveisok added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' and removed area-System.Numerics untriaged New issue has not been triaged by the area owner labels Aug 29, 2022

steveisok added the area-System.Numerics label Aug 29, 2022

steveisok added os-android x64 labels Aug 29, 2022

steveisok added this to the 8.0.0 milestone Aug 29, 2022

steveisok mentioned this issue Aug 29, 2022

[Android] Skip VectorSingle and VectorDoubleEqualsNonCanonicalNaNTest on x64 #74782

Closed

runfoapp bot mentioned this issue Aug 29, 2022

Infrastructure - Status/Health #702

Closed

akoeplinger added runtime-mono specific to the Mono runtime disabled-test The test is disabled in source code against the issue and removed os-android x64 labels Aug 30, 2022

akoeplinger changed the title ~~[Android] VectorSingle and VectorDoubleEqualsNonCanonicalNaNTest fails on Android x64~~ [Android] VectorSingle and VectorDoubleEqualsNonCanonicalNaNTest fails on Mono Aug 30, 2022

akoeplinger changed the title ~~[Android] VectorSingle and VectorDoubleEqualsNonCanonicalNaNTest fails on Mono~~ VectorSingle and VectorDoubleEqualsNonCanonicalNaNTest fails on Mono Aug 30, 2022

akoeplinger added a commit to radical/runtime that referenced this issue Aug 30, 2022

Disable failing tests, see dotnet#74781

4987c0a

akoeplinger mentioned this issue Aug 30, 2022

CI: Fix helix test results reporting #74788

Merged

SamMonoRT assigned fanyang-mono Aug 30, 2022

SamMonoRT removed the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Aug 30, 2022

dakersnar added area-Codegen-meta-mono untriaged New issue has not been triaged by the area owner and removed area-System.Numerics labels Sep 29, 2022

fanyang-mono assigned matouskozak Oct 21, 2022

jeffschwMSFT removed the untriaged New issue has not been triaged by the area owner label Oct 27, 2022

matouskozak mentioned this issue Nov 2, 2022

[mono] MiniJIT OP_XEQUAL for floats #77770

Merged

fanyang-mono closed this as completed Nov 11, 2022

ghost locked as resolved and limited conversation to collaborators Dec 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VectorSingle and VectorDoubleEqualsNonCanonicalNaNTest fails on Mono #74781

VectorSingle and VectorDoubleEqualsNonCanonicalNaNTest fails on Mono #74781

steveisok commented Aug 29, 2022 •

edited by build-analysis bot

Loading

ghost commented Aug 29, 2022

ghost commented Aug 29, 2022

steveisok commented Aug 29, 2022

akoeplinger commented Aug 30, 2022

tannergooding commented Aug 30, 2022

steveisok commented Aug 30, 2022

MichalPetryka commented Aug 30, 2022

SamMonoRT commented Aug 30, 2022

fanyang-mono commented Sep 26, 2022

steveisok commented Sep 26, 2022

dakersnar commented Sep 29, 2022 •

edited

Loading

matouskozak commented Nov 1, 2022 •

edited

Loading

matouskozak commented Nov 11, 2022

VectorSingle and VectorDoubleEqualsNonCanonicalNaNTest fails on Mono #74781

VectorSingle and VectorDoubleEqualsNonCanonicalNaNTest fails on Mono #74781

Comments

steveisok commented Aug 29, 2022 • edited by build-analysis bot Loading

Report

Summary

ghost commented Aug 29, 2022

ghost commented Aug 29, 2022

steveisok commented Aug 29, 2022

akoeplinger commented Aug 30, 2022

tannergooding commented Aug 30, 2022

steveisok commented Aug 30, 2022

MichalPetryka commented Aug 30, 2022

SamMonoRT commented Aug 30, 2022

fanyang-mono commented Sep 26, 2022

steveisok commented Sep 26, 2022

dakersnar commented Sep 29, 2022 • edited Loading

matouskozak commented Nov 1, 2022 • edited Loading

matouskozak commented Nov 11, 2022

steveisok commented Aug 29, 2022 •

edited by build-analysis bot

Loading

dakersnar commented Sep 29, 2022 •

edited

Loading

matouskozak commented Nov 1, 2022 •

edited

Loading