-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] gRPC client tests #73060
Merged
Merged
[Android] gRPC client tests #73060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-grpc-client-tests
…-grpc-client-tests
* Get Docker container building & exported via test build * Changes * Add missing pfx certificate * changes * cleanup Co-authored-by: Simon Rozsival <simon@rozsival.com>
Tagging subscribers to this area: @directhex Issue DetailsThis is still WIP.
|
steveisok
approved these changes
Aug 22, 2022
akoeplinger
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few license related comments but looks good otherwise
...d/Device_Emulator/gRPC/grpc-dotnet/testassets/InteropTestsWebsite/InteropTestsWebsite.csproj
Outdated
Show resolved
Hide resolved
...onalTests/Android/Device_Emulator/gRPC/grpc-dotnet/testassets/Certs/InteropTests/server1.key
Show resolved
Hide resolved
src/tests/FunctionalTests/Android/Device_Emulator/gRPC/Android.Device_Emulator.gRPC.Test.csproj
Outdated
Show resolved
Hide resolved
...ctionalTests/Android/Device_Emulator/gRPC/grpc-dotnet/test/Shared/HttpEventSourceListener.cs
Show resolved
Hide resolved
…dotnet/runtime into simonrozsival/android-grpc-client-tests
akoeplinger
reviewed
Aug 24, 2022
...d/Device_Emulator/gRPC/grpc-dotnet/testassets/InteropTestsWebsite/InteropTestsWebsite.csproj
Show resolved
Hide resolved
akoeplinger
reviewed
Aug 24, 2022
akoeplinger
reviewed
Aug 24, 2022
...tionalTests/Android/Device_Emulator/gRPC/grpc-dotnet/testassets/Certs/InteropTests/README.md
Outdated
Show resolved
Hide resolved
akoeplinger
approved these changes
Aug 24, 2022
This was referenced Aug 24, 2022
radical
added a commit
to radical/runtime
that referenced
this pull request
Aug 29, 2022
PR dotnet#73060 broke uploading of helix test results. This was caused by the change: ```xml <HelixPostCommands>@(HelixPostCommand)</HelixPostCommands> ``` This is overwriting the existing value of `$(HelixPostCommands)`, which gets set to have the upload script invocation in https://github.com/dotnet/arcade/blob/34dff939b4a91e4693f78a856e0e055c1a3f3fba/src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/AzurePipelines.MonoQueue.targets#L8-L15 at evaluation time. Fix by *appending* to the property. Thanks to ChadNedzlek for finding the cause! Fixes dotnet#74699 .
radical
added a commit
that referenced
this pull request
Aug 30, 2022
* CI: Fix helix test results reporting PR #73060 broke uploading of helix test results. This was caused by the change: ```xml <HelixPostCommands>@(HelixPostCommand)</HelixPostCommands> ``` This is overwriting the existing value of `$(HelixPostCommands)`, which gets set to have the upload script invocation in https://github.com/dotnet/arcade/blob/34dff939b4a91e4693f78a856e0e055c1a3f3fba/src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/AzurePipelines.MonoQueue.targets#L8-L15 at evaluation time. Fix by *appending* to the property. Thanks to ChadNedzlek for finding the cause! Fixes #74699 . * Disable failing tests, see #74781 Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve gRPC support on mobile platforms, we're adding CI for the
Grpc.Client
nuget package that runs interop tests on Android emulators. Most of the code in this PR is copied from the https://github.com/grpc/grpc-dotnet repository.Each test builds and runs a docker container with an gRPC server and runs a functional test on an Android emulator against the server. The test will run periodically and also on demand with
/run azp android-grpc-client-tests
.Contributes to #69095