-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Fix helix test results reporting #74788
Conversation
PR dotnet#73060 broke uploading of helix test results. This was caused by the change: ```xml <HelixPostCommands>@(HelixPostCommand)</HelixPostCommands> ``` This is overwriting the existing value of `$(HelixPostCommands)`, which gets set to have the upload script invocation in https://github.com/dotnet/arcade/blob/34dff939b4a91e4693f78a856e0e055c1a3f3fba/src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/AzurePipelines.MonoQueue.targets#L8-L15 at evaluation time. Fix by *appending* to the property. Thanks to ChadNedzlek for finding the cause! Fixes dotnet#74699 .
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsPR #73060 broke uploading of helix test results. This was caused by the <HelixPostCommands>@(HelixPostCommand)</HelixPostCommands> This is overwriting the existing value of Fix by appending to the property. Thanks to ChadNedzlek for finding the cause! Fixes #74699 .
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure the test count in the PR build comes back up to 3 millionish, and this should be good.
Looks like we had a new failing test sneak in while this was broken, disabled it (see #74781) |
Does this need to wait for these jobs that we are re-running? |
I think it's ok to merge because it's high impact. |
PR #73060 broke uploading of helix test results. This was caused by the
change:
This is overwriting the existing value of
$(HelixPostCommands)
, whichgets set to have the upload script invocation in https://github.com/dotnet/arcade/blob/34dff939b4a91e4693f78a856e0e055c1a3f3fba/src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/AzurePipelines.MonoQueue.targets#L8-L15 at evaluation time.
Fix by appending to the property.
Thanks to ChadNedzlek for finding the cause!
Fixes #74699 .