Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix helix test results reporting #74788

Merged
merged 2 commits into from
Aug 30, 2022
Merged

CI: Fix helix test results reporting #74788

merged 2 commits into from
Aug 30, 2022

Conversation

radical
Copy link
Member

@radical radical commented Aug 29, 2022

PR #73060 broke uploading of helix test results. This was caused by the
change:

      <HelixPostCommands>@(HelixPostCommand)</HelixPostCommands>

This is overwriting the existing value of $(HelixPostCommands), which
gets set to have the upload script invocation in https://github.com/dotnet/arcade/blob/34dff939b4a91e4693f78a856e0e055c1a3f3fba/src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/AzurePipelines.MonoQueue.targets#L8-L15 at evaluation time.

Fix by appending to the property.

Thanks to ChadNedzlek for finding the cause!

Fixes #74699 .

PR dotnet#73060 broke uploading of helix test results. This was caused by the
change:

```xml
      <HelixPostCommands>@(HelixPostCommand)</HelixPostCommands>
```

This is overwriting the existing value of `$(HelixPostCommands)`, which
gets set to have the upload script invocation in https://github.com/dotnet/arcade/blob/34dff939b4a91e4693f78a856e0e055c1a3f3fba/src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/AzurePipelines.MonoQueue.targets#L8-L15 at evaluation time.

Fix by *appending* to the property.

Thanks to ChadNedzlek for finding the cause!

Fixes dotnet#74699 .
@radical radical added blocking Marks issues that we want to fast track in order to unblock other important work area-Infrastructure labels Aug 29, 2022
@ghost ghost assigned radical Aug 29, 2022
@ghost
Copy link

ghost commented Aug 29, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

PR #73060 broke uploading of helix test results. This was caused by the
change:

      <HelixPostCommands>@(HelixPostCommand)</HelixPostCommands>

This is overwriting the existing value of $(HelixPostCommands), which
gets set to have the upload script invocation in https://github.com/dotnet/arcade/blob/34dff939b4a91e4693f78a856e0e055c1a3f3fba/src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/AzurePipelines.MonoQueue.targets#L8-L15 at evaluation time.

Fix by appending to the property.

Thanks to ChadNedzlek for finding the cause!

Fixes #74699 .

Author: radical
Assignees: -
Labels:

blocking, area-Infrastructure

Milestone: -

Copy link
Member

@ChadNedzlek ChadNedzlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the test count in the PR build comes back up to 3 millionish, and this should be good.

@akoeplinger
Copy link
Member

Looks like we had a new failing test sneak in while this was broken, disabled it (see #74781)

@radical
Copy link
Member Author

radical commented Aug 30, 2022

Does this need to wait for these jobs that we are re-running?

@steveisok
Copy link
Member

Does this need to wait for these jobs that we are re-running?

I think it's ok to merge because it's high impact.

@radical radical merged commit 2ed931d into dotnet:main Aug 30, 2022
@radical radical deleted the helix-fix branch August 30, 2022 16:22
@ghost ghost locked as resolved and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure blocking Marks issues that we want to fast track in order to unblock other important work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helix test results are not getting uploaded for a lot of jobs
6 participants