Skip to content

Conversation

vcsjones
Copy link
Member

Backport #118652
Backport #118777

Customer Impact

None, test only change.

Regression

  • Yes
  • No

Testing

These tests were failing against macOS 26 RC. They now pass against macOS 26 RC.

Risk

None, test only change.

@vcsjones vcsjones added this to the 9.0.x milestone Sep 15, 2025
@vcsjones vcsjones self-assigned this Sep 15, 2025
@Copilot Copilot AI review requested due to automatic review settings September 15, 2025 14:38
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR backports test fixes for macOS 26 Tahoe compatibility to the release/9.0-staging branch. The changes address test failures that occurred when running against macOS 26 RC by updating platform detection logic and adjusting test expectations for certificate chain validation behavior on newer Apple platforms.

Key changes:

  • Added platform detection for Apple platforms version 26 or later
  • Updated certificate chain test expectations to handle behavioral differences in macOS 26
  • Modified test logic to group Linux and Apple 26+ platforms with similar behavior patterns

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Unix.cs Adds new property to detect Apple platforms version 26 or later
src/libraries/System.Security.Cryptography/tests/X509Certificates/ChainTests.cs Updates certificate chain test expectations for macOS 26 compatibility

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

@bartonjs
Copy link
Member

Test-only change, applying servicing-approved under tell-mode.

@bartonjs bartonjs added the Servicing-approved Approved for servicing release label Sep 15, 2025
@bartonjs bartonjs enabled auto-merge (squash) September 15, 2025 20:21
@vcsjones
Copy link
Member Author

I've given that timing out pipeline 4 tries, not really sure a 5th is going to work.

@jeffhandley
Copy link
Member

/ba-g Unrelated timeout

This was referenced Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Security Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants