Skip to content

Conversation

@pavelsavara
Copy link
Member

Follow up from #123329 (comment)

Mirroring and others added 30 commits April 15, 2025 17:01
…114441)

* Update dependencies from https://github.com/dotnet/arcade build 20250408.7

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25164.5 -> To Version 8.0.0-beta.25208.7

* Update dependencies from https://github.com/dotnet/arcade build 20250414.7

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25164.5 -> To Version 8.0.0-beta.25214.7

* Update MicrosoftDotnetSdkInternalVersion to 8.0.115

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
…ease/8.0-staging

[automated] Merge branch 'release/8.0' => 'release/8.0-staging'
After the recent VS upgrade from 17.12.5 to 17.13.2 we started seeing access violations in the mono-aot-cross.exe when targetting wasm.

We tracked it down to sgen_clz being miscompiled, we can workaround the compiler bug by switching from ternary condition to if/else.

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
…dotnet#114906)

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
…OS/tvOS simulator jobs to `osx.14.arm64.open` and `osx.15.amd64.open` queues (dotnet#114633)

iOSSimulator, tvOSSimulator, MacCatalyst pipelines are migrated to:
- `osx.15.amd64.open`
- `osx.14.arm64.open` (until `osx.15.arm64.open` has enough machines)

## Newly failing test scenarios
Some new failures were discovered during the migration. The tests were disabled and tracking issues were open to monitor progress for enablement.
- System.Net.Sockets.Tests.SocketOptionNameTest.MulticastInterface_Set_AnyInterface_Succeeds
- System.IO.IsolatedStorage
- System.IO. MemoryMappedFiles
- System.Net.Sockets.Tests.SendTo_.*.Datagram_UDP_AccessDenied_Throws_DoesNotBind
…dotnet#115012)

I noticed we were sending 30k workitems each day to various Helix queues, this is due to the outerloop pipeline having a schedule triggere which matches old preview branches or the staging branches.

This fixes that and also sets it so that the trigger only applies if there are actual source changes.

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
* Fix Idn tests

[Test Only] Port the Idna test fixes to support Unicode 15

* Minor fix

* Fine tune the idn to Unicode versions

* Add missing files
…rios (COM, C++/CLI, custom component host) could try to load coreclr from CWD

There is a fallback for apps with no .deps.json where the host will consider the app directory for loading coreclr. In component hosting scenarios, we do not have an app path / directory. We were incorrectly going down the path of looking for coreclr next to the empty app directory, which resulted in looking in the current directory.

This change skips that path for libhost scenarios. It also adds checks that the paths we determine for loading coreclr, hostpolicy, and hostfxr are absolute.
* new-dfr in one commit

* fixes for decommitting large+huge and comments

* only age regions during BGC

* fix age_all_region_kinds condition.

* fixing merge conflict.

* fix merge issues.

* PR Feedback

---------

Co-authored-by: Mark Plesko <markples@microsoft.com>
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
* Update dependencies from https://github.com/dotnet/emsdk build 20250419.2

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100
 From Version 8.0.16-servicing.25211.4 -> To Version 8.0.16-servicing.25219.2

* Update dependencies from https://github.com/dotnet/emsdk build 20250422.2

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100
 From Version 8.0.16-servicing.25211.4 -> To Version 8.0.16-servicing.25222.2

* Update dependencies from https://github.com/dotnet/emsdk build 20250423.2

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100
 From Version 8.0.16-servicing.25211.4 -> To Version 8.0.16-servicing.25223.2

* Update dependencies from https://github.com/dotnet/emsdk build 2025050.3

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100
 From Version 8.0.16-servicing.25211.4 -> To Version 8.0.16-servicing.25255.3

* Update dependencies from https://github.com/dotnet/emsdk build 20250508.1

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100
 From Version 8.0.16-servicing.25211.4 -> To Version 8.0.17-servicing.25258.1

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…ease/8.0-staging

[automated] Merge branch 'release/8.0' => 'release/8.0-staging'
…8.0-2025-05-13-1454

Merging internal commits for release/8.0
[manual] Merge release/8.0-staging into release/8.0
Co-authored-by: Oleksandr.Didyk <odidyk@microsoft.com>
…e now supporting multiple declarations. (dotnet#115077)

* Account for CompilationMappingAttribute supporting multiple declarations.

* Update package version

---------

Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
Co-authored-by: Maoni0 <maoni@microsoft.com>
akoeplinger and others added 15 commits December 4, 2025 15:30
…et#121389)

I detected changes in the release/8.0 branch which have not been merged
yet to release/8.0-staging. I'm a robot and am configured to help you
automatically keep release/8.0-staging up to date, so I've opened this
PR.

This PR merges commits made on release/8.0 by the following committers:

* vseanreesermsft
* dotnet-maestro[bot]

## Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete
this PR by creating a merge commit, *not* a squash or rebase commit.

<img alt="merge button instructions"
src="https://i.imgur.com/GepcNJV.png" width="300" />

If this repo does not allow creating merge commits from the GitHub UI,
use command line instructions.

## Instructions for merging via command line

Run these commands to merge this pull request from the command line.

``` sh
git fetch
git checkout release/8.0
git pull --ff-only
git checkout release/8.0-staging
git pull --ff-only
git merge --no-ff release/8.0

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet/runtime HEAD:merge/release/8.0-to-release/8.0-staging
```

<details>
<summary>or if you are using SSH</summary>

```
git push git@github.com:dotnet/runtime HEAD:merge/release/8.0-to-release/8.0-staging
```

</details>


After PR checks are complete push the branch
```
git push
```

## Instructions for resolving conflicts

:warning: If there are merge conflicts, you will need to resolve them
manually before merging. You can do this [using GitHub][resolve-github]
or using the [command line][resolve-cli].

[resolve-github]:
https://help.github.com/articles/resolving-a-merge-conflict-on-github/
[resolve-cli]:
https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

## Instructions for updating this pull request

Contributors to this repo have permission update this pull request by
pushing to the branch 'merge/release/8.0-to-release/8.0-staging'. This
can be done to resolve conflicts or make other changes to this pull
request before it is merged.
The provided examples assume that the remote is named 'origin'. If you
have a different remote name, please replace 'origin' with the name of
your remote.

```
git fetch
git checkout -b merge/release/8.0-to-release/8.0-staging origin/release/8.0-staging
git pull https://github.com/dotnet/runtime merge/release/8.0-to-release/8.0-staging
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet/runtime HEAD:merge/release/8.0-to-release/8.0-staging
```

<details>
    <summary>or if you are using SSH</summary>

```
git fetch
git checkout -b merge/release/8.0-to-release/8.0-staging origin/release/8.0-staging
git pull git@github.com:dotnet/runtime merge/release/8.0-to-release/8.0-staging
(make changes)
git commit -m "Updated PR with my changes"
git push git@github.com:dotnet/runtime HEAD:merge/release/8.0-to-release/8.0-staging
```

</details>

Contact .NET Core Engineering (dotnet/dnceng) if you have questions or
issues.
Also, if this PR was generated incorrectly, help us fix it. See
https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.
Related:

- dotnet#115415
- dotnet#115501
- dotnet#115503

---------

Co-authored-by: Art Leonard <artl93@users.noreply.github.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
Co-authored-by: Tomas Weinfurt <tweinfurt@yahoo.com>
Co-authored-by: yurai007 <dawid_jurek@vp.pl>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
)

This pull request updates the following dependencies

[marker]: <> (Begin:e82a8e07-8d2b-4a71-e90f-08dbcfd41ade)
## From https://github.com/dotnet/icu
- **Subscription**:
[e82a8e07-8d2b-4a71-e90f-08dbcfd41ade](https://maestro.dot.net/subscriptions?search=e82a8e07-8d2b-4a71-e90f-08dbcfd41ade)
- **Build**:
[20251212.3](https://dev.azure.com/dnceng/internal/_build/results?buildId=2859935)
([294543](https://maestro.dot.net/channel/3073/github:dotnet:icu/build/294543))
- **Date Produced**: December 12, 2025 8:16:11 PM UTC
- **Commit**:
[4bfba9f36e8667005d7a40ade385daabce5fc7d5](dotnet/icu@4bfba9f)
- **Branch**:
[dotnet/release/8.0](https://github.com/dotnet/icu/tree/dotnet/release/8.0)

[DependencyUpdate]: <> (Begin)

- **Dependency Updates**:
  - From [8.0.0-rtm.25565.1 to 8.0.0-rtm.25612.3][1]
     - Microsoft.NETCore.Runtime.ICU.Transport

[1]: dotnet/icu@b565264...4bfba9f

[DependencyUpdate]: <> (End)


[marker]: <> (End:e82a8e07-8d2b-4a71-e90f-08dbcfd41ade)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…dotnet#122731)

This pull request updates the following dependencies

[marker]: <> (Begin:c0fef358-3848-4a30-a438-08dbcfd61a5a)
## From https://github.com/dotnet/hotreload-utils
- **Subscription**:
[c0fef358-3848-4a30-a438-08dbcfd61a5a](https://maestro.dot.net/subscriptions?search=c0fef358-3848-4a30-a438-08dbcfd61a5a)
- **Build**:
[20251225.3](https://dev.azure.com/dnceng/internal/_build/results?buildId=2867020)
([295569](https://maestro.dot.net/channel/3073/github:dotnet:hotreload-utils/build/295569))
- **Date Produced**: December 25, 2025 11:22:01 AM UTC
- **Commit**:
[e7e99065bbd4a7b911d5cfa56b23d873d9675355](dotnet/hotreload-utils@e7e9906)
- **Branch**:
[release/8.0](https://github.com/dotnet/hotreload-utils/tree/release/8.0)

[DependencyUpdate]: <> (Begin)

- **Dependency Updates**:
  - From [8.0.0-alpha.0.25574.3 to 8.0.0-alpha.0.25625.3][1]
     - Microsoft.DotNet.HotReload.Utils.Generator.BuildTool

[1]:
dotnet/hotreload-utils@cf2f6ad...e7e9906

[DependencyUpdate]: <> (End)


[marker]: <> (End:c0fef358-3848-4a30-a438-08dbcfd61a5a)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…otnet#122735)

This pull request updates the following dependencies

[marker]: <> (Begin:855db5a2-4d17-4346-a439-08dbcfd61a5a)
## From https://github.com/dotnet/runtime-assets
- **Subscription**:
[855db5a2-4d17-4346-a439-08dbcfd61a5a](https://maestro.dot.net/subscriptions?search=855db5a2-4d17-4346-a439-08dbcfd61a5a)
- **Build**:
[20251225.3](https://dev.azure.com/dnceng/internal/_build/results?buildId=2867033)
([295573](https://maestro.dot.net/channel/3073/github:dotnet:runtime-assets/build/295573))
- **Date Produced**: December 25, 2025 11:52:55 AM UTC
- **Commit**:
[98185bc6d28f41decb681555c343a62b3c6c165e](dotnet/runtime-assets@98185bc)
- **Branch**:
[release/8.0](https://github.com/dotnet/runtime-assets/tree/release/8.0)

[DependencyUpdate]: <> (Begin)

- **Dependency Updates**:
  - From [8.0.0-beta.25565.1 to 8.0.0-beta.25625.3][1]
     - Microsoft.DotNet.CilStrip.Sources
     - System.ComponentModel.TypeConverter.TestData
     - System.Data.Common.TestData
     - System.Drawing.Common.TestData
     - System.Formats.Tar.TestData
     - System.IO.Compression.TestData
     - System.IO.Packaging.TestData
     - System.Net.TestData
     - System.Private.Runtime.UnicodeData
     - System.Runtime.Numerics.TestData
     - System.Runtime.TimeZoneData
     - System.Security.Cryptography.X509Certificates.TestData
     - System.Text.RegularExpressions.TestData
     - System.Windows.Extensions.TestData

[1]:
dotnet/runtime-assets@40ac8f2...98185bc

[DependencyUpdate]: <> (End)


[marker]: <> (End:855db5a2-4d17-4346-a439-08dbcfd61a5a)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
)

This pull request updates the following dependencies

[marker]: <> (Begin:e82a8e07-8d2b-4a71-e90f-08dbcfd41ade)
## From https://github.com/dotnet/icu
- **Subscription**:
[e82a8e07-8d2b-4a71-e90f-08dbcfd41ade](https://maestro.dot.net/subscriptions?search=e82a8e07-8d2b-4a71-e90f-08dbcfd41ade)
- **Build**:
[20251225.2](https://dev.azure.com/dnceng/internal/_build/results?buildId=2867037)
([295579](https://maestro.dot.net/channel/3073/github:dotnet:icu/build/295579))
- **Date Produced**: December 25, 2025 12:12:34 PM UTC
- **Commit**:
[7e1e01ce174204fc50e1b221c59cbd2c7a752441](dotnet/icu@7e1e01c)
- **Branch**:
[dotnet/release/8.0](https://github.com/dotnet/icu/tree/dotnet/release/8.0)

[DependencyUpdate]: <> (Begin)

- **Dependency Updates**:
  - From [8.0.0-rtm.25612.3 to 8.0.0-rtm.25625.2][1]
     - Microsoft.NETCore.Runtime.ICU.Transport

[1]: dotnet/icu@4bfba9f...7e1e01c

[DependencyUpdate]: <> (End)


[marker]: <> (End:e82a8e07-8d2b-4a71-e90f-08dbcfd41ade)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…dotnet#122654)

Fixes: dotnet#122653

`libopenssl3` is supported and installed by default on all of the
supported distro releases listed at
https://learn.microsoft.com/en-us/dotnet/core/install/linux-sles?tabs=dotnet8
and
https://learn.microsoft.com/en-us/dotnet/core/install/linux-opensuse?tabs=dotnet8

`libopenssl3` is also supported and installed by default on openSUSE
Tumbleweed release. This release does not have any other, older, version
of this library.
…ine YAML files (dotnet#122417)

Adds `fetchTags: false` to Azure Pipelines checkout steps to skip
fetching git tags during repository checkout, reducing network overhead
and improving checkout performance.

## Changes

- Updated 8 YAML files containing 10 total checkout steps in
`eng/pipelines/`:
  - Pipeline templates: `base-job.yml`, `xplat-job.yml`, `build-job.yml`
  - Stress test pipelines: `http.yml`, `ssl.yml` (2 occurrences each)
- Path evaluation and build jobs: `evaluate-paths-job.yml`,
`global-build-job.yml`
  - Official build jobs: `prepare-signed-artifacts.yml`

Note: Changes to `eng/common/` templates were excluded as those are
shared infrastructure files managed separately.

## Example

```yaml
- checkout: self
  clean: true
  fetchDepth: $(checkoutFetchDepth)
  fetchTags: false  # Added to skip tag fetching
```

<!-- START COPILOT CODING AGENT SUFFIX -->



<!-- START COPILOT ORIGINAL PROMPT -->



<details>

<summary>Original prompt</summary>

> Update the checkout step in the runtime CI yml to specify fetchTags:
false.


</details>



<!-- START COPILOT CODING AGENT TIPS -->
---

✨ Let Copilot coding agent [set things up for
you](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot)
— coding agent works faster and does higher quality work when set up for
your repo.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>
Co-authored-by: Elinor Fung <elfung@microsoft.com>
…122199)

Backport of dotnet#121351 to
release/8.0-staging

## Customer Impact

Fixes a customer-reported crash in ILLink analyzer in a net8.0 project
that uses C# 14 extension members.
Customer issue: dotnet#120728

```
warning AD0001: Analyzer 'ILLink.RoslynAnalyzer.DynamicallyAccessedMembersAnalyzer' threw an exception of type 'System.InvalidCastException' with message 'Unable to cast object of type 'Microsoft.CodeAnalysis.CSharp.Symbols.PublicModel.NonErrorNamedTypeSymbol' to type 'Microsoft.CodeAnalysis.IMethodSymbol'.'.
```

## Regression

No - crash only happens for language features introduced after .NET 8
was released.

## Testing

Tested locally. We can't add automated testing because this repo doesn't
reference a new enough version of Roslyn to build tests with extension
members.

## Risk

Low, analyzer-only fix, with limited scope.

<hr />

Fixes dotnet#120728

main PR dotnet#121351

# Description

Backports fix for analyzer crash when encountering C# 14 extension
members. The crash occurred because the analyzer assumed
`parameter.ContainingSymbol` is always `IMethodSymbol`, which is false
for extension member parameters where the container is an extension
type.

**Core analyzer changes:**
- Remove `MethodParameterValue` constructors that cast
`parameter.ContainingSymbol` to `IMethodSymbol`
- Require explicit `IMethodSymbol` parameter in `ParameterProxy`
constructor
- Skip analysis for extension members in `GetParameterTargetValue`
(return `TopValue` when `ContainingSymbol` is not `IMethodSymbol`)
- Update `VisitInstanceReference` to use new `ParameterProxy`
constructor (without unrelated static method checks)

**Test infrastructure:**
- Add `Microsoft.Net.Compilers.Toolset` package reference for C# preview
features
- Add workaround in `ResultChecker.cs` to skip validation of
compiler-generated extension member types (`<>E__` prefix)
- Add `ExtensionsDataFlow.cs` test (enabled)
- Add `ExtensionMembersDataFlow.cs` test (disabled until C# 14
available)

**Note:** NativeAOT test changes from original PR excluded as
`ILCompiler.Trimming.Tests` doesn't exist in 8.0.

# Customer Impact

Without this fix, the Roslyn analyzer crashes when analyzing code that
uses or references C# 14 extension members, breaking the build or IDE
experience.

# Regression

No. This is a new feature compatibility fix for C# 14, not a regression
from 8.0 functionality.

# Testing

- All 60 DataFlow analyzer tests pass
- New `ExtensionsDataFlow` test validates fix for regular extension
methods
- ILLink.RoslynAnalyzer builds cleanly

# Risk

Low. Changes are surgical and isolated to extension member handling:
- Early-exit paths for extension members prevent processing unsupported
constructs
- Existing code paths unchanged (all parameters with method containers
work as before)
- Test coverage validates no regressions in standard scenarios

# Package authoring signed off?

N/A - Changes are internal to analyzer implementation, no public API
surface modified.

<!-- START COPILOT CODING AGENT SUFFIX -->



<details>

<summary>Original prompt</summary>

> Backport dotnet#121351 to
release/8.0-staging.


</details>



<!-- START COPILOT CODING AGENT TIPS -->
---

💬 We'd love your input! Share your thoughts on Copilot coding agent in
our [2 minute survey](https://gh.io/copilot-coding-agent-survey).

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
…otnet#120589) (dotnet#122423)

(cherry picked from commit eaafd7c)
(cherry picked from commit 1905046)

---------

Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: Matous Kozak <matouskozak@seznam.cz>
Co-authored-by: Steve Pfister <stpfiste@microsoft.com>
Co-authored-by: Filip Navara <filip.navara@gmail.com>
…ference-packages (dotnet#123243)

This pull request updates the following dependencies

[marker]: <> (Begin:1626bff2-6010-444e-f998-08dbcfd3e5b0)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**:
[1626bff2-6010-444e-f998-08dbcfd3e5b0](https://maestro.dot.net/subscriptions?search=1626bff2-6010-444e-f998-08dbcfd3e5b0)
- **Build**:
[20251215.3](https://dev.azure.com/dnceng/internal/_build/results?buildId=2861480)
([294695](https://maestro.dot.net/channel/3885/github:dotnet:source-build-reference-packages/build/294695))
- **Date Produced**: December 15, 2025 3:29:24 PM UTC
- **Commit**:
[44b5b62182b48c34c4b6aef28943ec3f3e82f214](dotnet/source-build-reference-packages@44b5b62)
- **Branch**:
[release/8.0](https://github.com/dotnet/source-build-reference-packages/tree/release/8.0)

[DependencyUpdate]: <> (Begin)

- **Dependency Updates**:
  - From [8.0.0-alpha.1.25522.3 to 8.0.0-alpha.1.25615.3][1]
- Microsoft.SourceBuild.Intermediate.source-build-reference-packages

[1]:
dotnet/source-build-reference-packages@4491483...44b5b62

[DependencyUpdate]: <> (End)


[marker]: <> (End:1626bff2-6010-444e-f998-08dbcfd3e5b0)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@jkotas
Copy link
Member

jkotas commented Jan 22, 2026

I am wondering what the public API name for this would look. I would not be bet on the public API being called IsSingleThreaded.

Was there ever a discussion about exposing this as a public API? Should we have one? It may be best to get an API proposal going, and then rename everything to match the name of public API that we agree on.

}

[Fact]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotSingleThreaded))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this one intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally this was just merge conflict, but I was thinking that Stream.CopyTo could be blocking.

@akoeplinger
Copy link
Member

there's also the internal Environment.IsSingleProcessor that is used for the same purpose

@jkotas
Copy link
Member

jkotas commented Jan 22, 2026

Environment.IsSingleProcessor that is used for the same purpose

IsSingleProcessor is different from IsSingleThread/IsThreadingSupported. You can have multiple threads with IsSingleProcessor.

@akoeplinger
Copy link
Member

akoeplinger commented Jan 22, 2026

@jkotas I vaguely remembered that it was used the same way, but I haven't checked deeply. I agree it is not a good name for this use case.

I just found #77541 which was an API suggestion for Thread.IsThreadStartSupported

@pavelsavara pavelsavara force-pushed the rename_IsThreadingSupported branch from cfaf714 to be56e6f Compare January 23, 2026 11:37
@pavelsavara
Copy link
Member Author

I screwed this branch, closing, sorry

@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Threading linkable-framework Issues associated with delivering a linker friendly framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.