Skip to content

Conversation

@MichalStrehovsky
Copy link
Member

These are all crashing:

11:31:58.741 Running test: tracing/userevents/custommetadata/custommetadata/custommetadata.cmd
Unhandled exception. System.ArgumentNullException: Value cannot be null. (Parameter 'path1')
   at System.ArgumentNullException.Throw(String)
   at System.IO.Path.Combine(String, String, String)
   at Tracing.UserEvents.Tests.Common.UserEventsTestRunner.ResolveRecordTracePath(String)
   at Tracing.UserEvents.Tests.Common.UserEventsTestRunner.RunOrchestrator(String, String, Func`2, Int32, Int32)
   at Tracing.UserEvents.Tests.CustomMetadata.CustomMetadata.Main(String[] args)

These are all crashing:

```
11:31:58.741 Running test: tracing/userevents/custommetadata/custommetadata/custommetadata.cmd
Unhandled exception. System.ArgumentNullException: Value cannot be null. (Parameter 'path1')
   at System.ArgumentNullException.Throw(String)
   at System.IO.Path.Combine(String, String, String)
   at Tracing.UserEvents.Tests.Common.UserEventsTestRunner.ResolveRecordTracePath(String)
   at Tracing.UserEvents.Tests.Common.UserEventsTestRunner.RunOrchestrator(String, String, Func`2, Int32, Int32)
   at Tracing.UserEvents.Tests.CustomMetadata.CustomMetadata.Main(String[] args)
```
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR marks all user events tests under src/tests/tracing/userevents/ as incompatible with Native AOT by adding a Directory.Build.props file that sets NativeAotIncompatible=true.

Changes:

  • Added a Directory.Build.props file to disable Native AOT testing for all user events tests

@jkotas
Copy link
Member

jkotas commented Jan 23, 2026

Should we have an issue to get this fixed?

Copy link
Member

@mdh1418 mdh1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm guessing that passing around paths like typeof(CustomMetadata).Assembly.Location doesn't work on NativeAOT?

@MichalStrehovsky
Copy link
Member Author

Thanks, I'm guessing that passing around paths like typeof(CustomMetadata).Assembly.Location doesn't work on NativeAOT?

Yes, Assembly.Location doesn't work in single file form factors because the assembly doesn't exist anymore. AppContext.BaseDirectory works.

@MichalStrehovsky MichalStrehovsky merged commit 9f1fdb4 into main Jan 23, 2026
90 checks passed
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-3 branch January 23, 2026 21:42
Copilot AI pushed a commit that referenced this pull request Jan 23, 2026
These are all crashing:

```
11:31:58.741 Running test: tracing/userevents/custommetadata/custommetadata/custommetadata.cmd
Unhandled exception. System.ArgumentNullException: Value cannot be null. (Parameter 'path1')
   at System.ArgumentNullException.Throw(String)
   at System.IO.Path.Combine(String, String, String)
   at Tracing.UserEvents.Tests.Common.UserEventsTestRunner.ResolveRecordTracePath(String)
   at Tracing.UserEvents.Tests.Common.UserEventsTestRunner.RunOrchestrator(String, String, Func`2, Int32, Int32)
   at Tracing.UserEvents.Tests.CustomMetadata.CustomMetadata.Main(String[] args)
```
Copilot AI added a commit that referenced this pull request Jan 23, 2026
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants