-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Mark new userevents tests as native AOT incompatible #123541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These are all crashing: ``` 11:31:58.741 Running test: tracing/userevents/custommetadata/custommetadata/custommetadata.cmd Unhandled exception. System.ArgumentNullException: Value cannot be null. (Parameter 'path1') at System.ArgumentNullException.Throw(String) at System.IO.Path.Combine(String, String, String) at Tracing.UserEvents.Tests.Common.UserEventsTestRunner.ResolveRecordTracePath(String) at Tracing.UserEvents.Tests.Common.UserEventsTestRunner.RunOrchestrator(String, String, Func`2, Int32, Int32) at Tracing.UserEvents.Tests.CustomMetadata.CustomMetadata.Main(String[] args) ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR marks all user events tests under src/tests/tracing/userevents/ as incompatible with Native AOT by adding a Directory.Build.props file that sets NativeAotIncompatible=true.
Changes:
- Added a Directory.Build.props file to disable Native AOT testing for all user events tests
|
Should we have an issue to get this fixed? |
mdh1418
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'm guessing that passing around paths like typeof(CustomMetadata).Assembly.Location doesn't work on NativeAOT?
Yes, Assembly.Location doesn't work in single file form factors because the assembly doesn't exist anymore. AppContext.BaseDirectory works. |
These are all crashing: ``` 11:31:58.741 Running test: tracing/userevents/custommetadata/custommetadata/custommetadata.cmd Unhandled exception. System.ArgumentNullException: Value cannot be null. (Parameter 'path1') at System.ArgumentNullException.Throw(String) at System.IO.Path.Combine(String, String, String) at Tracing.UserEvents.Tests.Common.UserEventsTestRunner.ResolveRecordTracePath(String) at Tracing.UserEvents.Tests.Common.UserEventsTestRunner.RunOrchestrator(String, String, Func`2, Int32, Int32) at Tracing.UserEvents.Tests.CustomMetadata.CustomMetadata.Main(String[] args) ```
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
These are all crashing: