-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Update native AOT ActiveIssue on NegotiateAuthenticationTests #123528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I originally saw crashes in Package_Unsupported_NTLM, but looks like everything crashes. So just disable on Linux in general. This time I'll run outerloop to verify :(
|
/azp run runtime-nativeaot-outerloop |
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the ActiveIssue attribute for NegotiateAuthenticationTests to skip all tests in the class on Native AOT + Linux, rather than just skipping a single test. The author discovered that the crashes were not limited to just the Package_Unsupported_NTLM test, but affect the entire test suite.
Changes:
- Moved ActiveIssue from specific test method to the entire test class
- Broadened the platform condition from just NativeAot to NativeAot AND Linux
- Removed the previous method-level ActiveIssue attribute
|
I think we should disable the tests only on the affected OSes, from what I can see from the Kusto DB, the crashes are on Ubuntu 26, likely due to a buggy gss-ntlmssp on the system, we have seen the same on Ubuntu 24 I believe: #113414 . According to https://launchpad.net/ubuntu/resolute/+source/gss-ntlmssp, Ubuntu 26 still uses the buggy 1.2.0 version as Ubuntu 24 |
AFAIK there's no native AOT specific logic in these codepaths. So the only test coverage we're losing is "random code hits a random bug in native AOT" (i.e. we're looking for native AOT runtime/compiler bugs, not System.Net.Security bugs since those are covered with CoreCLR-JIT). I'm fine losing this small piece of native AOT coverage if it means I will not have to come back to this and tweak the list before #123472 is fixed. I don't think anyone from dotnet/ncl monitors native AOT outerloops because I always have to do this myself and this is just one of the many many many many many many issues that showed up in native AOT outerloops just in the last two weeks. |
|
/ba-g native AOT outerloops known to be broken |
I originally saw crashes in Package_Unsupported_NTLM, but looks like everything crashes. So just disable on Linux in general. This time I'll actually run outerloop to verify :(