-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Disable generic recursion test on native AOT #123480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test started running with #123112 This is past our cutoff so the method body gets compiled to `TypeLoadException`. We have generic recursion coverage in native AOT tests. Cc @dotnet/ilc-contrib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR disables a generic recursion test on native AOT by replacing [Fact] with [ConditionalFact(typeof(TestLibrary.Utilities), nameof(TestLibrary.Utilities.IsNotNativeAot))]. The test began running after PR #123112, which is past the cutoff for native AOT support. The method body compiles to TypeLoadException on native AOT, and generic recursion coverage already exists in native AOT tests.
Changes:
- Modified test attribute to conditionally skip the test on native AOT platforms
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
|
/ba-g native AOT outerloop is known to be broken |
Test started running with #123112
This is past our cutoff so the method body gets compiled to
TypeLoadException. We have generic recursion coverage in native AOT tests.Cc @dotnet/ilc-contrib