Skip to content

Conversation

@MichalStrehovsky
Copy link
Member

Test started running with #123112

This is past our cutoff so the method body gets compiled to TypeLoadException. We have generic recursion coverage in native AOT tests.

Cc @dotnet/ilc-contrib

Test started running with #123112

This is past our cutoff so the method body gets compiled to `TypeLoadException`. We have generic recursion coverage in native AOT tests.

Cc @dotnet/ilc-contrib
Copilot AI review requested due to automatic review settings January 22, 2026 08:28
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 22, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables a generic recursion test on native AOT by replacing [Fact] with [ConditionalFact(typeof(TestLibrary.Utilities), nameof(TestLibrary.Utilities.IsNotNativeAot))]. The test began running after PR #123112, which is past the cutoff for native AOT support. The method body compiles to TypeLoadException on native AOT, and generic recursion coverage already exists in native AOT tests.

Changes:

  • Modified test attribute to conditionally skip the test on native AOT platforms

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-nativeaot-outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas jkotas added area-NativeAOT-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jan 22, 2026
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

@MichalStrehovsky
Copy link
Member Author

/ba-g native AOT outerloop is known to be broken

@MichalStrehovsky MichalStrehovsky merged commit 54b6fe3 into main Jan 22, 2026
91 of 104 checks passed
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-3 branch January 22, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants