Restore correct outerloop priority tracking and test execution #123112

jkoritzinsky · 2026-01-13T01:03:23Z

When this was originally written, we set a Priority property based on the __Priority environment variable for the generator as well as CLRTestPriorityToBuild for the overall build.

At some point, we lost this. As a result, we have been missing test coverage in our outerloops.

This restores the correct outerloop test execution behavior by unifying on CLRTestPriorityToBuild.

When this was originally written, we set a Priority property based on the __Priority environment variable as well as CLRTestPriorityToBuild. At some point, we lost this. As a result, we have been missing test coverage in our outerloops. This restores the correct outerloop test execution behavior.

jkoritzinsky · 2026-01-13T01:03:34Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2026-01-13T01:03:50Z

Azure Pipelines successfully started running 1 pipeline(s).

jkoritzinsky · 2026-01-13T01:04:56Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2026-01-13T01:05:08Z

Azure Pipelines successfully started running 1 pipeline(s).

jkoritzinsky · 2026-01-13T01:10:00Z

Optimistically marking as auto-merge. Since BA tracks the outerloop pipeline, that will get this in faster if we don't have any regressions (which I think is likely).

Copilot

Pull request overview

This PR restores correct outerloop test execution by fixing the priority tracking mechanism in the XUnit wrapper generator. The original implementation used a generic Priority property that was lost at some point, causing outerloop tests to not execute properly. This change unifies on the CLRTestPriorityToBuild property, which is the established MSBuild property used throughout the test infrastructure.

Changes:

Replaced the Priority compiler-visible property with CLRTestPriorityToBuild to align with the MSBuild property name
Updated the helper method from Priority() to CLRTestPriorityToBuild() to match the new property name
Fixed outerloop test filtering logic to use the correct property

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/tests/Common/XUnitWrapperGenerator/XUnitWrapperGenerator.props	Updated compiler-visible property from `Priority` to `CLRTestPriorityToBuild`
src/tests/Common/XUnitWrapperGenerator/XUnitWrapperGenerator.cs	Updated outerloop attribute filtering to check `CLRTestPriorityToBuild()` instead of `Priority()`
src/tests/Common/XUnitWrapperGenerator/OptionsHelper.cs	Renamed constant and helper method from `Priority` to `CLRTestPriorityToBuild` to match the MSBuild property

jkoritzinsky · 2026-01-13T18:24:24Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2026-01-13T18:25:01Z

Azure Pipelines successfully started running 1 pipeline(s).

jkoritzinsky · 2026-01-13T18:27:13Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2026-01-13T18:27:26Z

Azure Pipelines successfully started running 1 pipeline(s).

jkoritzinsky · 2026-01-13T19:42:08Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2026-01-13T19:42:20Z

Azure Pipelines successfully started running 1 pipeline(s).

jkoritzinsky · 2026-01-14T18:59:13Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2026-01-14T18:59:25Z

Azure Pipelines successfully started running 1 pipeline(s).

jkoritzinsky · 2026-01-14T23:55:23Z

/ba-g failure is #123195

#123112 started running more outerloop tests, including: https://github.com/dotnet/runtime/blob/81e28e28a7dd0c5109f8a3c0e458d3de577e78f8/src/tests/JIT/Methodical/flowgraph/dev10_bug679008/sealedCastVariance.cs#L13-L32 We were incorrectly optimizing the `a.GetType() == typeof(Action<object>)` check to `false` (type of the parameter is `Action<string>` and JIT was asking for exact classes of `Action<string>`; and there are none).

Test started running with #123112

Test started running with #123112 This is past our cutoff so the method body gets compiled to `TypeLoadException`. We have generic recursion coverage in native AOT tests. Cc @dotnet/ilc-contrib

…#123479) Test started running with #123112 Cc @dotnet/ilc-contrib

@EgorBo

#123112 started running more outerloop tests, including: https://github.com/dotnet/runtime/blob/81e28e28a7dd0c5109f8a3c0e458d3de577e78f8/src/tests/JIT/Methodical/flowgraph/dev10_bug679008/sealedCastVariance.cs#L13-L32 We were incorrectly optimizing the `a.GetType() == typeof(Action<object>)` check to `false` (type of the parameter is `Action<string>` and JIT was asking for exact classes of `Action<string>`; and there are none). Cc @dotnet/ilc-contrib @EgorBo

Test started running with #123112 This is past our cutoff so the method body gets compiled to `TypeLoadException`. We have generic recursion coverage in native AOT tests.

Test started running with #123112 Cc @dotnet/ilc-contrib

These were all enabled in dotnet#123112

These were all enabled in #123112

Copilot AI review requested due to automatic review settings January 13, 2026 01:03

jkoritzinsky added the area-Infrastructure label Jan 13, 2026

github-project-automation bot added this to Runtime Infra Jan 13, 2026

dotnet-policy-service bot assigned jkoritzinsky Jan 13, 2026

github-project-automation bot added this to AppModel Jan 13, 2026

Copilot started reviewing on behalf of jkoritzinsky January 13, 2026 01:04 View session

jeffhandley approved these changes Jan 13, 2026

View reviewed changes

hoyosjs approved these changes Jan 13, 2026

View reviewed changes

Copilot AI reviewed Jan 13, 2026

View reviewed changes

jakobbotsch approved these changes Jan 13, 2026

View reviewed changes

Add missing project reference.

73058f7

jkoritzinsky enabled auto-merge (squash) January 13, 2026 18:24

Add another test library project reference

81e071f

build-analysis bot mentioned this pull request Jan 13, 2026

Unable to pull image from mcr.microsoft.com #117164

Open

Fix various test failures

051aa2b

jkoritzinsky mentioned this pull request Jan 14, 2026

exception_handling/pal_sxs/test1/paltest_pal_sxs_test1 failure on mac os arm64 #123195

Closed

jkoritzinsky merged commit d120108 into dotnet:main Jan 14, 2026
127 of 129 checks passed

github-project-automation bot moved this to Done in Runtime Infra Jan 14, 2026

github-project-automation bot moved this to Done in AppModel Jan 14, 2026

jkoritzinsky deleted the restore-outerloop branch January 15, 2026 00:00

dotnet-maestro bot mentioned this pull request Jan 15, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#4220

Merged

MichalStrehovsky mentioned this pull request Jan 22, 2026

Be careful about getExactClasses of variant types #123476

Merged

MichalStrehovsky added a commit that referenced this pull request Jan 22, 2026

Change Fact to ConditionalFact in bug_445388.cs

4adf46a

Test started running with #123112

MichalStrehovsky mentioned this pull request Jan 22, 2026

Change Fact to ConditionalFact(RefEmitSupported) in bug_445388.cs #123479

Merged

MichalStrehovsky mentioned this pull request Jan 22, 2026

Disable generic recursion test on native AOT #123480

Merged

MichalStrehovsky added a commit that referenced this pull request Jan 22, 2026

Change Fact to ConditionalFact(RefEmitSupported) in bug_445388.cs (…

a035ab7

…#123479) Test started running with #123112 Cc @dotnet/ilc-contrib

MichalStrehovsky added a commit that referenced this pull request Jan 23, 2026

Disable StringBuilder marshalling tests on native AOT

0830c2f

Test started running with #123112 Cc @dotnet/ilc-contrib

MichalStrehovsky mentioned this pull request Jan 23, 2026

Disable StringBuilder marshalling tests on native AOT #123530

Merged

MichalStrehovsky added a commit that referenced this pull request Jan 23, 2026

Disable StringBuilder marshalling tests on native AOT (#123530)

c1b9b97

Test started running with #123112 Cc @dotnet/ilc-contrib

Copilot AI pushed a commit that referenced this pull request Jan 23, 2026

Disable StringBuilder marshalling tests on native AOT (#123530)

22d341a

Test started running with #123112 Cc @dotnet/ilc-contrib

MichalStrehovsky added a commit to MichalStrehovsky/runtime that referenced this pull request Jan 28, 2026

Baseline tests to fix native AOT outerloops

d4c7856

These were all enabled in dotnet#123112

MichalStrehovsky mentioned this pull request Jan 28, 2026

Baseline tests to fix native AOT outerloops #123722

Merged

MichalStrehovsky added a commit that referenced this pull request Jan 29, 2026

Baseline tests to fix native AOT outerloops (#123722)

c8aca8b

These were all enabled in #123112

Restore correct outerloop priority tracking and test execution #123112

Restore correct outerloop priority tracking and test execution #123112

Uh oh!

Conversation

jkoritzinsky commented Jan 13, 2026

Uh oh!

jkoritzinsky commented Jan 13, 2026

Uh oh!

azure-pipelines bot commented Jan 13, 2026

Uh oh!

jkoritzinsky commented Jan 13, 2026

Uh oh!

azure-pipelines bot commented Jan 13, 2026

Uh oh!

jkoritzinsky commented Jan 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

jkoritzinsky commented Jan 13, 2026

Uh oh!

azure-pipelines bot commented Jan 13, 2026

Uh oh!

jkoritzinsky commented Jan 13, 2026

Uh oh!

azure-pipelines bot commented Jan 13, 2026

Uh oh!

jkoritzinsky commented Jan 13, 2026

Uh oh!

azure-pipelines bot commented Jan 13, 2026

Uh oh!

jkoritzinsky commented Jan 14, 2026

Uh oh!

azure-pipelines bot commented Jan 14, 2026

Uh oh!

jkoritzinsky commented Jan 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants