Baseline tests to fix native AOT outerloops #123722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were all enabled in dotnet#123112
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates existing test coverage and infrastructure helpers to account for NativeAOT outerloop execution differences, primarily by skipping/guarding specific tests that currently fail under NativeAOT.
Changes:
- Added
ActiveIssue-based skips for specific JIT outerloop tests under NativeAOT (and NativeAOT+32-bit). - Guarded failing UTF8 StringBuilder marshalling sub-tests when running under NativeAOT.
- Added
TestLibrary.Utilities.Is32helper for 32-bit process detection used by conditional test attributes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/tests/JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b399444/Repro.cs | Skips the test for NativeAOT via ActiveIssue. |
| src/tests/JIT/Methodical/jitinterface/bug603649.cs | Skips the test for NativeAOT 32-bit via ActiveIssue + new Is32 helper. |
| src/tests/Interop/StringMarshalling/UTF8/UTF8Test.cs | Disables known-failing StringBuilder marshalling checks under NativeAOT (linked issue). |
| src/tests/Common/CoreCLRTestLibrary/Utilities.cs | Adds Is32 helper to support conditional skipping logic. |
jkotas
approved these changes
Jan 28, 2026
jkoritzinsky
approved these changes
Jan 28, 2026
Member
Author
|
/ba-g arm64 infra seems to be overloaded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were all enabled in #123112