Be careful about getExactClasses of variant types #123476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#123112 started running more outerloop tests, including:
runtime/src/tests/JIT/Methodical/flowgraph/dev10_bug679008/sealedCastVariance.cs
Lines 13 to 32 in 81e28e2
We were incorrectly optimizing the
a.GetType() == typeof(Action<object>)check tofalse(type of the parameter isAction<string>and JIT was asking for exact classes ofAction<string>; and there are none).Cc @dotnet/ilc-contrib @EgorBo