Fix flaky MaxResponseHeadersLength tests by handling additional SocketError codes#124517
Merged
Fix flaky MaxResponseHeadersLength tests by handling additional SocketError codes#124517
Conversation
…and ConnectionAborted Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
MihaZupan
approved these changes
Feb 17, 2026
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.MaxResponseHeadersLength.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.MaxResponseHeadersLength.cs
Outdated
Show resolved
Hide resolved
Copilot
AI
changed the title
[WIP] Fix threshold exceeded exception in HTTP tests
Fix flaky MaxResponseHeadersLength tests by handling additional SocketError codes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
ThresholdExceeded_ThrowsExceptionandLargeSingleHeader_ThrowsExceptiontests were flaking when the client forcibly closed the connection after detecting excessive response headers, but before the server finished writing. The server-side loopback only handledSocketError.Shutdown, missingConnectionResetandConnectionAbortedwhich manifest on different platforms/timings for the same race condition.Changes
Extended exception filters in both test methods to catch all three expected
SocketErrorcodes:This aligns with the existing pattern in
LoopbackProxyServer.cswhich already handles bothConnectionResetandConnectionAbortedtogether.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.