Skip to content

Fix flaky MaxResponseHeadersLength tests by handling additional SocketError codes #124517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MihaZupan merged 3 commits into from
Feb 17, 2026
Merged

Fix flaky MaxResponseHeadersLength tests by handling additional SocketError codes #124517

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b4b548
Initial plan
Copilot Feb 17, 2026
de2c9d8
Fix ThresholdExceeded_ThrowsException test to handle ConnectionReset …
Copilot Feb 17, 2026
ca99a1e
Use pattern matching
MihaZupan Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.MaxResponseHeadersLength.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
await connection.SendResponseAsync(headers: new[] { new HttpHeaderData("Foo", new string('a', handler.MaxResponseHeadersLength * 1024)) });
}
// Client can respond by closing/aborting the underlying stream while we are still sending the headers, ignore these exceptions
catch (IOException ex) when (ex.InnerException is SocketException se && se.SocketErrorCode == SocketError.Shutdown) { }
catch (IOException ex) when (ex.InnerException is SocketException se && se.SocketErrorCode is SocketError.Shutdown or SocketError.ConnectionReset or SocketError.ConnectionAborted) { }
#if !WINHTTPHANDLER_TEST
catch (QuicException ex) when (ex.QuicError == QuicError.StreamAborted && ex.ApplicationErrorCode == Http3ExcessiveLoad) { }
#endif
Expand Down Expand Up @@ -165,7 +165,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
await connection.SendResponseAsync(headers: headers);
}
// Client can respond by closing/aborting the underlying stream while we are still sending the headers, ignore these exceptions
catch (IOException ex) when (ex.InnerException is SocketException se && se.SocketErrorCode == SocketError.Shutdown) { }
catch (IOException ex) when (ex.InnerException is SocketException se && se.SocketErrorCode is SocketError.Shutdown or SocketError.ConnectionReset or SocketError.ConnectionAborted) { }
#if !WINHTTPHANDLER_TEST
catch (QuicException ex) when (ex.QuicError == QuicError.StreamAborted && ex.ApplicationErrorCode == Http3ExcessiveLoad) {}
#endif
Expand Down
Loading