Move Internal.Console to shared CoreLib & port to Unix #42983
Conversation
|
Tagging subscribers to this area: @maryamariyan |
|
You should be also able to delete GetStdHandle and WriteFile from src\coreclr\src\vm\ecalllist.h. |
|
Tagging subscribers to this area: @eiriktsarpalis, @jeffhandley |
FWIW, it is available on CoreCLR/Unix too, but it depends on Win32 PAL. This PR makes it cleaner and simpler. |
|
Note that this is not a public API. It is an internal aid for printf-style debugging used frequently by the runtime engineers to debug low-level problems in CoreLib and in the VM. |
There was a problem hiding this comment.
As part of this, you'll have to remove the existing minimal Mono implementation.
Also worth noting: this will not work on Android. I don't think that's a problem, and if we want it to work there later I can always add the necessary code to SystemNative_Log.
Lastly, thanks a bunch! Looks good to me from the Mono side, and having proper support for this should be a nice improvement 😊
MichalStrehovsky
requested review from
akoeplinger,
EgorBo,
marek-safar,
steveisok and
vargaz
as code owners
src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems
Outdated
Show resolved
Hide resolved
| @@ -104,7 +104,6 @@ | |||
|
|
|||
| <!-- Sources --> | |||
| <ItemGroup> | |||
| <Compile Include="$(BclSourcesRoot)\Internal\Console.cs" /> | |||
There was a problem hiding this comment.
Delete <Compile Include="$(CommonPath)Interop\Windows\Kernel32\Interop.GetStdHandle.cs"> and friends in this file, and them to the Windows-specific section of the shared CoreLib project instead.
This reverts commit 4da9aad.
| void SystemNative_Log(uint8_t* buffer, int32_t length) | ||
| { | ||
| fwrite(buffer, 1, (size_t)length, stdout); | ||
| } |
There was a problem hiding this comment.
It might be useful to flush stdout here. Otherwise log messages might not show up on crashes etc.
ghost
locked as resolved and limited conversation to collaborators
Internal.Consoleis a helper class to print stuff out of CoreLib where System.Console is unavailable.Internal.Consolewas only available on CoreCLR/Windows, but I needed it for Linux, hence this pull request.