Add Internal.Console #112
Closed
Add Internal.Console #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same Internal.Console that CoreCLR has, but extended with Unix support. Is there any appetite to have this, potentially in the shared partition? As I was debugging the timer/threadpool issue on Linux, I quickly found out that due to timing, printf debugging was the only feasible way to find out what's going on.
MichalStrehovsky
added
the
area-NativeAOT-coreclr
jkotas
reviewed
Sep 18, 2020
| { | ||
| #if TARGET_WINDOWS | ||
| private static readonly SafeFileHandle _outputHandle = | ||
| new SafeFileHandle(Interop.Kernel32.GetStdHandle(Interop.Kernel32.HandleTypes.STD_OUTPUT_HANDLE), ownsHandle: false); |
There was a problem hiding this comment.
It may be nice to avoid the SafeHandle, and use WriteFile_IntPtr.cs to print the message instead.
jkotas
reviewed
Sep 18, 2020
| public static class Console | ||
| { | ||
| #if TARGET_WINDOWS | ||
| private static readonly SafeFileHandle _outputHandle = |
There was a problem hiding this comment.
Nit: Statics should have s_ prefix
jkotas
reviewed
Sep 18, 2020
| @@ -23,3 +25,12 @@ int32_t SystemNative_SNPrintF(char* string, int32_t size, const char* format, .. | |||
| va_end(arguments); | |||
| return result; | |||
| } | |||
|
|
|||
| int32_t SystemNative_PrintF(const char* format, ...) | |||
There was a problem hiding this comment.
I think it would be better to expose this as SystemNative_Log that just prints string. There is an existing iOS-specific SystemNative_Log.
I think so. |
|
Superseded by dotnet/runtime#42983. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same Internal.Console that CoreCLR has, but extended with Unix support.
Is there any appetite to have this, potentially in the shared partition?
As I was debugging the timer/threadpool issue on Linux, I quickly found out that due to timing, printf debugging was the only feasible way to find out what's going on.