[NativeAOT] Making Libraries tests to pass with NativeAOT #79509
Conversation
ghost
assigned 
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue Detailsno-op change to see what tests are passing in runtime-extra-platforms
|
VSadov
changed the title
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -492,6 +492,8 @@ | |||
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Net.Mail\tests\Functional\System.Net.Mail.Functional.Tests.csproj" | |||
| Condition="'$(TargetOS)' == 'windows'"/> | |||
|
|
|||
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Data.DataSetExtensions\tests\System.Data.DataSetExtensions.Tests.csproj" /> | |||
There was a problem hiding this comment.
This is the place where we dump projects that were not triaged.
The projects that were looked at and have an active bug are at the top of the ItemGroup, with a link to the issue.
It would be better if we could do this with an ActiveIssue on a specific test, but I don't know how many of the tests are failing here.
There was a problem hiding this comment.
I think this may be fixable. Likely just add some rd.xml. I just did not have time to do that.
There was a problem hiding this comment.
The failure mode is suspicious, like I wrote in #79513 (comment). This would not be RD.XML. The library is supposed to be AOT-compatible - we did the work in the summer.
I cannot repro this locally:
C:\git\runtime\artifacts\bin\System.Data.DataSetExtensions.Tests\Release\net8.0\publish>System.Data.DataSetExtensions.Tests.exe -notrait category=failing
Running assembly:System.Data.DataSetExtensions.Tests, Version=4.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51
Finished System.Data.DataSetExtensions.Tests, Version=4.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51
Tests run: 103, Errors: 0, Failures: 0, Skipped: 0. Time: 0.0294375s
There was a problem hiding this comment.
I dug out the failure from pipelines (force pushing removed all the Github UI to access that). I wiped my artifacts and going to try to repro this locally with a clean slate. If we're getting the stack the CI is getting, something is seriously wrong.
|
Closing in favor of #79523. |
indirect
MethodInfo.MakeGenericMethod()use in a static constructor, maybe fixable, will disable for now.Re: #79513