Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NativeAOT] Making Libraries tests to pass with NativeAOT #79509

Closed
wants to merge 2 commits into from
+2 −0
Closed

[NativeAOT] Making Libraries tests to pass with NativeAOT #79509

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e77676
disable System.Data.DataSetExtensions.Tests on NativeAOT (unsupported…
VSadov Dec 11, 2022
a812870
"libraries" shoud not be in the path for an exclusion item
VSadov Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/libraries/tests.proj
View file
Original file line number Diff line number Diff line change
@@ -492,6 +492,8 @@
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Net.Mail\tests\Functional\System.Net.Mail.Functional.Tests.csproj"
Condition="'$(TargetOS)' == 'windows'"/>

<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Data.DataSetExtensions\tests\System.Data.DataSetExtensions.Tests.csproj" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the place where we dump projects that were not triaged.

The projects that were looked at and have an active bug are at the top of the ItemGroup, with a link to the issue.

It would be better if we could do this with an ActiveIssue on a specific test, but I don't know how many of the tests are failing here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may be fixable. Likely just add some rd.xml. I just did not have time to do that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure mode is suspicious, like I wrote in #79513 (comment). This would not be RD.XML. The library is supposed to be AOT-compatible - we did the work in the summer.

I cannot repro this locally:

C:\git\runtime\artifacts\bin\System.Data.DataSetExtensions.Tests\Release\net8.0\publish>System.Data.DataSetExtensions.Tests.exe -notrait category=failing
Running assembly:System.Data.DataSetExtensions.Tests, Version=4.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51
Finished System.Data.DataSetExtensions.Tests, Version=4.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51

Tests run: 103, Errors: 0, Failures: 0, Skipped: 0. Time: 0.0294375s

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dug out the failure from pipelines (force pushing removed all the Github UI to access that). I wiped my artifacts and going to try to repro this locally with a clean slate. If we're getting the stack the CI is getting, something is seriously wrong.


<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Net.Http.Json\tests\FunctionalTests\System.Net.Http.Json.Functional.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Linq.Parallel\tests\System.Linq.Parallel.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Text.Json\tests\System.Text.Json.Tests\System.Text.Json.Tests.csproj" />