[main] Update dependencies from 10 repositories #83624

… 20230317.1 runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter From Version 14.0.0-alpha.1.23165.1 -> To Version 14.0.0-alpha.1.23167.1

…otnet-optimization build 20230317.4 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23166.4 -> To Version 1.0.0-prerelease.23167.4

Microsoft.NETCore.Runtime.ICU.Transport From Version 8.0.0-preview.3.23163.3 -> To Version 8.0.0-preview.3.23167.1

…17.2 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.3.23167.1 -> To Version 8.0.0-preview.3.23167.2

…0320.1 Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json From Version 8.0.0-preview.3.23162.2 -> To Version 8.0.0-preview.3.23170.1

…20.1 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.3.23167.1 -> To Version 8.0.0-preview.4.23170.1

… 20230320.2 runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter From Version 14.0.0-alpha.1.23165.1 -> To Version 14.0.0-alpha.1.23170.2

… 20230320.3 runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter From Version 14.0.0-alpha.1.23165.1 -> To Version 14.0.0-alpha.1.23170.3

…otnet-optimization build 20230320.4 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23166.4 -> To Version 1.0.0-prerelease.23170.4

Microsoft.NETCore.Runtime.ICU.Transport From Version 8.0.0-preview.3.23163.3 -> To Version 8.0.0-preview.4.23170.4

AndyAyersMS · 2023-04-06T14:42:12Z

My guess is that somehow we have old instrumentation data getting merged with new instrumentation data. With #80481 (Jan 13th) we changed instrumentation strategy from block to edge for all methods, so "old" would be something gathered with a jit built before this change.

AndyAyersMS · 2023-04-06T14:43:39Z

@dotnet/jit-contrib looks like JIT doesn't like the new PGO data from the optimization repo update.

@AndyAyersMS ^. Wonder if having both edge and block counts is actually possible if we inline a method that had blocks?

That should not matter, since we only look at one method's schema at time, so the mixture of block and edge counts is happening within the schema for a single method.

…05.3 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.4.23170.1 -> To Version 8.0.0-preview.4.23205.3

Microsoft.NETCore.Runtime.ICU.Transport From Version 8.0.0-preview.3.23163.3 -> To Version 8.0.0-preview.4.23203.1

trylek · 2023-04-06T18:15:59Z

So, several initial observations so far:

I'm able to repro the bug locally when I pull down the darc source branch and build clr -c Checked. It's probably natural that it doesn't repro in Release mode when C++ assertions are turned off but it's somewhat surprising for me that it also doesn't repro in debug mode.
I'm able to repro the bug even when I merge the darc source branch into runtime main and I revert Michal's change Speed up named type lookups in managed type system #84285 i.o.w. I don't think it's caused by the change.
Looking at the point of assertion failure in the debugger, I see that the problem happens when compiling the method System.RuntimeType.GetMethodBase(RuntimeMethodHandleInternal); in the method throwing the assertion failure I see that fgPgoSchemaCount = 102, fgPgoBlockCount = 38, fgPgoEdgeCount = 21 so we indeed seem to have both types of MIBC data available.
I am not super familiar with details of the MIBC data aggregation; at the first glance everything points to what @AndyAyersMS described - merging data containing block information with data containing edge information.

lewing · 2023-04-06T18:59:29Z

the wasm build test failure is known (#84368 (comment)), I haven't seen the debugger failure before

lewing · 2023-04-06T19:13:53Z

wasm debugger test failure #84440

AndyAyersMS · 2023-04-06T19:40:34Z

I am not super familiar with details of the MIBC data aggregation; at the first glance everything points to what @AndyAyersMS described - merging data containing block information with data containing edge information.

Feel free to disable this assert if it helps move things along, and open an issue for follow-up.

trylek · 2023-04-06T21:26:33Z

Thanks @AndyAyersMS for your feedback, that sounds reasonable to me. I have verified that commenting out the assertion check fixes the problem. I have created a new issue

#84446

to track this, I'll publish the PR in a bit.

…331.1 System.Net.MsQuic.Transport From Version 8.0.0-alpha.1.23166.1 -> To Version 8.0.0-alpha.1.23181.1

trylek · 2023-04-07T07:55:14Z

I have just merged in the PR removing the assertion check, the CoreCLR build jobs should start passing now.

danmoseley · 2023-04-07T17:14:56Z

System.Net.Quic.Tests.MsQuicPlatformDetectionTests.SupportedWindowsPlatforms_IsSupportedIsTrue is still failing @CarnaViire @karelz

ericstj · 2023-04-07T17:16:09Z

@CarnaViire looks like this got another Quic update and the tests are failing again:

https://dev.azure.com/dnceng-public/public/_build/results?buildId=231234&view=ms.vss-test-web.build-test-results-tab&runId=4385788&resultId=144479&paneView=debug

I pulled the logs from helix:
console.7bf6a32e.log
Looks like the QUIC version detection was failing.

While I was there I went ahead and debugged it, this TryLoad is failing:

runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicApi.cs

Lines 68 to 69 in dae6c24

    
           if (!NativeLibrary.TryLoad($"{Interop.Libraries.MsQuic}.{s_minMsQuicVersion.Major}", typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out IntPtr msQuicHandle) && 
        
               !NativeLibrary.TryLoad(Interop.Libraries.MsQuic, typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle))

That's happening because there are no msquic.dll binary in the shared framework. If I drop the msquic.dll into the test's shared framework it fixes it.

If I have a look at the transport package that Quic comes from it seems that it was split up:
https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet8-transport/NuGet/System.Net.MsQuic.Transport/overview/8.0.0-alpha.1.23166.1 contains binaries vs https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet8-transport/NuGet/System.Net.MsQuic.Transport/overview/8.0.0-alpha.1.23181.1 has no binaries and instead has package references for each runtime package containing binaries.

Looks like @hoyosjs made this change here: dotnet/msquic#138
That will require update here:

runtime/src/libraries/System.Net.Quic/src/System.Net.Quic.csproj

Lines 150 to 153 in 0760f77

    
           <NativeBinPlaceItem Include="$(PkgSystem_Net_MsQuic_Transport)\runtimes\win10-$(TargetArchitecture)\native\*" 
        
                               Condition="'$(UseQuicTransportPackage)' == 'true'" /> 
        
           <NativeBinPlaceItem Include="$(PkgMicrosoft_Native_Quic_MsQuic_Schannel)\build\native\bin\$(TargetArchitecture)\*" 
        
                               Condition="'$(UseQuicTransportPackage)' != 'true'" />

danmoseley · 2023-04-07T17:16:34Z

    Wasm.Build.Tests.Blazor.MiscTests.DefaultTemplate_AOT_InProjectFile(config: "Debug") [FAIL]
      Assert.DoesNotContain() Failure
      Found:    Microsoft.JSInterop.WebAssembly.dll -> Microsoft.JSInterop.WebAssembly.dll.bc

…ld 20230331.1" This reverts commit 11b8041.

lewing · 2023-04-07T17:31:33Z

See #83624 (comment) this failure isn't unique to this pr and the fix is in dotnet/installer#16005 but blocked by source build problems there. It should not be considered blocking here.

dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Mar 17, 2023

This was referenced Mar 18, 2023

Tracking issue for CI build timeouts #76454

Closed

Roslyn source generator crash on mono/linux/arm64 #81123

Closed

dotnet-maestro bot changed the title ~~[main] Update dependencies from dotnet/llvm-project~~ [main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization Mar 18, 2023

Update dependencies from https://github.com/dotnet/icu build 20230317.1

b7e1cd6

Microsoft.NETCore.Runtime.ICU.Transport From Version 8.0.0-preview.3.23163.3 -> To Version 8.0.0-preview.3.23167.1

dotnet-maestro bot changed the title ~~[main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization~~ [main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu Mar 18, 2023

Update dependencies from https://github.com/dotnet/emsdk build 202303…

abf18fc

…17.2 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.3.23167.1 -> To Version 8.0.0-preview.3.23167.2

dotnet-maestro bot changed the title ~~[main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu~~ [main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu dotnet/emsdk Mar 18, 2023

dotnet-maestro bot changed the title ~~[main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu dotnet/emsdk~~ [main] Update dependencies from dotnet/llvm-project dotnet/icu dotnet/emsdk dnceng/internal/dotnet-optimization Mar 19, 2023

dotnet-maestro bot changed the title ~~[main] Update dependencies from dotnet/llvm-project dotnet/icu dotnet/emsdk dnceng/internal/dotnet-optimization~~ [main] Update dependencies from dotnet/llvm-project dotnet/emsdk dnceng/internal/dotnet-optimization dotnet/icu Mar 19, 2023

dotnet-maestro bot changed the title ~~[main] Update dependencies from dotnet/llvm-project dotnet/emsdk dnceng/internal/dotnet-optimization dotnet/icu~~ [main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu dotnet/emsdk Mar 19, 2023

dotnet-maestro bot changed the title ~~[main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu dotnet/emsdk~~ [main] Update dependencies from dotnet/llvm-project dotnet/icu dotnet/emsdk dnceng/internal/dotnet-optimization Mar 20, 2023

dotnet-maestro bot changed the title ~~[main] Update dependencies from dotnet/llvm-project dotnet/icu dotnet/emsdk dnceng/internal/dotnet-optimization~~ [main] Update dependencies from dotnet/llvm-project dotnet/emsdk dnceng/internal/dotnet-optimization dotnet/icu Mar 20, 2023

dotnet-maestro bot changed the title ~~[main] Update dependencies from dotnet/llvm-project dotnet/emsdk dnceng/internal/dotnet-optimization dotnet/icu~~ [main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu dotnet/emsdk Mar 20, 2023

dotnet-maestro bot changed the title ~~[main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu dotnet/emsdk~~ [main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu dotnet/emsdk dotnet/runtime Mar 20, 2023

This was referenced Mar 20, 2023

IOException running NuGet-Migrations during tests in dotnet CLI first run #80619

Closed

WasmTestOnBrowser-System.* test failures in CI #83655

Closed

Update dependencies from https://github.com/dotnet/emsdk build 202303…

74a3e65

…20.1 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.3.23167.1 -> To Version 8.0.0-preview.4.23170.1

build-analysis bot mentioned this pull request Mar 21, 2023

[release/6.0] Doublelinklist GC failures on Mono #83245

Closed

dotnet-maestro bot added 2 commits March 21, 2023 05:21

Update dependencies from https://github.com/dotnet/icu build 20230320.4

4ffc33b

Microsoft.NETCore.Runtime.ICU.Transport From Version 8.0.0-preview.3.23163.3 -> To Version 8.0.0-preview.4.23170.4

dotnet-maestro bot added 2 commits April 6, 2023 15:23

Update dependencies from https://github.com/dotnet/emsdk build 202304…

4268ef0

…05.3 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.4.23170.1 -> To Version 8.0.0-preview.4.23205.3

Update dependencies from https://github.com/dotnet/icu build 20230403.1

bbdd8e0

Microsoft.NETCore.Runtime.ICU.Transport From Version 8.0.0-preview.3.23163.3 -> To Version 8.0.0-preview.4.23203.1

build-analysis bot mentioned this pull request Apr 6, 2023

[mono][linux][x64] crash in ep_buffer_manager_write_event #84257

Closed

trylek mentioned this pull request Apr 6, 2023

Most recent MIBC optimization data contains a combo of block and edge counts crashing JIT in Crossgen2 #84446

Closed

This was referenced Apr 6, 2023

[NO-MERGE] 83624 jit assert instrumented with darc change #84450

Closed

Mitigation for #84446: comment out problematic JIT assertion check #84449

Merged

Update dependencies from https://github.com/dotnet/msquic build 20230…

11b8041

…331.1 System.Net.MsQuic.Transport From Version 8.0.0-alpha.1.23166.1 -> To Version 8.0.0-alpha.1.23181.1

trylek closed this Apr 7, 2023

trylek reopened this Apr 7, 2023

Revert "Update dependencies from https://github.com/dotnet/msquic bui…

d3381a2

…ld 20230331.1" This reverts commit 11b8041.

EgorBo mentioned this pull request Apr 10, 2023

[Perf] Regressions in Dictionary and Hashset on 9/24/2022 1:05:07 PM #76256

Closed

steveisok self-requested a review April 10, 2023 15:47

steveisok approved these changes Apr 10, 2023

View reviewed changes

steveisok merged commit 7b6ab05 into main Apr 10, 2023

steveisok deleted the darc-main-41d2dc4d-4dcd-43dc-9026-d043b8ad94be branch April 10, 2023 15:51

This was referenced Apr 22, 2023

Gradual regression of System.Buffers.Tests.ReadOnlySequenceTests<Char>.IterateGetPositionArray from net6.0 to net7.0-rc2 #77028

Closed

Investigate microbenchmarks that regress with PGO enabled #84264

Closed

ghost locked as resolved and limited conversation to collaborators May 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from 10 repositories #83624

[main] Update dependencies from 10 repositories #83624

dotnet-maestro bot commented Mar 17, 2023 •

edited

Loading

AndyAyersMS commented Apr 6, 2023

AndyAyersMS commented Apr 6, 2023

trylek commented Apr 6, 2023

lewing commented Apr 6, 2023 •

edited

Loading

lewing commented Apr 6, 2023

AndyAyersMS commented Apr 6, 2023

trylek commented Apr 6, 2023

trylek commented Apr 7, 2023

danmoseley commented Apr 7, 2023

ericstj commented Apr 7, 2023

danmoseley commented Apr 7, 2023

lewing commented Apr 7, 2023

[main] Update dependencies from 10 repositories #83624

[main] Update dependencies from 10 repositories #83624

Conversation

dotnet-maestro bot commented Mar 17, 2023 • edited Loading

From https://github.com/dotnet/llvm-project

From https://dev.azure.com/dnceng/internal/_git/dotnet-optimization

From https://github.com/dotnet/icu

From https://github.com/dotnet/emsdk

From https://github.com/dotnet/runtime

From https://github.com/dotnet/msquic

From https://github.com/dotnet/cecil

From https://github.com/dotnet/xharness

From https://github.com/dotnet/runtime-assets

From https://github.com/dotnet/hotreload-utils

AndyAyersMS commented Apr 6, 2023

AndyAyersMS commented Apr 6, 2023

trylek commented Apr 6, 2023

lewing commented Apr 6, 2023 • edited Loading

lewing commented Apr 6, 2023

AndyAyersMS commented Apr 6, 2023

trylek commented Apr 6, 2023

trylek commented Apr 7, 2023

danmoseley commented Apr 7, 2023

ericstj commented Apr 7, 2023

danmoseley commented Apr 7, 2023

lewing commented Apr 7, 2023

dotnet-maestro bot commented Mar 17, 2023 •

edited

Loading

lewing commented Apr 6, 2023 •

edited

Loading