[PERF] Revert "performance-setup.sh requires urllib3 version <2 (#85915)" #86009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b132963.
|
Tagging subscribers to this area: @hoyosjs |
|
This only impacts perf pipeline, merging once approved. |
sblom
approved these changes
May 9, 2023
LoopedBard3
added a commit
to LoopedBard3/runtime
that referenced
this pull request
Jun 7, 2023
…" (dotnet#86009) This reverts commit b132963.
carlossanlop
pushed a commit
that referenced
this pull request
Jun 12, 2023
* Pin urllib to version 1.26.15 based on github comments to fix ssl requests error. (#85881) * Previous changes fixed some runs, but some are still broken due to reinstall installing a broken urllib version. (#85935) * Revert "Previous changes fixed some runs, but some are still broken due to reinstall installing a broken urllib version. (#85935)" (#86000) This reverts commit 4ea93a6 due to the commit seemingly causes major failure in the pipelines. * Revert "performance-setup.sh requires urllib3 version <2 (#85915)" (#86009) This reverts commit b132963. * [PERF] Reorder urllib and remove --force-reinstall but keep pinned version (#86128) * Move scenario urllib imports to the last install position. * Remove force-reinstall from all pip installs in the scenarios-job.yml files.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b132963. Runs between this and the initial fix (#85881) were the most successful, reverting back to that slightly better state.