[Release/7.0][PERF] Backport urllib fix to release/7.0 #87286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…install installing a broken urllib version. (dotnet#85935)
…ue to reinstall installing a broken urllib version. (dotnet#85935)" (dotnet#86000) This reverts commit 4ea93a6 due to the commit seemingly causes major failure in the pipelines.
…" (dotnet#86009) This reverts commit b132963.
…rsion (dotnet#86128) * Move scenario urllib imports to the last install position. * Remove force-reinstall from all pip installs in the scenarios-job.yml files.
LoopedBard3
requested review from
sblom,
cincuranet,
DrewScoggins and
caaavik-msft
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsBackports changes for dotnet/performance#3010 to the release/7.0-staging branch for eventual merge into release/7.0.
|
LoopedBard3
changed the title
LoopedBard3
added a commit
to LoopedBard3/runtime
that referenced
this pull request
Jun 8, 2023
…ing the urllib install based on the release/7.0 backport of the same changes (dotnet#87286).
cincuranet
approved these changes
Jun 9, 2023
|
@carlossanlop Can I get this merged? It is a perf infra only change. Thanks! |
|
@carlossanlop Just to make sure there is no confusion, there are 2 PR's doing similar things. This one is for release/7.0 and another for release/6.0 (which has already been merged). |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports changes for dotnet/performance#3010 to the release/7.0-staging branch for eventual merge into release/7.0.