Update (remove most) most of CLRTestKind, GenerateRunScript, RestorePackages

[markples]

I came across these while looking at the set of properties in order to generate some error checking for merged groups. As best as I can tell, most of these are very old uses that likely have had the test system changed from under them. They cause confusion when encountered.

• RestorePackages - I think has been replaced by the logic that bulk restores.
• CLRTestKind - A (somewhat) more recent change was Switch over Loader/classloader/TypeGeneratorTests to use merged wrappers #61942, which changed the default for CLRTestKind from "BuildAndRun" to "BuildAndRun if exe, else BuildOnly". However, BuildOnly appears to be intended for exes - build the exe but not test infrastructure to execute it as another project will handle that. I think SharedLibrary is what was intended here. Many OutputType=library tests specify BuildOnly or SharedLibrary, which seem incorrect and (now) unnecessary.
• GenerateRunScript - This is unconditionally set (overriding individual project files) in src/tests/Directory.Build.targets.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

Issue Details

---

null

Author:	markples
Assignees:	markples
Labels:	area-System.Reflection.Metadata
Milestone:	-

[markples]

@trylek @jkoritzinsky This is fallout from staring at msbuild properties too long for merged groups.

cc @dotnet/jit-contrib @Maoni0 @cshung @mrsharm

I'm a bit concerned that the checkin gate doesn't provide complete coverage so would welcome additional tests to run.

[markples]

/azp run runtime-coreclr outerloop, runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[markples]

One little static check on the contents of the diff:

C:\r\runtime4\src\tests>git diff dotnet/main prop_update | findstr "^+ ^-" | findstr /v "^+++ ^---" | sort | uniq
-
-    <CLRTestKind Condition="'$(CLRTestKind)' == ''">BuildOnly</CLRTestKind>
-    <CLRTestKind>BuildAndRun</CLRTestKind>
-    <CLRTestKind>BuildOnly</CLRTestKind>
-    <CLRTestKind>SharedLibrary</CLRTestKind>
-    <GenerateRunScript>false</GenerateRunScript>
-    <RestorePackages>false</RestorePackages>
-    <RestorePackages>true</RestorePackages>
-  </PropertyGroup>
-  <PropertyGroup>
+    <CLRTestKind Condition="'$(CLRTestKind)' == ''">SharedLibrary</CLRTestKind>

The conditional updates are the change to the default in Directory.Build.targets. The PropertyGroup removals are intended (not unchecked) removals of (now) empty groups.

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

---

I came across these while looking at the set of properties in order to generate some error checking for merged groups. As best as I can tell, most of these are very old uses that likely have had the test system changed from under them. They cause confusion when encountered.

• RestorePackages - I think has been replaced by the logic that bulk restores.
• CLRTestKind - A (somewhat) more recent change was Switch over Loader/classloader/TypeGeneratorTests to use merged wrappers #61942, which changed the default for CLRTestKind from "BuildAndRun" to "BuildAndRun if exe, else BuildOnly". However, BuildOnly appears to be intended for exes - build the exe but not test infrastructure to execute it as another project will handle that. I think SharedLibrary is what was intended here. Many OutputType=library tests specify BuildOnly or SharedLibrary, which seem incorrect and (now) unnecessary.
• GenerateRunScript - This is unconditionally set (overriding individual project files) in src/tests/Directory.Build.targets.

Author:	markples
Assignees:	markples
Labels:	area-CodeGen-coreclr
Milestone:	-

[trylek]

Thanks Mark for cleaning this up!

[trylek]

Based on offline discussion with Mark I have rebased this change against latest main and I plan to retest it and merge it in once it passes as the start of my quality week activities as Mark has fully switched over to GC work.

[trylek]

/azp run runtime-extra-platforms

[trylek]

/azp run runtime-coreclr outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[trylek]

Runtime and outerloop runs are clean and for the runtime-extra-platforms I haven't found any issues different from a previous run, merging in.

[MichalStrehovsky]

We stopped running the SharedLibrary test after this change.

I'm putting back the ClrTestKind for this test in #91356 but I do wonder if there's any other test we stopped running by dropping ClrTestKind.

[markples]

This one happened because the test was marked OutputType==library and ClrTestKind=BuildAndRun. However, it looks like it depends on a native entry point (and CLRTestBatchPreCommands, etc.), so the managed part of the test is "library" but the overall project is an executable. I just did a scan of all proj files in that commit that removed BuildAndRun, and SharedLibrary is the only one of the ~30 that doesn't have OutputType==exe.