Fixed Enumerator variable null check #89920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed error when _hashtableContentsToEnumerate is null. It appears always when using 'Length' property when variable is null. Also reduced nesting.
ghost
added
the
community-contribution
|
@dotnet-policy-service agree |
MichalStrehovsky
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
Thanks!
@VSadov could you also have a look? I'm always afraid when I see lock free because I know enough about lock free programming to understand I'm not qualified to write or review such code.
|
Hi, are there any updates on my pull request? |
|
I will take a look today. |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Aug 11, 2023
|
@PabloKharo - looks good to me. I just want to run a few more tests to be sure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed error when _hashtableContentsToEnumerate is null.
Error will always appear when this variable is null when using 'Length' property.
Also reduced nesting.
The error was detected using the Svace analyzer maded by ISP RAS.